diff mbox

[U-Boot] Driver model test breakages

Message ID 566A5FAE.5000407@wytron.com.tw
State RFC
Delegated to: Simon Glass
Headers show

Commit Message

Thomas Chou Dec. 11, 2015, 5:31 a.m. UTC
Hi Simon,

On 2015年12月11日 10:05, Simon Glass wrote:
> Hi,
>
> The following three commits causes breakages in the driver model tests:
>
> 4efad20a      sf: Update status reg check in spi_flash_cmd_wait_ready
> 45b47734     net/arp: account for ARP delay, avoid duplicate packets on timeout
> 9961a0b6    sandbox: add a sandbox timer and basic test
>
> Can you please take a look? You can run them with ./test/dm/test-dm.sh
>
> The last one looks a bit complicated - I suspect it will be harder to
> fix. I am going to try to come up with some ideas...
>
> Regards,
> Simon
>

I didn't add a timer to test.dts. Please check if the dm timer fixed 
with this patch.
##############################################
################################################

My test stopped at,
Test: dm_test_net_retry

How do I bypass this?

Best regards,
Thomas

Comments

Simon Glass Dec. 19, 2015, 11:07 p.m. UTC | #1
Hi Thomas,

On 10 December 2015 at 22:31, Thomas Chou <thomas@wytron.com.tw> wrote:
> Hi Simon,
>
>
> On 2015年12月11日 10:05, Simon Glass wrote:
>>
>> Hi,
>>
>> The following three commits causes breakages in the driver model tests:
>>
>> 4efad20a      sf: Update status reg check in spi_flash_cmd_wait_ready
>> 45b47734     net/arp: account for ARP delay, avoid duplicate packets on
>> timeout
>> 9961a0b6    sandbox: add a sandbox timer and basic test
>>
>> Can you please take a look? You can run them with ./test/dm/test-dm.sh
>>
>> The last one looks a bit complicated - I suspect it will be harder to
>> fix. I am going to try to come up with some ideas...
>>
>> Regards,
>> Simon
>>
>
> I didn't add a timer to test.dts. Please check if the dm timer fixed with
> this patch.
> ##############################################
> diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts
> index b6d9a15..2e0d320 100644
> --- a/arch/sandbox/dts/test.dts
> +++ b/arch/sandbox/dts/test.dts
> @@ -279,6 +279,11 @@
>                         0x38 8>;
>         };
>
> +       timer {
> +               compatible = "sandbox,timer";
> +               clock-frequency = <1000000>;
> +       };
> +
>         uart0: serial {
>                 compatible = "sandbox,serial";
>                 u-boot,dm-pre-reloc;
> ################################################
>
> My test stopped at,
> Test: dm_test_net_retry
>
> How do I bypass this?

You can comment out the test declaration in test/dm/eth.c.

Regards,
Simon
diff mbox

Patch

diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts
index b6d9a15..2e0d320 100644
--- a/arch/sandbox/dts/test.dts
+++ b/arch/sandbox/dts/test.dts
@@ -279,6 +279,11 @@ 
  			0x38 8>;
  	};

+	timer {
+		compatible = "sandbox,timer";
+		clock-frequency = <1000000>;
+	};
+
  	uart0: serial {
  		compatible = "sandbox,serial";
  		u-boot,dm-pre-reloc;