Patchwork net: Fix error in comment on net_device_ops::ndo_get_stats

login
register
mail settings
Submitter Ben Hutchings
Date June 14, 2010, 3:19 p.m.
Message ID <1276528781.2074.0.camel@achroite.uk.solarflarecom.com>
Download mbox | patch
Permalink /patch/55548/
State Accepted
Delegated to: David Miller
Headers show

Comments

Ben Hutchings - June 14, 2010, 3:19 p.m.
ndo_get_stats still returns struct net_device_stats *; there is
no struct net_device_stats64.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
 include/linux/netdevice.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
David Miller - June 15, 2010, 10:10 p.m.
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 14 Jun 2010 16:19:41 +0100

> ndo_get_stats still returns struct net_device_stats *; there is
> no struct net_device_stats64.
> 
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>

Applied.

But, I am ignoring every single patch you submit from here on
out that lacks a proper "net-2.6" or "net-next-2.6" destination
tree indication in your Subject line.

I've asked this of you at least 3 times, and you seem content to just
ignore my request.  But that's OK, as I think you'll stop ignoring
me when it starts causing patches you care about to be dropped.

Thanks :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ben Hutchings - June 15, 2010, 10:24 p.m.
On Tue, 2010-06-15 at 15:10 -0700, David Miller wrote:
> From: Ben Hutchings <bhutchings@solarflare.com>
> Date: Mon, 14 Jun 2010 16:19:41 +0100
> 
> > ndo_get_stats still returns struct net_device_stats *; there is
> > no struct net_device_stats64.
> > 
> > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> 
> Applied.
> 
> But, I am ignoring every single patch you submit from here on
> out that lacks a proper "net-2.6" or "net-next-2.6" destination
> tree indication in your Subject line.
> 
> I've asked this of you at least 3 times, and you seem content to just
> ignore my request.  But that's OK, as I think you'll stop ignoring
> me when it starts causing patches you care about to be dropped.
> 
> Thanks :-)

Sorry Dave, I thought net-next-2.6 was still the default and I only
needed to make it more obvious when I wanted patches to go to net-2.6.
I've added the suffix to my git configuration now.

Ben.

Patch

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index d85a38e..4164285 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -671,7 +671,7 @@  struct netdev_rx_queue {
  *	1. Define @ndo_get_stats64 to update a rtnl_link_stats64 structure
  *	   (which should normally be dev->stats64) and return a ponter to
  *	   it. The structure must not be changed asynchronously.
- *	2. Define @ndo_get_stats to update a net_device_stats64 structure
+ *	2. Define @ndo_get_stats to update a net_device_stats structure
  *	   (which should normally be dev->stats) and return a pointer to
  *	   it. The structure may be changed asynchronously only if each
  *	   field is written atomically.