config: allow config to handle longer path names

Submitted by Markus Mayer on Dec. 10, 2015, 10:13 p.m.

Details

Message ID 1449785591-12550-1-git-send-email-mmayer@broadcom.com
State New
Headers show

Commit Message

Markus Mayer Dec. 10, 2015, 10:13 p.m.
The current (arbitrary) limit of 128 characters for path names has
proven too short for Android builds, as longer path names are used
there.

Change conf.c, so it can handle path lengths up to PATH_MAX characters.

Signed-off-by: Markus Mayer <mmayer@broadcom.com>
---

This change was also submitted to the Linux community and has been
accepted.

https://git.kernel.org/cgit/linux/kernel/git/mmarek/kbuild.git/commit/?h=kconfig&id=74dba80913775c78a1e03221c9ea51027a8b7bcf

 extra/config/conf.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Patch hide | download patch | download mbox

diff --git a/extra/config/conf.c b/extra/config/conf.c
index b24c1c3..34bb4f5 100644
--- a/extra/config/conf.c
+++ b/extra/config/conf.c
@@ -5,6 +5,7 @@ 
 
 #include <locale.h>
 #include <ctype.h>
+#include <limits.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
@@ -40,7 +41,7 @@  static int tty_stdio;
 static int valid_stdin = 1;
 static int sync_kconfig;
 static int conf_cnt;
-static char line[128];
+static char line[PATH_MAX];
 static struct menu *rootEntry;
 
 static void print_help(struct menu *menu)
@@ -108,7 +109,7 @@  static int conf_askvalue(struct symbol *sym, const char *def)
 		/* fall through */
 	case oldaskconfig:
 		fflush(stdout);
-		xfgets(line, 128, stdin);
+		xfgets(line, sizeof(line), stdin);
 		if (!tty_stdio)
 			printf("\n");
 		return 1;
@@ -310,7 +311,7 @@  static int conf_choice(struct menu *menu)
 			/* fall through */
 		case oldaskconfig:
 			fflush(stdout);
-			xfgets(line, 128, stdin);
+			xfgets(line, sizeof(line), stdin);
 			strip(line);
 			if (line[0] == '?') {
 				print_help(menu);