diff mbox

The test suite for libosmocore fails on big-endian architectures

Message ID 20151209164917.GC3533@dub5
State Superseded
Headers show

Commit Message

Neels Hofmeyr Dec. 9, 2015, 4:49 p.m. UTC 
Two more failures seen on
  https://buildd.debian.org/status/package.php?p=libosmocore


For FreeBSD, both i386 and amd64:

    macaddr.c: In function 'osmo_get_macaddr':
    macaddr.c:106:17: error: 'SIOCGIFHWADDR' undeclared (first use in this function)
      rc = ioctl(fd, SIOCGIFHWADDR, &ifr);
                     ^

The code in question has an explicit FreeBSD alternative which seems to not
have been entered as intended, libosmocore/src/macaddr.c line 50:

"
#if defined(__FreeBSD__) || defined(__APPLE__)
[...]
#else
[...] <-- error is in this block
#endif
"

The same #if appears in numerous places in the osmo code base, so it seems to
be correct ... ? Or all of them are wrong??


Another error on sparc64: three tests fail with a "Bus error" message, which I don't understand:

"
## ------------------------ ##
## Summary of the failures. ##
## ------------------------ ##
Failed tests:
libosmocore 0.9.0 test suite test groups:

 NUM: FILE-NAME:LINE     TEST-GROUP-NAME
      KEYWORDS

   3: testsuite.at:18    bits
      bits
  19: testsuite.at:121   gprs-bssgp
      gprs-bssgp
  20: testsuite.at:127   gprs-ns
      gprs-ns

## ---------------------- ##
## Detailed failed tests. ##
## ---------------------- ##

#                             -*- compilation -*-
3. testsuite.at:18: testing bits ...
./testsuite.at:21: $abs_top_builddir/tests/bits/bitrev_test
diff mbox

Patch

--- /dev/null 2011-03-04 11:53:52.000000000 +0000
+++ /«PKGBUILDDIR»/tests/testsuite.dir/at-groups/3/stderr 2015-12-09 08:07:05.318729809 +0000
@@ -0,0 +1 @@ 
+/«PKGBUILDDIR»/tests/testsuite.dir/at-groups/3/test-source: line 25: 14139 Bus error               $abs_top_builddir/tests/bits/bitrev_test
--- expout  2015-12-09 08:07:05.018702966 +0000
+++ /«PKGBUILDDIR»/tests/testsuite.dir/at-groups/3/stdout 2015-12-09 08:07:05.022703325 +0000
@@ -1,55 +0,0 @@ 
-INORDER:  01 02 04 08 10 20 40 80 
-REVERSED: 80 40 20 10 08 04 02 01 
-
-INORDER:  02 04 08 10 20 40 80 
-REVERSED: 40 20 10 08 04 02 01 
[...]
"
(many expected output lines missing)

Could it be a sporadic HW failure on the machine itself, or something?
The "bitrev_test" doesn't really look like something that would fail because of
a bus.

~Neels


-- 
- Neels Hofmeyr <nhofmeyr@sysmocom.de>          http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschäftsführer / Managing Directors: Holger Freyther, Harald Welte