From patchwork Sun Jun 13 12:15:39 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 55415 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 3042F1007D1 for ; Sun, 13 Jun 2010 22:17:28 +1000 (EST) Received: from localhost ([127.0.0.1]:45829 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ONm7x-0001kD-Ip for incoming@patchwork.ozlabs.org; Sun, 13 Jun 2010 08:17:25 -0400 Received: from [140.186.70.92] (port=44579 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ONm6W-0001j0-5C for qemu-devel@nongnu.org; Sun, 13 Jun 2010 08:15:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ONm6V-00032C-0c for qemu-devel@nongnu.org; Sun, 13 Jun 2010 08:15:56 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:59696) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ONm6U-00031s-Nz for qemu-devel@nongnu.org; Sun, 13 Jun 2010 08:15:54 -0400 Received: from smtp01.web.de ( [172.20.0.243]) by fmmailgate02.web.de (Postfix) with ESMTP id 385D516664AB2; Sun, 13 Jun 2010 14:15:54 +0200 (CEST) Received: from [92.74.52.35] (helo=localhost.localdomain) by smtp01.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #4) id 1ONm6U-0004oR-00; Sun, 13 Jun 2010 14:15:54 +0200 From: Jan Kiszka To: Anthony Liguori , qemu-devel@nongnu.org Date: Sun, 13 Jun 2010 14:15:39 +0200 Message-Id: X-Mailer: git-send-email 1.6.0.2 In-Reply-To: References: In-Reply-To: References: X-Sender: jan.kiszka@web.de X-Provags-ID: V01U2FsdGVkX19B1EoGiZsR97ClN2tQaLyHCcidhQkmsvOJ7SHl t8LT6Yoji8MOj48ZiPTvcvTECOv5VCdBIyiMPhzITL6ryHLRTp SNBPu218k= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 Cc: blue Swirl , Jan Kiszka , Paul Brook , Gleb Natapov , Juan Quintela Subject: [Qemu-devel] [PATCH v4 06/13] hpet: Start/stop timer when HPET_TN_ENABLE is modified X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Jan Kiszka We have to update the qemu timer when the per-timer enable bit is toggled, just like for HPET_CFG_ENABLE changes. Signed-off-by: Jan Kiszka --- hw/hpet.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/hpet.c b/hw/hpet.c index 6974935..041dd84 100644 --- a/hw/hpet.c +++ b/hw/hpet.c @@ -430,6 +430,11 @@ static void hpet_ram_writel(void *opaque, target_phys_addr_t addr, printf("qemu: level-triggered hpet not supported\n"); exit (-1); } + if (activating_bit(old_val, new_val, HPET_TN_ENABLE)) { + hpet_set_timer(timer); + } else if (deactivating_bit(old_val, new_val, HPET_TN_ENABLE)) { + hpet_del_timer(timer); + } break; case HPET_TN_CFG + 4: // Interrupt capabilities DPRINTF("qemu: invalid HPET_TN_CFG+4 write\n");