| Message ID | 566724F4.80806@acm.org |
|---|---|
| State | New |
| Headers | show |
On Tue, 8 Dec 2015, Nathan Sidwell wrote: > These tests no longer cause the PTX assembler to seg fault, so no reason to > skip them. Shouldn't all such cases use 'dg-xfail' rather than 'dg-skip-if'? Should be more reasonable to still run the test and eventually get XPASS'es as ptxas improves. Alexander
On 12/08/15 14:35, Alexander Monakov wrote: > On Tue, 8 Dec 2015, Nathan Sidwell wrote: > >> These tests no longer cause the PTX assembler to seg fault, so no reason to >> skip them. > > Shouldn't all such cases use 'dg-xfail' rather than 'dg-skip-if'? Should be > more reasonable to still run the test and eventually get XPASS'es as ptxas > improves. I have a vague memory that dg-xfail didn't work because of the failure mode -- the harness claimed they were UNRESOLVED. nathan
2015-12-08 Nathan Sidwell <nathan@acm.org> * gcc.c-torture/compile/920723-1.c: Remove PTX skip. * gcc.c-torture/compile/pr33855.c: Likewise. * gcc.c-torture/execute/981019-1.c: Remove PTX -O2 skip. Index: gcc.c-torture/compile/920723-1.c =================================================================== --- gcc.c-torture/compile/920723-1.c (revision 231418) +++ gcc.c-torture/compile/920723-1.c (working copy) @@ -1,4 +1,3 @@ -/* { dg-skip-if "ptxas seg faults" { nvptx-*-* } { "-O2" } { "" } } */ #if defined(STACK_SIZE) && STACK_SIZE < 65536 # define GITT_SIZE 75 Index: gcc.c-torture/compile/pr33855.c =================================================================== --- gcc.c-torture/compile/pr33855.c (revision 231418) +++ gcc.c-torture/compile/pr33855.c (working copy) @@ -1,4 +1,3 @@ -/* { dg-skip-if "ptxas seg faults" { nvptx-*-* } { "-O1" } { "" } } */ /* Testcase by Martin Michlmayr <tbm@cyrius.com> */ /* Used to segfault due to cselim not marking the complex temp var as GIMPLE reg. */ Index: gcc.c-torture/execute/981019-1.c =================================================================== --- gcc.c-torture/execute/981019-1.c (revision 231418) +++ gcc.c-torture/execute/981019-1.c (working copy) @@ -1,4 +1,4 @@ -/* { dg-skip-if "ptxas seg faults" { nvptx-*-* } { "-O2" "-O3*" } { "" } } */ +/* { dg-skip-if "ptxas seg faults" { nvptx-*-* } { "-O3*" } { "" } } */ extern int f2(void); extern int f3(void);