diff mbox

[U-Boot] tools: zynqimage: Clean up check_params

Message ID 1449585883-13332-4-git-send-email-nathan@nathanrossi.com
State Accepted
Delegated to: Michal Simek
Headers show

Commit Message

Nathan Rossi Dec. 8, 2015, 2:44 p.m. UTC 
Clean up the param checking, removing some code paths that will never
happen.

Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Tom Rini <trini@konsulko.com>
---
 tools/zynqimage.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Tom Rini Dec. 8, 2015, 3:03 p.m. UTC | #1 
On Wed, Dec 09, 2015 at 12:44:43AM +1000, Nathan Rossi wrote:

> Clean up the param checking, removing some code paths that will never
> happen.
> 
> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Tom Rini <trini@konsulko.com>

Reported-by: Coverity (CID 133251)
Reviewed-by: Tom Rini <trini@konsulko.com>
Michal Simek Dec. 9, 2015, 7:46 a.m. UTC | #2 
On 8.12.2015 16:03, Tom Rini wrote:
> On Wed, Dec 09, 2015 at 12:44:43AM +1000, Nathan Rossi wrote:
> 
>> Clean up the param checking, removing some code paths that will never
>> happen.
>>
>> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
>> Cc: Michal Simek <michal.simek@xilinx.com>
>> Cc: Tom Rini <trini@konsulko.com>
> 
> Reported-by: Coverity (CID 133251)
> Reviewed-by: Tom Rini <trini@konsulko.com>
> 

Applied.

Thanks,
Michal
diff mbox

Patch

diff --git a/tools/zynqimage.c b/tools/zynqimage.c
index 25f558d..c43bd5d 100644
--- a/tools/zynqimage.c
+++ b/tools/zynqimage.c
@@ -212,8 +212,7 @@  static int zynqimage_check_params(struct image_tool_params *params)
 		return -1;
 	}
 
-	return !((params->lflag || params->dflag) ||
-			(params->dflag && params->eflag));
+	return !(params->lflag || params->dflag);
 }
 
 static int zynqimage_check_image_types(uint8_t type)