| Message ID | 1449585883-13332-2-git-send-email-nathan@nathanrossi.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Glass |
| Headers | show |
Hi Nathan, On 8 December 2015 at 07:44, Nathan Rossi <nathan@nathanrossi.com> wrote: > The Device Model sequence alias feature is required by some Uclasses. > > Specifically SPI which picks the bus to use based on the sequence. > Without this the SPI Uclass will not probe any bus and will fail which > prevents SPL from using SPI flash as a boot location. > > Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> > Cc: Simon Glass <sjg@chromium.org> > Cc: Masahiro Yamada <yamada.masahiro@socionext.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > --- > include/config_uncmd_spl.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/config_uncmd_spl.h b/include/config_uncmd_spl.h > index 6e299f6..3b198ae 100644 > --- a/include/config_uncmd_spl.h > +++ b/include/config_uncmd_spl.h > @@ -29,7 +29,6 @@ > #endif > > #undef CONFIG_DM_WARN > -#undef CONFIG_DM_SEQ_ALIAS > #undef CONFIG_DM_STDIO > > #endif /* CONFIG_SPL_BUILD */ > -- > 2.6.2 > We'd like to drop this file. Can you instead please add CONFIG_SPL_DM_SEQ_ALIAS as a new Kconfig. There is only one place in the code (device.c) that you need to change. I think for now it should default to n, but you could enable it for your board? I'm not sure of the size impact of enabling it by default. Regards, Simon
diff --git a/include/config_uncmd_spl.h b/include/config_uncmd_spl.h index 6e299f6..3b198ae 100644 --- a/include/config_uncmd_spl.h +++ b/include/config_uncmd_spl.h @@ -29,7 +29,6 @@ #endif #undef CONFIG_DM_WARN -#undef CONFIG_DM_SEQ_ALIAS #undef CONFIG_DM_STDIO #endif /* CONFIG_SPL_BUILD */
The Device Model sequence alias feature is required by some Uclasses. Specifically SPI which picks the bus to use based on the sequence. Without this the SPI Uclass will not probe any bus and will fail which prevents SPL from using SPI flash as a boot location. Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> Cc: Simon Glass <sjg@chromium.org> Cc: Masahiro Yamada <yamada.masahiro@socionext.com> Cc: Linus Walleij <linus.walleij@linaro.org> --- include/config_uncmd_spl.h | 1 - 1 file changed, 1 deletion(-)