| Message ID | 1449527952-8399-4-git-send-email-christophe-h.ricard@st.com |
|---|---|
| State | New |
| Headers | show |
On Mon, Dec 07, 2015 at 11:39:12PM +0100, Christophe Ricard wrote: > spi->irq was ignoring GpioInt property setting it to -1. > acpi_dev_gpio_irq_get returns and configure the slave irq according to > the acpi slave node description. > It is now inline with devicetree behavior. > > Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com> > --- > drivers/spi/spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index a5f53de..5c10815 100644 > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -1534,7 +1534,7 @@ static acpi_status acpi_spi_add_device(acpi_handle handle, u32 level, > } > > ACPI_COMPANION_SET(&spi->dev, adev); > - spi->irq = -1; > + spi->irq = acpi_dev_gpio_irq_get(ACPI_COMPANION(&spi->dev), 0); You can use "adev" here instead of ACPI_COMPANION(&spi->dev). > > INIT_LIST_HEAD(&resource_list); > ret = acpi_dev_get_resources(adev, &resource_list, > -- > 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Dec 07, 2015 at 11:39:12PM +0100, Christophe Ricard wrote: > spi->irq was ignoring GpioInt property setting it to -1. > acpi_dev_gpio_irq_get returns and configure the slave irq according to > the acpi slave node description. > It is now inline with devicetree behavior. > > Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com> > --- > drivers/spi/spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index a5f53de..5c10815 100644 > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -1534,7 +1534,7 @@ static acpi_status acpi_spi_add_device(acpi_handle handle, u32 level, > } > > ACPI_COMPANION_SET(&spi->dev, adev); > - spi->irq = -1; > + spi->irq = acpi_dev_gpio_irq_get(ACPI_COMPANION(&spi->dev), 0); Also I think we should first check for the normal Interrupt() resource (like what we are already doing in acpi_spi_add_resource()) and only then resort back to use GPIO > > INIT_LIST_HEAD(&resource_list); > ret = acpi_dev_get_resources(adev, &resource_list, > -- > 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index a5f53de..5c10815 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1534,7 +1534,7 @@ static acpi_status acpi_spi_add_device(acpi_handle handle, u32 level, } ACPI_COMPANION_SET(&spi->dev, adev); - spi->irq = -1; + spi->irq = acpi_dev_gpio_irq_get(ACPI_COMPANION(&spi->dev), 0); INIT_LIST_HEAD(&resource_list); ret = acpi_dev_get_resources(adev, &resource_list,
spi->irq was ignoring GpioInt property setting it to -1. acpi_dev_gpio_irq_get returns and configure the slave irq according to the acpi slave node description. It is now inline with devicetree behavior. Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com> --- drivers/spi/spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)