diff mbox

[v7,09/33] package/efl/libefl: add webp dependency

Message ID 1449523775-6582-10-git-send-email-romain.naour@openwide.fr
State Superseded
Headers show

Commit Message

Romain Naour Dec. 7, 2015, 9:29 p.m. UTC
WebP is a new image format that provides lossless and lossy
compression for images on the web. So enabling webp support
in efl libraries allow to loads images using WebP.

Also, it one of the "highly recommended" dependecies [1]
according to the README but disabling it doesn't need
the --enable-i-really-know-what-i-am-doing... option.
That's why BR2_PACKAGE_LIBEFL_WEBP is not added to
BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG.

[1] https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n486

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v6: select BR2_PACKAGE_WEBP (Yann E.Morin)
v4: rename to libefl
    improve commit log
---
 package/efl/libefl/Config.in | 6 ++++++
 package/efl/libefl/libefl.mk | 9 +++++++--
 2 files changed, 13 insertions(+), 2 deletions(-)

Comments

Yann E. MORIN Dec. 7, 2015, 10:41 p.m. UTC | #1
Romain, All,

On 2015-12-07 22:29 +0100, Romain Naour spake thusly:
> WebP is a new image format that provides lossless and lossy
> compression for images on the web. So enabling webp support
> in efl libraries allow to loads images using WebP.
> 
> Also, it one of the "highly recommended" dependecies [1]
> according to the README but disabling it doesn't need
> the --enable-i-really-know-what-i-am-doing... option.
> That's why BR2_PACKAGE_LIBEFL_WEBP is not added to
> BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG.
> 
> [1] https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n486
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
> v6: select BR2_PACKAGE_WEBP (Yann E.Morin)
> v4: rename to libefl
>     improve commit log
> ---
>  package/efl/libefl/Config.in | 6 ++++++
>  package/efl/libefl/libefl.mk | 9 +++++++--
>  2 files changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
> index 3cf4b4e..0b89411 100644
> --- a/package/efl/libefl/Config.in
> +++ b/package/efl/libefl/Config.in
> @@ -112,4 +112,10 @@ config BR2_PACKAGE_LIBEFL_TIFF
>  	help
>  	  This enables the loader code that loads tiff files.
>  
> +config BR2_PACKAGE_LIBEFL_WEBP
> +	bool "libevas webp image loader"
> +	select BR2_PACKAGE_WEBP
> +	help
> +	  This enables the loader code that loads images using WebP.
> +
>  endif # BR2_PACKAGE_LIBEFL
> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
> index 10d0a98..e479cfc 100644
> --- a/package/efl/libefl/libefl.mk
> +++ b/package/efl/libefl/libefl.mk
> @@ -32,7 +32,6 @@ LIBEFL_GETTEXTIZE = YES
>  # --disable-cxx-bindings: disable C++11 bindings.
>  # --disable-fb: disable frame buffer support.
>  # --disable-image-loader-jp2k: disable JPEG 2000 support.
> -# --disable-image-loader-webp: disable webp support.
>  # --disable-sdl: disable sdl2 support.
>  # --disable-systemd: disable systemd support.
>  # --disable-xinput22: disable X11 XInput v2.2+ support.
> @@ -45,7 +44,6 @@ LIBEFL_CONF_OPTS = \
>  	--disable-cxx-bindings \
>  	--disable-fb \
>  	--disable-image-loader-jp2k \
> -	--disable-image-loader-webp \
>  	--disable-sdl \
>  	--disable-systemd \
>  	--enable-lua-old \
> @@ -177,6 +175,13 @@ else
>  LIBEFL_CONF_OPTS += --disable-image-loader-tiff
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBEFL_WEBP),y)
> +LIBEFL_CONF_OPTS += --enable-image-loader-webp=yes
> +LIBEFL_DEPENDENCIES += webp
> +else
> +LIBEFL_CONF_OPTS += --disable-image-loader-webp
> +endif
> +
>  $(eval $(autotools-package))
>  
>  ################################################################################
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox

Patch

diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
index 3cf4b4e..0b89411 100644
--- a/package/efl/libefl/Config.in
+++ b/package/efl/libefl/Config.in
@@ -112,4 +112,10 @@  config BR2_PACKAGE_LIBEFL_TIFF
 	help
 	  This enables the loader code that loads tiff files.
 
+config BR2_PACKAGE_LIBEFL_WEBP
+	bool "libevas webp image loader"
+	select BR2_PACKAGE_WEBP
+	help
+	  This enables the loader code that loads images using WebP.
+
 endif # BR2_PACKAGE_LIBEFL
diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
index 10d0a98..e479cfc 100644
--- a/package/efl/libefl/libefl.mk
+++ b/package/efl/libefl/libefl.mk
@@ -32,7 +32,6 @@  LIBEFL_GETTEXTIZE = YES
 # --disable-cxx-bindings: disable C++11 bindings.
 # --disable-fb: disable frame buffer support.
 # --disable-image-loader-jp2k: disable JPEG 2000 support.
-# --disable-image-loader-webp: disable webp support.
 # --disable-sdl: disable sdl2 support.
 # --disable-systemd: disable systemd support.
 # --disable-xinput22: disable X11 XInput v2.2+ support.
@@ -45,7 +44,6 @@  LIBEFL_CONF_OPTS = \
 	--disable-cxx-bindings \
 	--disable-fb \
 	--disable-image-loader-jp2k \
-	--disable-image-loader-webp \
 	--disable-sdl \
 	--disable-systemd \
 	--enable-lua-old \
@@ -177,6 +175,13 @@  else
 LIBEFL_CONF_OPTS += --disable-image-loader-tiff
 endif
 
+ifeq ($(BR2_PACKAGE_LIBEFL_WEBP),y)
+LIBEFL_CONF_OPTS += --enable-image-loader-webp=yes
+LIBEFL_DEPENDENCIES += webp
+else
+LIBEFL_CONF_OPTS += --disable-image-loader-webp
+endif
+
 $(eval $(autotools-package))
 
 ################################################################################