diff mbox

[v7,03/33] package/libevas-generic-loaders: svg loader: add MMU dependency

Message ID 1449523775-6582-4-git-send-email-romain.naour@openwide.fr
State Superseded
Headers show

Commit Message

Romain Naour Dec. 7, 2015, 9:29 p.m. UTC
Reported-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v6: new patch
---
 package/libevas-generic-loaders/Config.in | 2 ++
 1 file changed, 2 insertions(+)

Comments

Yann E. MORIN Dec. 7, 2015, 9:45 p.m. UTC | #1
Romain, All,

On 2015-12-07 22:29 +0100, Romain Naour spake thusly:
> Reported-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

I think a better title and log would have been:

    package/libevas-generic-loaders: add missing MMU dependency

    The MMU dependency from glib2 via librsvg was not propagated
    to the SVG loader.

    sob...

Anyway:

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
> v6: new patch
> ---
>  package/libevas-generic-loaders/Config.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/libevas-generic-loaders/Config.in b/package/libevas-generic-loaders/Config.in
> index c69f5e8..72d4adb 100644
> --- a/package/libevas-generic-loaders/Config.in
> +++ b/package/libevas-generic-loaders/Config.in
> @@ -16,6 +16,7 @@ config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_SVG
>  	bool "SVG loader"
>  	select BR2_PACKAGE_LIBRSVG
>  	select BR2_PACKAGE_CAIRO
> +	depends on BR2_USE_MMU # librsvg -> glib2
>  	depends on BR2_USE_WCHAR # librsvg -> glib2
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # librsvg -> glib2
>  	depends on BR2_INSTALL_LIBSTDCPP # librsvg -> pango
> @@ -25,6 +26,7 @@ config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_SVG
>  
>  comment "SVG loader needs a toolchain w/ wchar, threads, C++"
>  	depends on BR2_ARCH_HAS_ATOMICS
> +	depends on BR2_USE_MMU
>  	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
>  
>  endif
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox

Patch

diff --git a/package/libevas-generic-loaders/Config.in b/package/libevas-generic-loaders/Config.in
index c69f5e8..72d4adb 100644
--- a/package/libevas-generic-loaders/Config.in
+++ b/package/libevas-generic-loaders/Config.in
@@ -16,6 +16,7 @@  config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_SVG
 	bool "SVG loader"
 	select BR2_PACKAGE_LIBRSVG
 	select BR2_PACKAGE_CAIRO
+	depends on BR2_USE_MMU # librsvg -> glib2
 	depends on BR2_USE_WCHAR # librsvg -> glib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS # librsvg -> glib2
 	depends on BR2_INSTALL_LIBSTDCPP # librsvg -> pango
@@ -25,6 +26,7 @@  config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_SVG
 
 comment "SVG loader needs a toolchain w/ wchar, threads, C++"
 	depends on BR2_ARCH_HAS_ATOMICS
+	depends on BR2_USE_MMU
 	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
 
 endif