From patchwork Mon Dec 7 18:10:24 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 553504 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 340B514018C for ; Tue, 8 Dec 2015 05:11:24 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755539AbbLGSLW (ORCPT ); Mon, 7 Dec 2015 13:11:22 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:56299 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754942AbbLGSLW (ORCPT ); Mon, 7 Dec 2015 13:11:22 -0500 Received: from localhost.localdomain ([95.91.39.67]) by mrelayeu.kundenserver.de (mreue003) with ESMTPSA (Nemesis) id 0McAjL-1ZnVn02rdH-00JWkc; Mon, 07 Dec 2015 19:10:45 +0100 From: Stefan Wahren To: Linus Walleij , Stephen Warren , Lee Jones , Eric Anholt Cc: linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH RESEND] pinctrl: bcm2835: Fix initial value for direction_output Date: Mon, 7 Dec 2015 18:10:24 +0000 Message-Id: <1449511825-6156-1-git-send-email-stefan.wahren@i2se.com> X-Mailer: git-send-email 1.7.9.5 X-Provags-ID: V03:K0:nr05cAFl1DdlzCRFnC0wJaRmai6bEPFYLZJtmpVyCULt8uzEOUx n8sGxrwQwyDmpFKkTpUqbC3h4gM+y46VW4cyNXFJckZs4HsUBcTC3jeuZ0DPzSimdgs6kf+ +aa0U9crEWf/zsjGQ4o0uNNIOhGjixamRtShbjW+4FTvB0ZxFYn826sSprBS1blr7DFrv4H LIHoJ40l/RFPYUdvDgHZw== X-UI-Out-Filterresults: notjunk:1; V01:K0:k8f/ptCThhA=:+iv52dC2blO7Woy0+ixH+u jbpF4R3EWBqpBTz4RsdBGzyLOfLrriNHxd5n69LWuduJrC8Cz3Zi2yU1fcqahqazPmMHOANco t4Yt9Xconclohy1OAUmVWi5Pc3BI2L7Tn7wXSSP+Tbwfr+PQxZWS7e8ps95OkLgYCk2w52Gos wTAM/lOK1ZHSLbfK1Vf1DQsHa8uG4KAbjhJD9nL8Hj+mWGgIGWjRqm92GTzwVRygGUmLdyC2L A8HEJAPFHICA82SE+El99Nc/Ka2Oa2H6RHX6MYT/Z3I4R30ivGdvxbcl6dPw4QCv2Knx9D5hQ 96u1dntjo59BPQH1/zHGpgiM5zQQXPZTfwIlSDUz0Zu9jMuZz1BipWooIN4EgER9Xh1tno9XZ UWSdP9gsNjEhEroLh4VRqF2V4BJpf/OedBIFu9naogSKBe8aGxtHI2LxkNNSAIXSJ/D6Kkp0C 6lHsozGkIixorkVlHrlbydsJQIggd0pcwQKlYJea++2gmsPwybnQq2yOtHHZmSPj71nv72APL yiI2grdV0wsHu8yOnb50o1R66nq85R6DeswNbUteLyJPnJ4YxJsnFI/z2TweHvFUCA/Xxz6pK e/nnOVobuUUVDORjz7z1hMiUZgUQI4raA4wwc2rcKTOff5gVFMm2LnqaFFKyZgzt9M1kxcWL/ l7cchFuz7db3wRH6sdPqi+zP2zoaCmgVhJ5DcqdePvduxQpWiVy4vXF9Nj3tqeC6drgs= Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Currently the provided initial value for bcm2835_gpio_direction_output has no effect. So fix this issue by changing the value before changing the GPIO direction. As a result we need to move the function below bcm2835_gpio_set. Suggested-by: Martin Sperl Signed-off-by: Stefan Wahren Fixes: e1b2dc70cd5b ("pinctrl: add bcm2835 driver") Acked-by: Stephen Warren Acked-by: Eric Anholt --- This patch was inspired by this discussion [1]. [1] - http://lists.infradead.org/pipermail/linux-rpi-kernel/2015-April/001499.html Changes: - added suggested-by, fixes and acked-by tag since first submit drivers/pinctrl/bcm/pinctrl-bcm2835.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c index 8efa235..fd1441b 100644 --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c @@ -352,12 +352,6 @@ static int bcm2835_gpio_get(struct gpio_chip *chip, unsigned offset) return bcm2835_gpio_get_bit(pc, GPLEV0, offset); } -static int bcm2835_gpio_direction_output(struct gpio_chip *chip, - unsigned offset, int value) -{ - return pinctrl_gpio_direction_output(chip->base + offset); -} - static void bcm2835_gpio_set(struct gpio_chip *chip, unsigned offset, int value) { struct bcm2835_pinctrl *pc = dev_get_drvdata(chip->dev); @@ -365,6 +359,13 @@ static void bcm2835_gpio_set(struct gpio_chip *chip, unsigned offset, int value) bcm2835_gpio_set_bit(pc, value ? GPSET0 : GPCLR0, offset); } +static int bcm2835_gpio_direction_output(struct gpio_chip *chip, + unsigned offset, int value) +{ + bcm2835_gpio_set(chip, offset, value); + return pinctrl_gpio_direction_output(chip->base + offset); +} + static int bcm2835_gpio_to_irq(struct gpio_chip *chip, unsigned offset) { struct bcm2835_pinctrl *pc = dev_get_drvdata(chip->dev);