| Message ID | 5665AECD.8050106@foss.arm.com |
|---|---|
| State | New |
| Headers | show |
Hi Matthew, On 12/07/2015 05:07 PM, Matthew Wahab wrote: > Ping. Updated patch attached. > Matthew > > > On 26/11/15 16:01, Matthew Wahab wrote: >> Hello, >> >> This patch adds the feature macro __ARM_FEATURE_QRDMX to indicate the >> presence of the ARMv8.1 instructions vqrdmlah and vqrdmlsh. It is >> defined when the instructions are available, as it is when >> -march=armv8.1-a is enabled with suitable fpu options. >> >> Tested the series for arm-none-eabi with cross-compiled check-gcc on an >> ARMv8.1 emulator. Also tested arm-none-linux-gnueabihf with native >> bootstrap and make check. >> >> Ok for trunk? >> Matthew >> >> gcc/ >> 2015-11-26 Matthew Wahab <matthew.wahab@arm.com> >> >> * config/arm/arm-c.c (arm_cpu_builtins): Define __ARM_FEATURE_QRDMX. >> > + if (TARGET_NEON_RDMA) + builtin_define ("__ARM_FEATURE_QRDMX"); + Since it depends on TARGET_NEON, could you please use def_or_undef_macro (pfile, "__ARM_FEATURE_QRDMX", TARGET_NEON_RDMA); instead ? thanks Christian
On Tue, Dec 8, 2015 at 7:45 AM, Christian Bruel <christian.bruel@st.com> wrote: > Hi Matthew, > > > On 12/07/2015 05:07 PM, Matthew Wahab wrote: >> >> Ping. Updated patch attached. >> Matthew >> >> >> On 26/11/15 16:01, Matthew Wahab wrote: >>> >>> Hello, >>> >>> This patch adds the feature macro __ARM_FEATURE_QRDMX to indicate the >>> presence of the ARMv8.1 instructions vqrdmlah and vqrdmlsh. It is >>> defined when the instructions are available, as it is when >>> -march=armv8.1-a is enabled with suitable fpu options. >>> >>> Tested the series for arm-none-eabi with cross-compiled check-gcc on an >>> ARMv8.1 emulator. Also tested arm-none-linux-gnueabihf with native >>> bootstrap and make check. >>> >>> Ok for trunk? >>> Matthew >>> >>> gcc/ >>> 2015-11-26 Matthew Wahab <matthew.wahab@arm.com> >>> >>> * config/arm/arm-c.c (arm_cpu_builtins): Define >>> __ARM_FEATURE_QRDMX. >>> >> > > + if (TARGET_NEON_RDMA) > + builtin_define ("__ARM_FEATURE_QRDMX"); > + > > Since it depends on TARGET_NEON, could you please use > > def_or_undef_macro (pfile, "__ARM_FEATURE_QRDMX", TARGET_NEON_RDMA); > > instead ? I think that's what it should be - OK with that fixed. Ramana > > thanks > > Christian
From 721586aad45f7f75a0c198517602125c9d8f76f2 Mon Sep 17 00:00:00 2001 From: Matthew Wahab <matthew.wahab@arm.com> Date: Wed, 17 Jun 2015 13:25:09 +0100 Subject: [PATCH 4/7] [ARM] Add __ARM_FEATURE_QRDMX Change-Id: I26cde507e8844a731e4fd857fbd30bf87f213f89 --- gcc/config/arm/arm-c.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gcc/config/arm/arm-c.c b/gcc/config/arm/arm-c.c index 7dee28e..62c9304 100644 --- a/gcc/config/arm/arm-c.c +++ b/gcc/config/arm/arm-c.c @@ -68,6 +68,9 @@ arm_cpu_builtins (struct cpp_reader* pfile) def_or_undef_macro (pfile, "__ARM_FEATURE_UNALIGNED", unaligned_access); + if (TARGET_NEON_RDMA) + builtin_define ("__ARM_FEATURE_QRDMX"); + if (TARGET_CRC32) builtin_define ("__ARM_FEATURE_CRC32"); -- 2.1.4