diff mbox

ethernet: aurora: AURORA_NB8800 should depend on HAS_DMA

Message ID 1449479346-32601-1-git-send-email-geert@linux-m68k.org
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Geert Uytterhoeven Dec. 7, 2015, 9:09 a.m. UTC
If NO_DMA=y:

    ERROR: "dma_map_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
    ERROR: "dma_unmap_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
    ERROR: "dma_sync_single_for_cpu" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
    ERROR: "dma_unmap_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
    ERROR: "dma_alloc_coherent" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
    ERROR: "dma_mapping_error" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
    ERROR: "dma_map_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
    ERROR: "dma_free_coherent" [drivers/net/ethernet/aurora/nb8800.ko] undefined!

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/net/ethernet/aurora/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Måns Rullgård Dec. 7, 2015, 11:12 a.m. UTC | #1
Geert Uytterhoeven <geert@linux-m68k.org> writes:

> If NO_DMA=y:
>
>     ERROR: "dma_map_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_unmap_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_sync_single_for_cpu" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_unmap_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_alloc_coherent" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_mapping_error" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_map_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_free_coherent" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Acked-by: Mans Rullgard <mans@mansr.com>

>  drivers/net/ethernet/aurora/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/aurora/Kconfig b/drivers/net/ethernet/aurora/Kconfig
> index a3c7106fdf85e78f..8ba7f8ff3434000f 100644
> --- a/drivers/net/ethernet/aurora/Kconfig
> +++ b/drivers/net/ethernet/aurora/Kconfig
> @@ -13,6 +13,7 @@ if NET_VENDOR_AURORA
>
>  config AURORA_NB8800
>  	tristate "Aurora AU-NB8800 support"
> +	depends on HAS_DMA
>  	select PHYLIB
>  	help
>  	 Support for the AU-NB8800 gigabit Ethernet controller.
> -- 
> 1.9.1
>
David Miller Dec. 7, 2015, 6:55 p.m. UTC | #2
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Mon,  7 Dec 2015 10:09:06 +0100

> If NO_DMA=y:
> 
>     ERROR: "dma_map_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_unmap_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_sync_single_for_cpu" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_unmap_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_alloc_coherent" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_mapping_error" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_map_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_free_coherent" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied, thanks Geert.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/ethernet/aurora/Kconfig b/drivers/net/ethernet/aurora/Kconfig
index a3c7106fdf85e78f..8ba7f8ff3434000f 100644
--- a/drivers/net/ethernet/aurora/Kconfig
+++ b/drivers/net/ethernet/aurora/Kconfig
@@ -13,6 +13,7 @@  if NET_VENDOR_AURORA
 
 config AURORA_NB8800
 	tristate "Aurora AU-NB8800 support"
+	depends on HAS_DMA
 	select PHYLIB
 	help
 	 Support for the AU-NB8800 gigabit Ethernet controller.