Patchwork [trans-mem] libitm: bad comparison in clone_entry_compare

login
register
mail settings
Submitter Patrick Marlier
Date June 11, 2010, 10:46 a.m.
Message ID <4C121401.1050102@unine.ch>
Download mbox | patch
Permalink /patch/55308/
State New
Headers show

Comments

Patrick Marlier - June 11, 2010, 10:46 a.m.
Hello Richard,

Just a small mistake in clone.cc. The comparison must be "greater than".
This was making troubles to find clone functions since the table is not 
well sorted.

Thank you.
Have a nice day,

Patrick Marlier.
Richard Henderson - June 11, 2010, 2:08 p.m.
On 06/11/2010 03:46 AM, Patrick Marlier wrote:
> Hello Richard,
> 
> Just a small mistake in clone.cc. The comparison must be "greater than".
> This was making troubles to find clone functions since the table is not
> well sorted.
> 
> Thank you.
> Have a nice day,
> 
> Patrick Marlier.
> 
> Index: clone.cc
> ===================================================================
> --- clone.cc    (revision 160599)
> +++ clone.cc    (working copy)
> @@ -113,7 +113,7 @@
> 
>    if (aa->orig < bb->orig)
>      return -1;
> -  else if (aa->orig < bb->orig)
> +  else if (aa->orig > bb->orig)

Good grief.  Applied, thanks.


r~

Patch

Index: clone.cc
===================================================================
--- clone.cc    (revision 160599)
+++ clone.cc    (working copy)
@@ -113,7 +113,7 @@ 

    if (aa->orig < bb->orig)
      return -1;
-  else if (aa->orig < bb->orig)
+  else if (aa->orig > bb->orig)
      return 1;
    else
      return 0;