| Message ID | 1449251148-19344-4-git-send-email-eric@anholt.net |
|---|---|
| State | New |
| Headers | show |
Eric Anholt <eric@anholt.net> writes: > From: Alexander Aring <alex.aring@gmail.com> > > This patch adds support for several power domains on Raspberry Pi, > including USB (so it can be enabled even if the bootloader didn't do > it), and graphics. > > This patch is the combined work of Eric Anholt (who wrote USB support > inside of the Raspberry Pi firmware driver, and wrote the non-USB > domain support) and Alexander Aring (who separated the original USB > work out from the firmware driver). > > Signed-off-by: Alexander Aring <alex.aring@gmail.com> > Signed-off-by: Eric Anholt <eric@anholt.net> > --- > > v2: Add support for power domains other than USB, using the new > firmware interface, reword commit message (changes by Eric) [...] > +/* > + * Firmware indices for the old power domains interface. Only a few > + * of them were actually implemented. > + */ > +#define RPI_OLD_POWER_DOMAIN_USB 3 > +#define RPI_OLD_POWER_DOMAIN_V3D 10 > + Is "old" the right word here? Are there firmware versions that could be used instead? What happens when the firwmware is updated next time? [...] > + /* > + * Use the old firmware interface for USB power, so that we > + * can turn it on even if the firmware hasn't been updated. > + */ > + rpi_init_old_power_domain(rpi_domains, RPI_POWER_DOMAIN_USB, > + RPI_OLD_POWER_DOMAIN_USB, "USB"); This seems a bit restrictive. To me, it seems that determining "old" or "new" (or revision of fw interface to use) should be described in DT, not hard-coded in the power domain driver. What about an additional DT property to describe that? or possibly another cell in the domain which could be used to optionally set old/legacy. Kevin
Kevin Hilman <khilman@kernel.org> writes: > Eric Anholt <eric@anholt.net> writes: > >> From: Alexander Aring <alex.aring@gmail.com> >> >> This patch adds support for several power domains on Raspberry Pi, >> including USB (so it can be enabled even if the bootloader didn't do >> it), and graphics. >> >> This patch is the combined work of Eric Anholt (who wrote USB support >> inside of the Raspberry Pi firmware driver, and wrote the non-USB >> domain support) and Alexander Aring (who separated the original USB >> work out from the firmware driver). >> >> Signed-off-by: Alexander Aring <alex.aring@gmail.com> >> Signed-off-by: Eric Anholt <eric@anholt.net> >> --- >> >> v2: Add support for power domains other than USB, using the new >> firmware interface, reword commit message (changes by Eric) > > [...] > >> +/* >> + * Firmware indices for the old power domains interface. Only a few >> + * of them were actually implemented. >> + */ >> +#define RPI_OLD_POWER_DOMAIN_USB 3 >> +#define RPI_OLD_POWER_DOMAIN_V3D 10 >> + > > Is "old" the right word here? Are there firmware versions that could be > used instead? What happens when the firwmware is updated next time? Old is a good word. It's the old interface. As for what happens when the firmware is updated: Nothing. The firmware is updated all the time, and it maintains backwards compatibility. Unless you mean "what happens when a newer, fancier power domain interface is created and we need a name for the newer one" and the answer is "this is a define entirely within the driver, and we can just rename it when we want to." > [...] > >> + /* >> + * Use the old firmware interface for USB power, so that we >> + * can turn it on even if the firmware hasn't been updated. >> + */ >> + rpi_init_old_power_domain(rpi_domains, RPI_POWER_DOMAIN_USB, >> + RPI_OLD_POWER_DOMAIN_USB, "USB"); > > This seems a bit restrictive. > > To me, it seems that determining "old" or "new" (or revision of fw > interface to use) should be described in DT, not hard-coded in the power > domain driver. > > What about an additional DT property to describe that? or possibly > another cell in the domain which could be used to optionally set > old/legacy. As the author and maintainer of the code, I don't feel it's restrictive. The firmware protocol is defined and is guaranteed to continue to exist, it's only useful for this platform, and defining a new set of custom devicetree properties for it would only obfuscate the implementation. DT is a useful tool for separating out the between-board differences for the same piece of hardware across multiple implementations at different addresses, while this is neither hardware nor in multiple implementations at different addresses.
Hi Eric, Eric Anholt <eric@anholt.net> writes: > Kevin Hilman <khilman@kernel.org> writes: > >> Eric Anholt <eric@anholt.net> writes: >> >>> From: Alexander Aring <alex.aring@gmail.com> >>> >>> This patch adds support for several power domains on Raspberry Pi, >>> including USB (so it can be enabled even if the bootloader didn't do >>> it), and graphics. >>> >>> This patch is the combined work of Eric Anholt (who wrote USB support >>> inside of the Raspberry Pi firmware driver, and wrote the non-USB >>> domain support) and Alexander Aring (who separated the original USB >>> work out from the firmware driver). >>> >>> Signed-off-by: Alexander Aring <alex.aring@gmail.com> >>> Signed-off-by: Eric Anholt <eric@anholt.net> >>> --- >>> >>> v2: Add support for power domains other than USB, using the new >>> firmware interface, reword commit message (changes by Eric) >> >> [...] >> >>> +/* >>> + * Firmware indices for the old power domains interface. Only a few >>> + * of them were actually implemented. >>> + */ >>> +#define RPI_OLD_POWER_DOMAIN_USB 3 >>> +#define RPI_OLD_POWER_DOMAIN_V3D 10 >>> + >> >> Is "old" the right word here? Are there firmware versions that could be >> used instead? What happens when the firwmware is updated next time? > > Old is a good word. It's the old interface. Sure, but "old" is relative and based on experience, folks come to regret those kinds of names. > As for what happens when the firmware is updated: Nothing. The firmware > is updated all the time, and it maintains backwards compatibility. > Unless you mean "what happens when a newer, fancier power domain > interface is created and we need a name for the newer one" and the > answer is "this is a define entirely within the driver, and we can just > rename it when we want to." Sure, it's very contained in this driver, so it's ultimately up to you. It's not something worth blocking this about, I just wanted to be sure since I'm not very familiar with how the rpi firmware evolves. >> [...] >> >>> + /* >>> + * Use the old firmware interface for USB power, so that we >>> + * can turn it on even if the firmware hasn't been updated. >>> + */ >>> + rpi_init_old_power_domain(rpi_domains, RPI_POWER_DOMAIN_USB, >>> + RPI_OLD_POWER_DOMAIN_USB, "USB"); >> >> This seems a bit restrictive. >> >> To me, it seems that determining "old" or "new" (or revision of fw >> interface to use) should be described in DT, not hard-coded in the power >> domain driver. >> >> What about an additional DT property to describe that? or possibly >> another cell in the domain which could be used to optionally set >> old/legacy. > > As the author and maintainer of the code, I don't feel it's restrictive. > The firmware protocol is defined and is guaranteed to continue to exist, > it's only useful for this platform, and defining a new set of custom > devicetree properties for it would only obfuscate the implementation. > DT is a useful tool for separating out the between-board differences for > the same piece of hardware across multiple implementations at different > addresses, while this is neither hardware nor in multiple > implementations at different addresses. That being said, firmware revisions are also very often something that qualifies as a difference between boards. Anyways, as I said above, I think this is a potential future problem, but it's not a big deal to me since it's very self contained. Kevin
Hi Eric, Am 04.12.2015 um 18:45 schrieb Eric Anholt: > From: Alexander Aring <alex.aring@gmail.com> > > This patch adds support for several power domains on Raspberry Pi, > including USB (so it can be enabled even if the bootloader didn't do > it), and graphics. > > This patch is the combined work of Eric Anholt (who wrote USB support > inside of the Raspberry Pi firmware driver, and wrote the non-USB > domain support) and Alexander Aring (who separated the original USB > work out from the firmware driver). > > Signed-off-by: Alexander Aring <alex.aring@gmail.com> > Signed-off-by: Eric Anholt <eric@anholt.net> > --- > > v2: Add support for power domains other than USB, using the new > firmware interface, reword commit message (changes by Eric) > > arch/arm/mach-bcm/Kconfig | 10 ++ > arch/arm/mach-bcm/Makefile | 1 + > arch/arm/mach-bcm/raspberrypi-power.c | 269 ++++++++++++++++++++++++++++ > include/dt-bindings/arm/raspberrypi-power.h | 41 +++++ > 4 files changed, 321 insertions(+) > create mode 100644 arch/arm/mach-bcm/raspberrypi-power.c > create mode 100644 include/dt-bindings/arm/raspberrypi-power.h > > diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig > index 8c53c55..0f23bad 100644 > --- a/arch/arm/mach-bcm/Kconfig > +++ b/arch/arm/mach-bcm/Kconfig > @@ -134,6 +134,16 @@ config ARCH_BCM2835 > This enables support for the Broadcom BCM2835 SoC. This SoC is > used in the Raspberry Pi and Roku 2 devices. > > +config RASPBERRYPI_POWER > + bool "Raspberry Pi power domain driver" > + depends on ARCH_BCM2835 || COMPILE_TEST > + depends on RASPBERRYPI_FIRMWARE > + select PM_GENERIC_DOMAINS if PM > + select PM_GENERIC_DOMAINS_OF if PM > + help > + This enables support for the RPi power domains which can be enabled > + or disabled via the RPi firmware. > + > config ARCH_BCM_63XX > bool "Broadcom BCM63xx DSL SoC" if ARCH_MULTI_V7 > depends on MMU > diff --git a/arch/arm/mach-bcm/Makefile b/arch/arm/mach-bcm/Makefile > index 892261f..fec2d6b 100644 > --- a/arch/arm/mach-bcm/Makefile > +++ b/arch/arm/mach-bcm/Makefile > @@ -36,6 +36,7 @@ endif > > # BCM2835 > obj-$(CONFIG_ARCH_BCM2835) += board_bcm2835.o > +obj-$(CONFIG_RASPBERRYPI_POWER) += raspberrypi-power.o > > # BCM5301X > obj-$(CONFIG_ARCH_BCM_5301X) += bcm_5301x.o > diff --git a/arch/arm/mach-bcm/raspberrypi-power.c b/arch/arm/mach-bcm/raspberrypi-power.c > new file mode 100644 > index 0000000..3444301 > --- /dev/null > +++ b/arch/arm/mach-bcm/raspberrypi-power.c > @@ -0,0 +1,269 @@ > +/* > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * Authors: > + * (C) 2015 Pengutronix, Alexander Aring <aar@pengutronix.de> > + * Eric Anholt <eric@anholt.net> shouldn't be the copyright before license? > + */ > + [...] > + > +static int rpi_power_probe(struct platform_device *pdev) > +{ > + struct device_node *fw_np; > + struct device *dev = &pdev->dev; > + struct rpi_power_domains *rpi_domains; > + int ret, i; > + > + rpi_domains = devm_kzalloc(dev, sizeof(*rpi_domains), GFP_KERNEL); > + if (!rpi_domains) > + return -ENOMEM; > + > + rpi_domains->xlate.domains = > + devm_kzalloc(dev, sizeof(*rpi_domains->xlate.domains) * > + RPI_POWER_DOMAIN_COUNT, GFP_KERNEL); > + if (!rpi_domains->xlate.domains) > + return -ENOMEM; > + > + rpi_domains->xlate.num_domains = RPI_POWER_DOMAIN_COUNT; > + > + fw_np = of_parse_phandle(pdev->dev.of_node, "firmware", 0); > + if (!fw_np) { > + dev_err(&pdev->dev, "no firmware node\n"); > + return -ENODEV; > + } > + > + rpi_domains->fw = rpi_firmware_get(fw_np); > + of_node_put(fw_np); > + if (!rpi_domains->fw) > + return -EPROBE_DEFER; > + > + rpi_domains->has_new_interface = > + rpi_has_new_domain_support(rpi_domains); > + > + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_I2C0, "I2C0"); > + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_I2C1, "I2C1"); > + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_I2C2, "I2C2"); > + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_VIDEO_SCALER, > + "VIDEO_SCALER"); > + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_VPU1, "VPU1"); > + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_HDMI, "HDMI"); > + > + /* > + * Use the old firmware interface for USB power, so that we > + * can turn it on even if the firmware hasn't been updated. > + */ > + rpi_init_old_power_domain(rpi_domains, RPI_POWER_DOMAIN_USB, > + RPI_OLD_POWER_DOMAIN_USB, "USB"); > + > + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_VEC, "VEC"); > + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_JPEG, "JPEG"); > + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_H264, "H264"); > + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_V3D, "V3D"); After this line i would expect the following: rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_ISP, "ISP"); > + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_UNICAM0, "UNICAM0"); > + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_UNICAM1, "UNICAM1"); > + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_CCP2RX, "CCP2RX"); > + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_CSI2, "CSI2"); > + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_CPI, "CPI"); > + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_DSI0, "DSI0"); > + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_DSI1, "DSI1"); > + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_TRANSPOSER, > + "TRANPOSER"); s/TRANPOSER/TRANSPOSER ? > + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_CCP2TX, "CCP2TX"); > + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_CDP, "CDP"); > + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_ARM, "ARM"); > + > + ret = of_genpd_add_provider_onecell(dev->of_node, &rpi_domains->xlate); > + if (ret < 0) > + goto exit_pm; > + > + platform_set_drvdata(pdev, rpi_domains); > + > + return 0; > + > +exit_pm: > + for (i = 0; i < rpi_domains->xlate.num_domains; i++) > + pm_genpd_exit(rpi_domains->xlate.domains[i]); > + > + return ret; > +} > + Best regards Stefan
diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig index 8c53c55..0f23bad 100644 --- a/arch/arm/mach-bcm/Kconfig +++ b/arch/arm/mach-bcm/Kconfig @@ -134,6 +134,16 @@ config ARCH_BCM2835 This enables support for the Broadcom BCM2835 SoC. This SoC is used in the Raspberry Pi and Roku 2 devices. +config RASPBERRYPI_POWER + bool "Raspberry Pi power domain driver" + depends on ARCH_BCM2835 || COMPILE_TEST + depends on RASPBERRYPI_FIRMWARE + select PM_GENERIC_DOMAINS if PM + select PM_GENERIC_DOMAINS_OF if PM + help + This enables support for the RPi power domains which can be enabled + or disabled via the RPi firmware. + config ARCH_BCM_63XX bool "Broadcom BCM63xx DSL SoC" if ARCH_MULTI_V7 depends on MMU diff --git a/arch/arm/mach-bcm/Makefile b/arch/arm/mach-bcm/Makefile index 892261f..fec2d6b 100644 --- a/arch/arm/mach-bcm/Makefile +++ b/arch/arm/mach-bcm/Makefile @@ -36,6 +36,7 @@ endif # BCM2835 obj-$(CONFIG_ARCH_BCM2835) += board_bcm2835.o +obj-$(CONFIG_RASPBERRYPI_POWER) += raspberrypi-power.o # BCM5301X obj-$(CONFIG_ARCH_BCM_5301X) += bcm_5301x.o diff --git a/arch/arm/mach-bcm/raspberrypi-power.c b/arch/arm/mach-bcm/raspberrypi-power.c new file mode 100644 index 0000000..3444301 --- /dev/null +++ b/arch/arm/mach-bcm/raspberrypi-power.c @@ -0,0 +1,269 @@ +/* + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + * Authors: + * (C) 2015 Pengutronix, Alexander Aring <aar@pengutronix.de> + * Eric Anholt <eric@anholt.net> + */ + +#include <linux/module.h> +#include <linux/of_platform.h> +#include <linux/platform_device.h> +#include <linux/pm_domain.h> +#include <dt-bindings/arm/raspberrypi-power.h> +#include <soc/bcm2835/raspberrypi-firmware.h> + +/* + * Firmware indices for the old power domains interface. Only a few + * of them were actually implemented. + */ +#define RPI_OLD_POWER_DOMAIN_USB 3 +#define RPI_OLD_POWER_DOMAIN_V3D 10 + +struct rpi_power_domain { + u32 domain; + bool enabled; + bool old_interface; + struct generic_pm_domain base; + struct rpi_firmware *fw; +}; + +struct rpi_power_domains { + bool has_new_interface; + struct genpd_onecell_data xlate; + struct rpi_firmware *fw; + struct rpi_power_domain domains[RPI_POWER_DOMAIN_COUNT]; +}; + +/* + * Packet definition used by RPI_FIRMWARE_SET_POWER_STATE and + * RPI_FIRMWARE_SET_DOMAIN_STATE + */ +struct rpi_power_domain_packet { + u32 domain; + u32 on; +} __packet; + +/* + * Asks the firmware to enable or disable power on a specific power + * domain. + */ +static int rpi_firmware_set_power(struct rpi_power_domain *rpi_domain, bool on) +{ + struct rpi_power_domain_packet packet; + + packet.domain = rpi_domain->domain; + packet.on = on; + return rpi_firmware_property(rpi_domain->fw, + rpi_domain->old_interface ? + RPI_FIRMWARE_SET_POWER_STATE : + RPI_FIRMWARE_SET_DOMAIN_STATE, + &packet, sizeof(packet)); +} + +static int rpi_domain_off(struct generic_pm_domain *domain) +{ + struct rpi_power_domain *rpi_domain = + container_of(domain, struct rpi_power_domain, base); + + return rpi_firmware_set_power(rpi_domain, false); +} + +static int rpi_domain_on(struct generic_pm_domain *domain) +{ + struct rpi_power_domain *rpi_domain = + container_of(domain, struct rpi_power_domain, base); + + return rpi_firmware_set_power(rpi_domain, true); +} + +static void rpi_common_init_power_domain(struct rpi_power_domains *rpi_domains, + int xlate_index, const char *name) +{ + struct rpi_power_domain *dom = &rpi_domains->domains[xlate_index]; + + dom->fw = rpi_domains->fw; + + dom->base.name = name; + dom->base.power_on = rpi_domain_on; + dom->base.power_off = rpi_domain_off; + + /* + * Treat all power domains as off at boot. + * + * The firmware itself may be keeping some domains on, but + * from Linux's perspective all we control is the refcounts + * that we give to the firmware, and we can't ask the firmware + * to turn off something that we haven't ourselves turned on. + */ + pm_genpd_init(&dom->base, NULL, true); + + rpi_domains->xlate.domains[xlate_index] = &dom->base; +} + +static void rpi_init_power_domain(struct rpi_power_domains *rpi_domains, + int xlate_index, const char *name) +{ + struct rpi_power_domain *dom = &rpi_domains->domains[xlate_index]; + + if (!rpi_domains->has_new_interface) + return; + + /* The DT binding index is the firmware's domain index minus one. */ + dom->domain = xlate_index + 1; + + rpi_common_init_power_domain(rpi_domains, xlate_index, name); +} + +static void rpi_init_old_power_domain(struct rpi_power_domains *rpi_domains, + int xlate_index, int domain, + const char *name) +{ + struct rpi_power_domain *dom = &rpi_domains->domains[xlate_index]; + + dom->old_interface = true; + dom->domain = domain; + + rpi_common_init_power_domain(rpi_domains, xlate_index, name); +} + +/* + * Detects whether the firmware supports the new power domains interface. + * + * The firmware doesn't actually return an error on an unknown tag, + * and just skips over it, so we do the detection by putting an + * unexpected value in the return field and checking if it was + * unchanged. + */ +static bool +rpi_has_new_domain_support(struct rpi_power_domains *rpi_domains) +{ + struct rpi_power_domain_packet packet; + int ret; + + packet.domain = RPI_POWER_DOMAIN_ARM; + packet.on = ~0; + + ret = rpi_firmware_property(rpi_domains->fw, + RPI_FIRMWARE_GET_DOMAIN_STATE, + &packet, sizeof(packet)); + + return ret == 0 && packet.on != ~0; +} + +static int rpi_power_probe(struct platform_device *pdev) +{ + struct device_node *fw_np; + struct device *dev = &pdev->dev; + struct rpi_power_domains *rpi_domains; + int ret, i; + + rpi_domains = devm_kzalloc(dev, sizeof(*rpi_domains), GFP_KERNEL); + if (!rpi_domains) + return -ENOMEM; + + rpi_domains->xlate.domains = + devm_kzalloc(dev, sizeof(*rpi_domains->xlate.domains) * + RPI_POWER_DOMAIN_COUNT, GFP_KERNEL); + if (!rpi_domains->xlate.domains) + return -ENOMEM; + + rpi_domains->xlate.num_domains = RPI_POWER_DOMAIN_COUNT; + + fw_np = of_parse_phandle(pdev->dev.of_node, "firmware", 0); + if (!fw_np) { + dev_err(&pdev->dev, "no firmware node\n"); + return -ENODEV; + } + + rpi_domains->fw = rpi_firmware_get(fw_np); + of_node_put(fw_np); + if (!rpi_domains->fw) + return -EPROBE_DEFER; + + rpi_domains->has_new_interface = + rpi_has_new_domain_support(rpi_domains); + + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_I2C0, "I2C0"); + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_I2C1, "I2C1"); + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_I2C2, "I2C2"); + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_VIDEO_SCALER, + "VIDEO_SCALER"); + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_VPU1, "VPU1"); + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_HDMI, "HDMI"); + + /* + * Use the old firmware interface for USB power, so that we + * can turn it on even if the firmware hasn't been updated. + */ + rpi_init_old_power_domain(rpi_domains, RPI_POWER_DOMAIN_USB, + RPI_OLD_POWER_DOMAIN_USB, "USB"); + + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_VEC, "VEC"); + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_JPEG, "JPEG"); + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_H264, "H264"); + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_V3D, "V3D"); + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_UNICAM0, "UNICAM0"); + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_UNICAM1, "UNICAM1"); + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_CCP2RX, "CCP2RX"); + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_CSI2, "CSI2"); + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_CPI, "CPI"); + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_DSI0, "DSI0"); + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_DSI1, "DSI1"); + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_TRANSPOSER, + "TRANPOSER"); + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_CCP2TX, "CCP2TX"); + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_CDP, "CDP"); + rpi_init_power_domain(rpi_domains, RPI_POWER_DOMAIN_ARM, "ARM"); + + ret = of_genpd_add_provider_onecell(dev->of_node, &rpi_domains->xlate); + if (ret < 0) + goto exit_pm; + + platform_set_drvdata(pdev, rpi_domains); + + return 0; + +exit_pm: + for (i = 0; i < rpi_domains->xlate.num_domains; i++) + pm_genpd_exit(rpi_domains->xlate.domains[i]); + + return ret; +} + +static int rpi_power_remove(struct platform_device *pdev) +{ + struct rpi_power_domains *rpi_domains = platform_get_drvdata(pdev); + struct device *dev = &pdev->dev; + int i; + + for (i = 0; i < rpi_domains->xlate.num_domains; i++) + pm_genpd_exit(rpi_domains->xlate.domains[i]); + + of_genpd_del_provider(dev->of_node); + + return 0; +} + +static const struct of_device_id rpi_power_of_match[] = { + { .compatible = "raspberrypi,bcm2835-power", }, + {}, +}; +MODULE_DEVICE_TABLE(of, rpi_power_of_match); + +static struct platform_driver rpi_power_driver = { + .driver = { + .name = "raspberrypi-power", + .of_match_table = rpi_power_of_match, + }, + .probe = rpi_power_probe, + .remove = rpi_power_remove, +}; +module_platform_driver(rpi_power_driver); + +MODULE_AUTHOR("Alexander Aring <aar@pengutronix.de>"); +MODULE_AUTHOR("Eric Anholt <eric@anholt.net>"); +MODULE_DESCRIPTION("Raspberry Pi power domain driver"); +MODULE_LICENSE("GPL v2"); diff --git a/include/dt-bindings/arm/raspberrypi-power.h b/include/dt-bindings/arm/raspberrypi-power.h new file mode 100644 index 0000000..b3ff8e0 --- /dev/null +++ b/include/dt-bindings/arm/raspberrypi-power.h @@ -0,0 +1,41 @@ +/* + * Copyright © 2015 Broadcom + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#ifndef _DT_BINDINGS_ARM_BCM2835_RPI_POWER_H +#define _DT_BINDINGS_ARM_BCM2835_RPI_POWER_H + +/* These power domain indices are the firmware interface's indices + * minus one. + */ +#define RPI_POWER_DOMAIN_I2C0 0 +#define RPI_POWER_DOMAIN_I2C1 1 +#define RPI_POWER_DOMAIN_I2C2 2 +#define RPI_POWER_DOMAIN_VIDEO_SCALER 3 +#define RPI_POWER_DOMAIN_VPU1 4 +#define RPI_POWER_DOMAIN_HDMI 5 +#define RPI_POWER_DOMAIN_USB 6 +#define RPI_POWER_DOMAIN_VEC 7 +#define RPI_POWER_DOMAIN_JPEG 8 +#define RPI_POWER_DOMAIN_H264 9 +#define RPI_POWER_DOMAIN_V3D 10 +#define RPI_POWER_DOMAIN_ISP 11 +#define RPI_POWER_DOMAIN_UNICAM0 12 +#define RPI_POWER_DOMAIN_UNICAM1 13 +#define RPI_POWER_DOMAIN_CCP2RX 14 +#define RPI_POWER_DOMAIN_CSI2 15 +#define RPI_POWER_DOMAIN_CPI 16 +#define RPI_POWER_DOMAIN_DSI0 17 +#define RPI_POWER_DOMAIN_DSI1 18 +#define RPI_POWER_DOMAIN_TRANSPOSER 19 +#define RPI_POWER_DOMAIN_CCP2TX 20 +#define RPI_POWER_DOMAIN_CDP 21 +#define RPI_POWER_DOMAIN_ARM 22 + +#define RPI_POWER_DOMAIN_COUNT 23 + +#endif /* _DT_BINDINGS_ARM_BCM2835_RPI_POWER_H */