Patchwork Ping^2: .md enums & unspec names in dumps

login
register
mail settings
Submitter Richard Sandiford
Date June 10, 2010, 8:32 p.m.
Message ID <87sk4uzl0u.fsf@firetop.home>
Download mbox | patch
Permalink /patch/55249/
State New
Headers show

Comments

Richard Sandiford - June 10, 2010, 8:32 p.m.
Mark Mitchell <mark@codesourcery.com> writes:
> Richard Sandiford wrote:
>> A second ping for this patch series:
>> 
>>     http://gcc.gnu.org/ml/gcc-patches/2010-05/msg01168.html
>> 
>> with the follow-ups:
>> 
>>     http://gcc.gnu.org/ml/gcc-patches/2010-05/msg02352.html
>>     http://gcc.gnu.org/ml/gcc-patches/2010-05/msg02353.html
>> 
>> Tested (with the follow-ups) on x86_64-linux-gnu and mipsisa64-elf.
>
> OK.

Thanks a lot for the review!

When I updated, I found I needed one further patch to cope with
changes since the ping.  lto-wrapper.c included defaults.h in order
to get the definition of the obstack_* macros.  Now that I've moved
them to coretypes.h, it has to include that instead.

I think this is an improvement.  defaults.h is really a target header
that should be included through tm.h; nothing is really supposed to
include it directly like that.

Tested on x86_64-linux-gnu and mipsisa64-elf.  Applied as obvious.

Richard

	* Makefile.in ...
	(lto-wrapper.o): Depend on coretypes.h instead of defaults.h.
	...
	* lto-wrapper.c: Include coretypes.h instead of defaults.h.

Patch

Index: gcc/Makefile.in
===================================================================
--- gcc/Makefile.in	2010-06-08 21:00:52.000000000 +0100
+++ gcc/Makefile.in	2010-06-08 21:07:10.000000000 +0100
@@ -2059,7 +2061,7 @@  lto-wrapper$(exeext): lto-wrapper.o intl
 	$(COMPILER) $(ALL_COMPILERFLAGS) $(LDFLAGS) -o T$@ lto-wrapper.o intl.o $(LIBS)
 	mv -f T$@ $@
 
-lto-wrapper.o: lto-wrapper.c $(CONFIG_H) $(SYSTEM_H) defaults.h intl.h \
+lto-wrapper.o: lto-wrapper.c $(CONFIG_H) $(SYSTEM_H) coretypes.h intl.h \
 	$(OBSTACK_H)
 
 # Files used by all variants of C.
Index: gcc/lto-wrapper.c
===================================================================
--- gcc/lto-wrapper.c	2010-06-08 21:07:25.000000000 +0100
+++ gcc/lto-wrapper.c	2010-06-08 21:07:32.000000000 +0100
@@ -39,12 +39,12 @@  Software Foundation; either version 3, o
 
 #include "config.h"
 #include "system.h"
+#include "coretypes.h"
 #include <errno.h>
 #include <signal.h>
 #if ! defined( SIGCHLD ) && defined( SIGCLD )
 #  define SIGCHLD SIGCLD
 #endif
-#include "defaults.h"
 #include "intl.h"
 #include "libiberty.h"
 #include "obstack.h"