Patchwork [RFC,v2,1/3] Export tdb_hash()

login
register
mail settings
Submitter Prerna Saxena
Date June 10, 2010, 7:15 p.m.
Message ID <20100611004558.7d87f0e5@zephyr>
Download mbox | patch
Permalink /patch/55245/
State New
Headers show

Comments

Prerna Saxena - June 10, 2010, 7:15 p.m.
For now, I simply export tdb_hash() from qdict.h for use by tracing 
framework.
Luiz suggested renaming and exporting it from a location other than 
qdict.h . Would "qemu-common.h" be a better place?


Signed-off-by: Prerna Saxena <prerna@linux.vnet.ibm.com>
---
 qdict.c |    2 +-
 qdict.h |    2 ++
 2 files changed, 3 insertions(+), 1 deletions(-)
Luiz Capitulino - June 11, 2010, 5:54 p.m.
On Fri, 11 Jun 2010 00:45:58 +0530
Prerna Saxena <prerna@linux.vnet.ibm.com> wrote:

> For now, I simply export tdb_hash() from qdict.h for use by tracing 
> framework.
> Luiz suggested renaming and exporting it from a location other than 
> qdict.h . Would "qemu-common.h" be a better place?

 qemu-common.h seems to be about header files, I thought we had a qemu-misc.c
file already. I'd create it if we don't.

Patch

diff --git a/qdict.c b/qdict.c
index 175bc17..5261872 100644
--- a/qdict.c
+++ b/qdict.c
@@ -56,7 +56,7 @@  QDict *qobject_to_qdict(const QObject *obj)
  * tdb_hash(): based on the hash agorithm from gdbm, via tdb
  * (from module-init-tools)
  */
-static unsigned int tdb_hash(const char *name)
+unsigned int tdb_hash(const char *name)
 {
     unsigned value;	/* Used to compute the hash value.  */
     unsigned   i;	/* Used to cycle through random values. */
diff --git a/qdict.h b/qdict.h
index 5e5902c..d221c18 100644
--- a/qdict.h
+++ b/qdict.h
@@ -59,4 +59,6 @@  int64_t qdict_get_try_int(const QDict *qdict, const char *key,
                           int64_t err_value);
 const char *qdict_get_try_str(const QDict *qdict, const char *key);
 
+/* Export tdb_hash() for use by trace framework */
+unsigned int tdb_hash(const char *name);
 #endif /* QDICT_H */