diff mbox

[yuanhan.liu@linux.intel.com:,[PATCH,2/2] vhost: don't send RESET_OWNER at stop]

Message ID 20151202155426-mutt-send-email-mst@redhat.com
State New
Headers show

Commit Message

Michael S. Tsirkin Dec. 2, 2015, 1:54 p.m. UTC 
Cc qemu-stable@nongnu.org as this fixes some clients.

----- Forwarded message from Yuanhan Liu <yuanhan.liu@linux.intel.com> -----

Date: Fri, 13 Nov 2015 15:24:10 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com, Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: [PATCH 2/2] vhost: don't send RESET_OWNER at stop
Message-Id: <1447399450-29489-2-git-send-email-yuanhan.liu@linux.intel.com>
In-Reply-To: <1447399450-29489-1-git-send-email-yuanhan.liu@linux.intel.com>

First of all, RESET_OWNER message is sent incorrectly, as it's sent
before GET_VRING_BASE. And the reset message would let the later call
get nothing correct.

And, sending SET_VRING_ENABLE at stop, which has already been done,
makes more sense than RESET_OWNER.

Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
---
 hw/net/vhost_net.c | 6 ------
 1 file changed, 6 deletions(-)
diff mbox

Patch

diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
index d91b7b1..14337a4 100644
--- a/hw/net/vhost_net.c
+++ b/hw/net/vhost_net.c
@@ -292,12 +292,6 @@  static void vhost_net_stop_one(struct vhost_net *net,
             int r = vhost_ops->vhost_net_set_backend(&net->dev, &file);
             assert(r >= 0);
         }
-    } else if (net->nc->info->type == NET_CLIENT_OPTIONS_KIND_VHOST_USER) {
-        for (file.index = 0; file.index < net->dev.nvqs; ++file.index) {
-            const VhostOps *vhost_ops = net->dev.vhost_ops;
-            int r = vhost_ops->vhost_reset_device(&net->dev);
-            assert(r >= 0);
-        }
     }
     if (net->nc->info->poll) {
         net->nc->info->poll(net->nc, true);