| Message ID | 1449045535.3716.10.camel@perches.com |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote: > Commit 7fd89545f337 ("i40e: remove BUG_ON from feature string > building") > added defective output when I40E_FLAG_VEB_MODE_ENABLED was set in > function i40e_print_features. > > Fix it. > > Miscellanea: > > o Remove unnecessary string variable > o Add space before not after fixed strings > o Use kmalloc not kzalloc > o Don't initialize i to 0, use result of first snprintf > > Noticed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Don't you mean Reported-by? I am not aware of Noticed-by as being a recognized signature. > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/net/ethernet/intel/i40e/i40e_main.c | 42 +++++++++++++---- > ------------ > 1 file changed, 19 insertions(+), 23 deletions(-)
On Wed, 2015-12-02 at 01:56 -0800, Jeff Kirsher wrote: > On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote: > > Commit 7fd89545f337 ("i40e: remove BUG_ON from feature string > > building") > > added defective output when I40E_FLAG_VEB_MODE_ENABLED was set in > > function i40e_print_features. > > > > Fix it. > > > > Miscellanea: > > > > o Remove unnecessary string variable > > o Add space before not after fixed strings > > o Use kmalloc not kzalloc > > o Don't initialize i to 0, use result of first snprintf > > > > Noticed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > Don't you mean Reported-by? I am not aware of Noticed-by as being a > recognized signature. At least for the get_maintainer script, "<anything>-by:" is a signature -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Joe Perches <joe@perches.com> Date: Wed, 02 Dec 2015 02:12:29 -0800 > On Wed, 2015-12-02 at 01:56 -0800, Jeff Kirsher wrote: >> On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote: >> > Commit 7fd89545f337 ("i40e: remove BUG_ON from feature string >> > building") >> > added defective output when I40E_FLAG_VEB_MODE_ENABLED was set in >> > function i40e_print_features. >> > >> > Fix it. >> > >> > Miscellanea: >> > >> > o Remove unnecessary string variable >> > o Add space before not after fixed strings >> > o Use kmalloc not kzalloc >> > o Don't initialize i to 0, use result of first snprintf >> > >> > Noticed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> >> Don't you mean Reported-by? I am not aware of Noticed-by as being a >> recognized signature. > > At least for the get_maintainer script, "<anything>-by:" is a signature Is patchwork using the same regexp? If not, for the time being don't user non-standard tags, and furthermore please ask the patchwork folks to use something similar to getmaintainer.pl Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 2015-12-02 at 15:48 -0500, David Miller wrote: > From: Joe Perches <joe@perches.com> 02 Dec 2015 02:12:29 -0800 > > On Wed, 2015-12-02 at 01:56 -0800, Jeff Kirsher wrote: > >> On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote: > >> > Noticed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > >> Don't you mean Reported-by? I am not aware of Noticed-by as being a > >> recognized signature. > > At least for the get_maintainer script, "-by:" is a signature > Is patchwork using the same regexp? If not, for the time being don't > user non-standard tags, and furthermore please ask the patchwork folks > to use something similar to getmaintainer.pl It doesn't seem so. response_re = re.compile( r'^(Tested|Reviewed|Acked|Signed-off|Nacked|Reported)-by: .*$', re.M | re.I) patchwork also doesn't seem very forgiving of misformatted signatures. (btw: Junio Hamano seems to prefer calling them trailers) And patchwork doesn't seem to handle "cc: " markers either. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote: > Commit 7fd89545f337 ("i40e: remove BUG_ON from feature string > building") > added defective output when I40E_FLAG_VEB_MODE_ENABLED was set in > function i40e_print_features. > > Fix it. > > Miscellanea: > > o Remove unnecessary string variable > o Add space before not after fixed strings > o Use kmalloc not kzalloc > o Don't initialize i to 0, use result of first snprintf > > Noticed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/net/ethernet/intel/i40e/i40e_main.c | 42 +++++++++++++---- > ------------ > 1 file changed, 19 insertions(+), 23 deletions(-) Your patch does not apply cleanly, it appears you used Dave's net-next tree to generate your patch, versus my next-queue tree (dev-queue branch) which has a number of i40e patches already applied. As a one-time only reminder, I have gone ahead and applied your patch by hand. I will send your updated patch out here in just a minute.
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index 4b7d874..145eeb5 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -10240,52 +10240,48 @@ static int i40e_setup_pf_filter_control(struct i40e_pf *pf) static void i40e_print_features(struct i40e_pf *pf) { struct i40e_hw *hw = &pf->hw; - char *buf, *string; - int i = 0; + char *buf; + int i; - string = kzalloc(INFO_STRING_LEN, GFP_KERNEL); - if (!string) { - dev_err(&pf->pdev->dev, "Features string allocation failed\n"); + buf = kmalloc(INFO_STRING_LEN, GFP_KERNEL); + if (!buf) return; - } - - buf = string; - i += snprintf(&buf[i], REMAIN(i), "Features: PF-id[%d] ", hw->pf_id); + i = snprintf(buf, INFO_STRING_LEN, "Features: PF-id[%d]", hw->pf_id); #ifdef CONFIG_PCI_IOV - i += snprintf(&buf[i], REMAIN(i), "VFs: %d ", pf->num_req_vfs); + i += snprintf(&buf[i], REMAIN(i), " VFs: %d", pf->num_req_vfs); #endif - i += snprintf(&buf[i], REMAIN(i), "VSIs: %d QP: %d RX: %s ", + i += snprintf(&buf[i], REMAIN(i), " VSIs: %d QP: %d RX: %s", pf->hw.func_caps.num_vsis, pf->vsi[pf->lan_vsi]->num_queue_pairs, pf->flags & I40E_FLAG_RX_PS_ENABLED ? "PS" : "1BUF"); if (pf->flags & I40E_FLAG_RSS_ENABLED) - i += snprintf(&buf[i], REMAIN(i), "RSS "); + i += snprintf(&buf[i], REMAIN(i), " RSS"); if (pf->flags & I40E_FLAG_FD_ATR_ENABLED) - i += snprintf(&buf[i], REMAIN(i), "FD_ATR "); + i += snprintf(&buf[i], REMAIN(i), " FD_ATR"); if (pf->flags & I40E_FLAG_FD_SB_ENABLED) { - i += snprintf(&buf[i], REMAIN(i), "FD_SB "); - i += snprintf(&buf[i], REMAIN(i), "NTUPLE "); + i += snprintf(&buf[i], REMAIN(i), " FD_SB"); + i += snprintf(&buf[i], REMAIN(i), " NTUPLE"); } if (pf->flags & I40E_FLAG_DCB_CAPABLE) - i += snprintf(&buf[i], REMAIN(i), "DCB "); + i += snprintf(&buf[i], REMAIN(i), " DCB"); #if IS_ENABLED(CONFIG_VXLAN) - i += snprintf(&buf[i], REMAIN(i), "VxLAN "); + i += snprintf(&buf[i], REMAIN(i), " VxLAN"); #endif if (pf->flags & I40E_FLAG_PTP) - i += snprintf(&buf[i], REMAIN(i), "PTP "); + i += snprintf(&buf[i], REMAIN(i), " PTP"); #ifdef I40E_FCOE if (pf->flags & I40E_FLAG_FCOE_ENABLED) - i += snprintf(&buf[i], REMAIN(i), "FCOE "); + i += snprintf(&buf[i], REMAIN(i), " FCOE"); #endif if (pf->flags & I40E_FLAG_VEB_MODE_ENABLED) - i += snprintf(&buf[i], REMAIN(i), "VEPA "); + i += snprintf(&buf[i], REMAIN(i), " VEB"); else - buf += sprintf(buf, "VEPA "); + i += snprintf(&buf[i], REMAIN(i), " VEPA"); - dev_info(&pf->pdev->dev, "%s\n", string); - kfree(string); + dev_info(&pf->pdev->dev, "%s\n", buf); + kfree(buf); WARN_ON(i > INFO_STRING_LEN); }
Commit 7fd89545f337 ("i40e: remove BUG_ON from feature string building") added defective output when I40E_FLAG_VEB_MODE_ENABLED was set in function i40e_print_features. Fix it. Miscellanea: o Remove unnecessary string variable o Add space before not after fixed strings o Use kmalloc not kzalloc o Don't initialize i to 0, use result of first snprintf Noticed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/ethernet/intel/i40e/i40e_main.c | 42 +++++++++++++---------------- 1 file changed, 19 insertions(+), 23 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html