Message ID | 1449036776-14854-2-git-send-email-dinguyen@opensource.altera.com |
---|---|
State | Superseded |
Headers | show |
On Wednesday, December 02, 2015 at 07:12:48 AM, dinguyen@opensource.altera.com wrote: > From: Dinh Nguyen <dinguyen@opensource.altera.com> > > In order to re-use as much Cyclone5 and Arria5 code as possible to support > the Arria10 platform, we need to wrap some of the code with #ifdef's. By > adding CONFIG_SOCFPGA_GEN5, we can shorten the check by not having to check > for both AV || AV. CV || AV ;-) > Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com> > --- > arch/arm/mach-socfpga/Kconfig | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/mach-socfpga/Kconfig b/arch/arm/mach-socfpga/Kconfig > index 0cb9f9e..4ea171a 100644 > --- a/arch/arm/mach-socfpga/Kconfig > +++ b/arch/arm/mach-socfpga/Kconfig > @@ -2,9 +2,14 @@ if ARCH_SOCFPGA > > config TARGET_SOCFPGA_ARRIA5 > bool > + select SOCFPGA_GEN5 > > config TARGET_SOCFPGA_CYCLONE5 > bool > + select SOCFPGA_GEN5 > + > +config SOCFPGA_GEN5 Shall this be called SOCFPGA_GEN5 or TARGET_SOCFPGA_GEN5 , what do you think ? > + bool > > choice > prompt "Altera SOCFPGA board select" Best regards, Marek Vasut
On Wed, Dec 2, 2015 at 8:12 AM, Marek Vasut <marex@denx.de> wrote: > On Wednesday, December 02, 2015 at 07:12:48 AM, dinguyen@opensource.altera.com > wrote: >> From: Dinh Nguyen <dinguyen@opensource.altera.com> >> >> In order to re-use as much Cyclone5 and Arria5 code as possible to support >> the Arria10 platform, we need to wrap some of the code with #ifdef's. By >> adding CONFIG_SOCFPGA_GEN5, we can shorten the check by not having to check >> for both AV || AV. > > CV || AV ;-) > >> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com> >> --- >> arch/arm/mach-socfpga/Kconfig | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/mach-socfpga/Kconfig b/arch/arm/mach-socfpga/Kconfig >> index 0cb9f9e..4ea171a 100644 >> --- a/arch/arm/mach-socfpga/Kconfig >> +++ b/arch/arm/mach-socfpga/Kconfig >> @@ -2,9 +2,14 @@ if ARCH_SOCFPGA >> >> config TARGET_SOCFPGA_ARRIA5 >> bool >> + select SOCFPGA_GEN5 >> >> config TARGET_SOCFPGA_CYCLONE5 >> bool >> + select SOCFPGA_GEN5 >> + >> +config SOCFPGA_GEN5 > > Shall this be called SOCFPGA_GEN5 or TARGET_SOCFPGA_GEN5 , what do you think ? > Yeah, TARGET_SOCFPGA_GEN5 for consistency. Dinh
diff --git a/arch/arm/mach-socfpga/Kconfig b/arch/arm/mach-socfpga/Kconfig index 0cb9f9e..4ea171a 100644 --- a/arch/arm/mach-socfpga/Kconfig +++ b/arch/arm/mach-socfpga/Kconfig @@ -2,9 +2,14 @@ if ARCH_SOCFPGA config TARGET_SOCFPGA_ARRIA5 bool + select SOCFPGA_GEN5 config TARGET_SOCFPGA_CYCLONE5 bool + select SOCFPGA_GEN5 + +config SOCFPGA_GEN5 + bool choice prompt "Altera SOCFPGA board select"