diff mbox

[v2,1/2] Documentation: devicetree: add epson rx6110 binding

Message ID 1448977700-10924-1-git-send-email-s.trumtrar@pengutronix.de
State Superseded
Headers show

Commit Message

Steffen Trumtrar Dec. 1, 2015, 1:48 p.m. UTC
Add the binding documentation for the Epson RX6110 RTC.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
Changes since v1:
	- added i2c binding
	- compatible: "epson,rtc-rx6110" -> "epson,rx6110"
	- fixed typo

 .../devicetree/bindings/rtc/epson,rx6110.txt       | 39 ++++++++++++++++++++++
 1 file changed, 39 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/rtc/epson,rx6110.txt

Comments

Rob Herring Dec. 3, 2015, 2:55 p.m. UTC | #1
On Tue, Dec 01, 2015 at 02:48:19PM +0100, Steffen Trumtrar wrote:
> Add the binding documentation for the Epson RX6110 RTC.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
> Changes since v1:
> 	- added i2c binding
> 	- compatible: "epson,rtc-rx6110" -> "epson,rx6110"
> 	- fixed typo
> 
>  .../devicetree/bindings/rtc/epson,rx6110.txt       | 39 ++++++++++++++++++++++
>  1 file changed, 39 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rtc/epson,rx6110.txt
> 
> diff --git a/Documentation/devicetree/bindings/rtc/epson,rx6110.txt b/Documentation/devicetree/bindings/rtc/epson,rx6110.txt
> new file mode 100644
> index 000000000000..8c3d06f117e8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/epson,rx6110.txt
> @@ -0,0 +1,39 @@
> +Epson RX6110 Real Time Clock
> +============================
> +
> +The Epson RX6110 can be used with SPI or I2C busses. The kind of
> +bus depends on the SPISEL pin and can not be configured via software.
> +
> +I2C mode
> +--------
> +
> +Required properties:
> +  - compatible: should be: "epson,rx6110"
> +  - reg : offset and length of the register set for the device

For i2c, there is no size cell. Otherwise,

Acked-by: Rob Herring <robh@kernel.org>

> +
> +Example:
> +
> +	rtc: rtc@32 {
> +		compatible = "epson,rx6110"
> +		reg = <0x32 0x32>;
> +	};
> +
> +SPI mode
> +--------
> +
> +Required properties:
> +  - compatible: should be: "epson,rx6110"
> +  - reg: chip select number
> +  - spi-cs-high: RX6110 needs chipselect high
> +  - spi-cpha: RX6110 works with SPI shifted clock phase
> +  - spi-cpol: RX6110 works with SPI inverse clock polarity
> +
> +Example:
> +
> +	rtc: rtc@3 {
> +		compatible = "epson,rx6110"
> +		reg = <3>
> +		spi-cs-high;
> +		spi-cpha;
> +		spi-cpol;
> +	};
> -- 
> 2.6.2
>
Steffen Trumtrar Dec. 7, 2015, 12:04 p.m. UTC | #2
On Thu, Dec 03, 2015 at 08:55:52AM -0600, Rob Herring wrote:
> On Tue, Dec 01, 2015 at 02:48:19PM +0100, Steffen Trumtrar wrote:
> > Add the binding documentation for the Epson RX6110 RTC.
> > 
> > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > ---
> > Changes since v1:
> > 	- added i2c binding
> > 	- compatible: "epson,rtc-rx6110" -> "epson,rx6110"
> > 	- fixed typo
> > 
> >  .../devicetree/bindings/rtc/epson,rx6110.txt       | 39 ++++++++++++++++++++++
> >  1 file changed, 39 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/rtc/epson,rx6110.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/rtc/epson,rx6110.txt b/Documentation/devicetree/bindings/rtc/epson,rx6110.txt
> > new file mode 100644
> > index 000000000000..8c3d06f117e8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/epson,rx6110.txt
> > @@ -0,0 +1,39 @@
> > +Epson RX6110 Real Time Clock
> > +============================
> > +
> > +The Epson RX6110 can be used with SPI or I2C busses. The kind of
> > +bus depends on the SPISEL pin and can not be configured via software.
> > +
> > +I2C mode
> > +--------
> > +
> > +Required properties:
> > +  - compatible: should be: "epson,rx6110"
> > +  - reg : offset and length of the register set for the device
> 
> For i2c, there is no size cell. Otherwise,

Okay. I removed it from the binding documentation.

> 
> Acked-by: Rob Herring <robh@kernel.org>
> 

Thanks,
Steffen Trumtrar
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/rtc/epson,rx6110.txt b/Documentation/devicetree/bindings/rtc/epson,rx6110.txt
new file mode 100644
index 000000000000..8c3d06f117e8
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/epson,rx6110.txt
@@ -0,0 +1,39 @@ 
+Epson RX6110 Real Time Clock
+============================
+
+The Epson RX6110 can be used with SPI or I2C busses. The kind of
+bus depends on the SPISEL pin and can not be configured via software.
+
+I2C mode
+--------
+
+Required properties:
+  - compatible: should be: "epson,rx6110"
+  - reg : offset and length of the register set for the device
+
+Example:
+
+	rtc: rtc@32 {
+		compatible = "epson,rx6110"
+		reg = <0x32 0x32>;
+	};
+
+SPI mode
+--------
+
+Required properties:
+  - compatible: should be: "epson,rx6110"
+  - reg: chip select number
+  - spi-cs-high: RX6110 needs chipselect high
+  - spi-cpha: RX6110 works with SPI shifted clock phase
+  - spi-cpol: RX6110 works with SPI inverse clock polarity
+
+Example:
+
+	rtc: rtc@3 {
+		compatible = "epson,rx6110"
+		reg = <3>
+		spi-cs-high;
+		spi-cpha;
+		spi-cpol;
+	};