diff mbox

[U-Boot,6/6] dm: x86: Drop the weak cpu_irq_init() function

Message ID 1448945224-14529-7-git-send-email-sjg@chromium.org
State Superseded
Delegated to: Simon Glass
Headers show

Commit Message

Simon Glass Dec. 1, 2015, 4:47 a.m. UTC 
There are no callers now. Platforms which need to set up interrupts their
own way can implement an interrupt driver. Drop this function.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 arch/x86/cpu/irq.c         |  7 -------
 arch/x86/include/asm/irq.h | 10 ----------
 2 files changed, 17 deletions(-)

Comments

Bin Meng Dec. 14, 2015, 6:06 a.m. UTC | #1 
On Tue, Dec 1, 2015 at 12:47 PM, Simon Glass <sjg@chromium.org> wrote:
> There are no callers now. Platforms which need to set up interrupts their
> own way can implement an interrupt driver. Drop this function.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff mbox

Patch

diff --git a/arch/x86/cpu/irq.c b/arch/x86/cpu/irq.c
index e2feba7..324866c 100644
--- a/arch/x86/cpu/irq.c
+++ b/arch/x86/cpu/irq.c
@@ -83,11 +83,6 @@  static inline void fill_irq_info(struct irq_info *slot, int bus, int device,
 	slot->irq[pin - 1].bitmap = irq_router.irq_mask;
 }
 
-__weak void cpu_irq_init(void)
-{
-	return;
-}
-
 static int create_pirq_routing_table(void)
 {
 	const void *blob = gd->fdt_blob;
@@ -235,8 +230,6 @@  int irq_router_common_init(struct udevice *dev)
 {
 	int ret;
 
-	cpu_irq_init();
-
 	ret = create_pirq_routing_table();
 	if (ret) {
 		debug("Failed to create pirq routing table\n");
diff --git a/arch/x86/include/asm/irq.h b/arch/x86/include/asm/irq.h
index 46e1c31..5b9e673 100644
--- a/arch/x86/include/asm/irq.h
+++ b/arch/x86/include/asm/irq.h
@@ -56,16 +56,6 @@  struct pirq_routing {
 #define PIRQ_BITMAP		0xdef8
 
 /**
- * cpu_irq_init() - Initialize CPU IRQ routing
- *
- * This initializes some platform-specific registers related to IRQ routing,
- * like configuring internal PCI devices to use which PCI interrupt pin,
- * and which PCI interrupt pin is mapped to which PIRQ line. Note on some
- * platforms, such IRQ routing might be hard-coded thus cannot configure.
- */
-void cpu_irq_init(void);
-
-/**
  * irq_router_common_init() - Perform common x86 interrupt init
  *
  * This creates the PIRQ routing table and routes the IRQs