Patchwork UBUNTU: CONFIG: enforce -- make sure we disable CONFIG_LOCALVERSION_AUTO

login
register
mail settings
Submitter Bryan Wu
Date June 9, 2010, 7:42 a.m.
Message ID <1276069328-22218-1-git-send-email-bryan.wu@canonical.com>
Download mbox | patch
Permalink /patch/55055/
State Accepted
Delegated to: Leann Ogasawara
Headers show

Comments

Bryan Wu - June 9, 2010, 7:42 a.m.
CONFIG_LOCALVERSION_AUTO will change the Linux kernel's version, it will cause
packaging failure.

Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
---
 debian/config/enforce |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Stefan Bader - June 9, 2010, 9:42 a.m.
On 06/09/2010 09:42 AM, Bryan Wu wrote:
> CONFIG_LOCALVERSION_AUTO will change the Linux kernel's version, it will cause
> packaging failure.
> 
> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
> ---
>  debian/config/enforce |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/debian/config/enforce b/debian/config/enforce
> index 6481323..64cae67 100644
> --- a/debian/config/enforce
> +++ b/debian/config/enforce
> @@ -42,3 +42,6 @@ value CONFIG_BLK_DEV_DM y
>  # sysfs: ensure all DEPRECATED items are off
>  value CONFIG_SYSFS_DEPRECATED_V2 n
>  !exists CONFIG_SYSFS_DEPRECATED | value CONFIG_SYSFS_DEPRECATED n
> +
> +# automatically add local version will cause packaging failure
> +value CONFIG_LOCALVERSION_AUTO n

Makes sort of sense to add that for Maverick.
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Tim Gardner - June 9, 2010, 12:48 p.m.
On 06/09/2010 01:42 AM, Bryan Wu wrote:
> CONFIG_LOCALVERSION_AUTO will change the Linux kernel's version, it will cause
> packaging failure.
>
> Signed-off-by: Bryan Wu<bryan.wu@canonical.com>
> ---
>   debian/config/enforce |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/debian/config/enforce b/debian/config/enforce
> index 6481323..64cae67 100644
> --- a/debian/config/enforce
> +++ b/debian/config/enforce
> @@ -42,3 +42,6 @@ value CONFIG_BLK_DEV_DM y
>   # sysfs: ensure all DEPRECATED items are off
>   value CONFIG_SYSFS_DEPRECATED_V2 n
>   !exists CONFIG_SYSFS_DEPRECATED | value CONFIG_SYSFS_DEPRECATED n
> +
> +# automatically add local version will cause packaging failure
> +value CONFIG_LOCALVERSION_AUTO n

Yeah, not having this disabled can cause some bizarre packaging 
failures. It took me awhile to find this out the first time. Ack for 
Maverick.

Acked-by: Tim Gardner <tim.gardner@canonical.com>
Leann Ogasawara - June 10, 2010, 3:17 a.m.
Applied to Maverick linux master.

Thanks,
Leann

Patch

diff --git a/debian/config/enforce b/debian/config/enforce
index 6481323..64cae67 100644
--- a/debian/config/enforce
+++ b/debian/config/enforce
@@ -42,3 +42,6 @@  value CONFIG_BLK_DEV_DM y
 # sysfs: ensure all DEPRECATED items are off
 value CONFIG_SYSFS_DEPRECATED_V2 n
 !exists CONFIG_SYSFS_DEPRECATED | value CONFIG_SYSFS_DEPRECATED n
+
+# automatically add local version will cause packaging failure
+value CONFIG_LOCALVERSION_AUTO n