From patchwork Tue Jun 8 19:16:33 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Williamson X-Patchwork-Id: 55021 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id CBBD5B7D61 for ; Wed, 9 Jun 2010 05:27:13 +1000 (EST) Received: from localhost ([127.0.0.1]:53630 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OM4S5-00064v-Rk for incoming@patchwork.ozlabs.org; Tue, 08 Jun 2010 15:27:09 -0400 Received: from [140.186.70.92] (port=35561 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OM4I2-0007UO-8C for qemu-devel@nongnu.org; Tue, 08 Jun 2010 15:16:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OM4I0-0005qO-TV for qemu-devel@nongnu.org; Tue, 08 Jun 2010 15:16:46 -0400 Received: from qmta13.westchester.pa.mail.comcast.net ([76.96.59.243]:43970) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM4I0-0005qB-PR for qemu-devel@nongnu.org; Tue, 08 Jun 2010 15:16:44 -0400 Received: from omta05.westchester.pa.mail.comcast.net ([76.96.62.43]) by qmta13.westchester.pa.mail.comcast.net with comcast id TWQu1e0020vyq2s5DXGlFq; Tue, 08 Jun 2010 19:16:45 +0000 Received: from localhost.localdomain ([75.71.122.219]) by omta05.westchester.pa.mail.comcast.net with comcast id TXGj1e00Z4k7Kz73RXGkmd; Tue, 08 Jun 2010 19:16:45 +0000 From: Alex Williamson To: qemu-devel@nongnu.org, anthony@codemonkey.ws Date: Tue, 08 Jun 2010 13:16:33 -0600 Message-ID: <20100608191633.4451.59848.stgit@localhost.localdomain> In-Reply-To: <20100608191447.4451.47795.stgit@localhost.localdomain> References: <20100608191447.4451.47795.stgit@localhost.localdomain> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: chrisw@redhat.com, alex.williamson@redhat.com, kvm@vger.kernel.org, quintela@redhat.com Subject: [Qemu-devel] [RFC PATCH 5/6] savevm: Migrate RAM based on name/offset X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Synchronize RAM blocks with the target and migrate using name/offset pairs. This ensures both source and target have the same view of RAM and that we get the right bits into the right slot. Signed-off-by: Alex Williamson --- arch_init.c | 103 +++++++++++++++++++++++++++++++++++++++++++++++++++++------ vl.c | 2 + 2 files changed, 93 insertions(+), 12 deletions(-) diff --git a/arch_init.c b/arch_init.c index 6103461..8ba92ec 100644 --- a/arch_init.c +++ b/arch_init.c @@ -113,20 +113,29 @@ static int ram_save_block(QEMUFile *f) while (addr < total_ram) { if (cpu_physical_memory_get_dirty(current_addr, MIGRATION_DIRTY_FLAG)) { + RAMBlock *block; + ram_addr_t offset; uint8_t *p; cpu_physical_memory_reset_dirty(current_addr, current_addr + TARGET_PAGE_SIZE, MIGRATION_DIRTY_FLAG); - p = qemu_get_ram_ptr(current_addr); + QLIST_FOREACH(block, &ram.blocks, next) { + if (current_addr - block->offset < block->length) + break; + } + offset = current_addr - block->offset; + p = block->host + offset; if (is_dup_page(p, *p)) { - qemu_put_be64(f, current_addr | RAM_SAVE_FLAG_COMPRESS); + qemu_put_be64(f, offset | RAM_SAVE_FLAG_COMPRESS); + qemu_put_buffer(f, (uint8_t *)block->name, sizeof(block->name)); qemu_put_byte(f, *p); bytes_sent = 1; } else { - qemu_put_be64(f, current_addr | RAM_SAVE_FLAG_PAGE); + qemu_put_be64(f, offset | RAM_SAVE_FLAG_PAGE); + qemu_put_buffer(f, (uint8_t *)block->name, sizeof(block->name)); qemu_put_buffer(f, p, TARGET_PAGE_SIZE); bytes_sent = TARGET_PAGE_SIZE; } @@ -196,6 +205,7 @@ int ram_save_live(Monitor *mon, QEMUFile *f, int stage, void *opaque) } if (stage == 1) { + RAMBlock *block; uint64_t total_ram = ram_bytes_total(); bytes_transferred = 0; @@ -210,6 +220,11 @@ int ram_save_live(Monitor *mon, QEMUFile *f, int stage, void *opaque) cpu_physical_memory_set_dirty_tracking(1); qemu_put_be64(f, total_ram | RAM_SAVE_FLAG_MEM_SIZE); + + QLIST_FOREACH(block, &ram.blocks, next) { + qemu_put_buffer(f, (uint8_t *)block->name, sizeof(block->name)); + qemu_put_be64(f, block->length); + } } bytes_transferred_last = bytes_transferred; @@ -257,7 +272,7 @@ int ram_load(QEMUFile *f, void *opaque, int version_id) ram_addr_t addr; int flags; - if (version_id != 3) { + if (version_id < 3) { return -EINVAL; } @@ -268,23 +283,89 @@ int ram_load(QEMUFile *f, void *opaque, int version_id) addr &= TARGET_PAGE_MASK; if (flags & RAM_SAVE_FLAG_MEM_SIZE) { - if (addr != ram_bytes_total()) { - return -EINVAL; + if (version_id == 3) { + if (addr != ram_bytes_total()) { + return -EINVAL; + } + } else { + /* Synchronize RAM block list */ + char name[64]; + ram_addr_t length; + ram_addr_t total_ram_bytes = addr; + + while (total_ram_bytes) { + RAMBlock *block; + qemu_get_buffer(f, (uint8_t *)name, sizeof(name)); + length = qemu_get_be64(f); + + QLIST_FOREACH(block, &ram.blocks, next) { + if (!strncmp(name, block->name, sizeof(name))) { + if (block->length != length) + return -EINVAL; + break; + } + } + + if (!block) { + if (!qemu_ram_alloc(name, length)) + return -ENOMEM; + } + + total_ram_bytes -= length; + } } } if (flags & RAM_SAVE_FLAG_COMPRESS) { - uint8_t ch = qemu_get_byte(f); - memset(qemu_get_ram_ptr(addr), ch, TARGET_PAGE_SIZE); + void *host; + uint8_t ch; + + if (version_id == 3) { + host = qemu_get_ram_ptr(addr); + } else { + RAMBlock *block; + char name[64]; + + qemu_get_buffer(f, (uint8_t *)name, sizeof(name)); + + QLIST_FOREACH(block, &ram.blocks, next) { + if (!strncmp(name, block->name, sizeof(name))) + break; + } + if (!block) + return -EINVAL; + + host = block->host + addr; + } + ch = qemu_get_byte(f); + memset(host, ch, TARGET_PAGE_SIZE); #ifndef _WIN32 if (ch == 0 && (!kvm_enabled() || kvm_has_sync_mmu())) { - madvise(qemu_get_ram_ptr(addr), TARGET_PAGE_SIZE, - MADV_DONTNEED); + madvise(host, TARGET_PAGE_SIZE, MADV_DONTNEED); } #endif } else if (flags & RAM_SAVE_FLAG_PAGE) { - qemu_get_buffer(f, qemu_get_ram_ptr(addr), TARGET_PAGE_SIZE); + void *host; + + if (version_id == 3) { + host = qemu_get_ram_ptr(addr); + } else { + RAMBlock *block; + char name[64]; + + qemu_get_buffer(f, (uint8_t *)name, sizeof(name)); + + QLIST_FOREACH(block, &ram.blocks, next) { + if (!strncmp(name, block->name, sizeof(name))) + break; + } + if (!block) + return -EINVAL; + + host = block->host + addr; + } + qemu_get_buffer(f, host, TARGET_PAGE_SIZE); } if (qemu_file_has_error(f)) { return -EIO; diff --git a/vl.c b/vl.c index 9e9c176..a871895 100644 --- a/vl.c +++ b/vl.c @@ -3731,7 +3731,7 @@ int main(int argc, char **argv, char **envp) if (qemu_opts_foreach(&qemu_drive_opts, drive_init_func, machine, 1) != 0) exit(1); - register_savevm_live("ram", 0, 3, NULL, ram_save_live, NULL, + register_savevm_live("ram", 0, 4, NULL, ram_save_live, NULL, ram_load, NULL); if (nb_numa_nodes > 0) {