| Message ID | 1448897111-30713-1-git-send-email-ricardo.ribalda@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
On Monday, November 30, 2015 at 04:25:11 PM, Ricardo Ribalda Delgado wrote: > The error message was: > > m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 0, 0 > > The new error message: > > m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 00, 00 > > Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> > --- > drivers/mtd/spi-nor/spi-nor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index b7c038c75684..7d2b96d5f350 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -890,7 +890,7 @@ static const struct flash_info *spi_nor_read_id(struct > spi_nor *nor) return &spi_nor_ids[tmp]; > } > } > - dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %2x, %2x\n", > + dev_err(nor->dev, "unrecognized JEDEC id bytes: %.2x, %.2x, %.2x\n", You can change it to %02x to make it consistent, no ? What do you think ? > id[0], id[1], id[2]); > return ERR_PTR(-ENODEV); > } Best regards, Marek Vasut
Hello Marek On Mon, Nov 30, 2015 at 5:46 PM, Marek Vasut <marex@denx.de> wrote: > On Monday, November 30, 2015 at 04:25:11 PM, Ricardo Ribalda Delgado wrote: >> The error message was: >> >> m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 0, 0 >> >> The new error message: >> >> m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 00, 00 >> >> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> >> --- >> drivers/mtd/spi-nor/spi-nor.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c >> index b7c038c75684..7d2b96d5f350 100644 >> --- a/drivers/mtd/spi-nor/spi-nor.c >> +++ b/drivers/mtd/spi-nor/spi-nor.c >> @@ -890,7 +890,7 @@ static const struct flash_info *spi_nor_read_id(struct >> spi_nor *nor) return &spi_nor_ids[tmp]; >> } >> } >> - dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %2x, %2x\n", >> + dev_err(nor->dev, "unrecognized JEDEC id bytes: %.2x, %.2x, %.2x\n", > > You can change it to %02x to make it consistent, no ? What do you think ? Sure, no problem, it is just that I am more used to %.2 than %02 :) > >> id[0], id[1], id[2]); >> return ERR_PTR(-ENODEV); >> } > > Best regards, > Marek Vasut
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index b7c038c75684..7d2b96d5f350 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -890,7 +890,7 @@ static const struct flash_info *spi_nor_read_id(struct spi_nor *nor) return &spi_nor_ids[tmp]; } } - dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %2x, %2x\n", + dev_err(nor->dev, "unrecognized JEDEC id bytes: %.2x, %.2x, %.2x\n", id[0], id[1], id[2]); return ERR_PTR(-ENODEV); }
The error message was: m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 0, 0 The new error message: m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 00, 00 Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> --- drivers/mtd/spi-nor/spi-nor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)