diff mbox

Fix PR68029

Message ID CAHODtZTUrNOTAO+BVRHeO6ycqYtR3Ftq=uTc7WbtEtJNKNWLPg@mail.gmail.com
State New
Headers show

Commit Message

Jiří Engelthaler Nov. 27, 2015, 1:11 p.m. UTC 
2015-11-27 13:49 GMT+01:00 Bernd Schmidt <bschmidt@redhat.com>:
> On 11/27/2015 01:30 PM, Jiří Engelthaler wrote:
>>
>> Sorry for international characters in my name. It should be
>>
>> Jiri Engelthaler
>>
>> 2015-11-27 13:29 GMT+01:00 Engelthaler Jiří <Jiri.Engelthaler@zat.cz>:
>
>
> There is precedent for non-ASCII characters in ChangeLogs. Grep for Rafael
> Ávila de Espíndola. But I think there should be two spaces before the email
> address.

You are right - two spaces.

>>         PR driver/68029
>>         * opts-common.c (prune_options): fdiagnostics_color ignored
>>         if it was as first parameter
>
>
> This should read "Don't ignore -fdiagnostics-color if it is the first
> parameter." Full sentences with punctuation.

Changelog modified.

Thank you for recommendation, this is my first patch to GCC.

Engy
2015-11-27  Jiri Engelthaler  <engycz@gmail.com>

	PR driver/68029
	* opts-common.c (prune_options): Don't ignore -fdiagnostics-color 
	if it is the first parameter.
gcc/opts-common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jeff Law Dec. 2, 2015, 7:44 a.m. UTC | #1 
On 11/27/2015 06:11 AM, Jiří Engelthaler wrote:
> 2015-11-27 13:49 GMT+01:00 Bernd Schmidt <bschmidt@redhat.com>:
>> On 11/27/2015 01:30 PM, Jiří Engelthaler wrote:
>>>
>>> Sorry for international characters in my name. It should be
>>>
>>> Jiri Engelthaler
>>>
>>> 2015-11-27 13:29 GMT+01:00 Engelthaler Jiří <Jiri.Engelthaler@zat.cz>:
>>
>>
>> There is precedent for non-ASCII characters in ChangeLogs. Grep for Rafael
>> Ávila de Espíndola. But I think there should be two spaces before the email
>> address.
>
> You are right - two spaces.
>
>>>          PR driver/68029
>>>          * opts-common.c (prune_options): fdiagnostics_color ignored
>>>          if it was as first parameter
>>
>>
>> This should read "Don't ignore -fdiagnostics-color if it is the first
>> parameter." Full sentences with punctuation.
>
> Changelog modified.
>
> Thank you for recommendation, this is my first patch to GCC.
I did a successful bootstrap & regression test on x86_64-linux-gnu with 
your patch and installed it on the trunk.

Thanks,
Jeff
diff mbox

Patch

diff --git a/gcc/opts-common.c b/gcc/opts-common.c
index d9bf4d4..24967cc 100644
--- a/gcc/opts-common.c
+++ b/gcc/opts-common.c
@@ -885,7 +885,7 @@  keep:
 	}
     }
 
-  if (fdiagnostics_color_idx > 1)
+  if (fdiagnostics_color_idx >= 1)
     {
       /* We put the last -fdiagnostics-color= at the first position
 	 after argv[0] so it can take effect immediately.  */