Message ID | 1448546505-9509-1-git-send-email-claudiu.manoil@freescale.com |
---|---|
State | Not Applicable, archived |
Delegated to: | David Miller |
Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D0A001402A5 for <patchwork-incoming@ozlabs.org>; Fri, 27 Nov 2015 01:36:49 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751973AbbKZOgq (ORCPT <rfc822;patchwork-incoming@ozlabs.org>); Thu, 26 Nov 2015 09:36:46 -0500 Received: from mail-bn1on0132.outbound.protection.outlook.com ([157.56.110.132]:22567 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751277AbbKZOgo (ORCPT <rfc822;netdev@vger.kernel.org>); Thu, 26 Nov 2015 09:36:44 -0500 Received: from BLUPR0301CA0027.namprd03.prod.outlook.com (10.162.113.165) by BY1PR0301MB1221.namprd03.prod.outlook.com (10.161.203.17) with Microsoft SMTP Server (TLS) id 15.1.331.20; Thu, 26 Nov 2015 14:03:12 +0000 Received: from BN1BFFO11FD047.protection.gbl (2a01:111:f400:7c10::1:173) by BLUPR0301CA0027.outlook.office365.com (2a01:111:e400:5259::37) with Microsoft SMTP Server (TLS) id 15.1.331.20 via Frontend Transport; Thu, 26 Nov 2015 14:03:11 +0000 Authentication-Results: spf=permerror (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; kernel.org; dkim=none (message not signed) header.d=none; kernel.org; dmarc=none action=none header.from=freescale.com; Received-SPF: PermError (protection.outlook.com: domain of freescale.com used an invalid SPF mechanism) Received: from az84smr01.freescale.net (192.88.158.2) by BN1BFFO11FD047.mail.protection.outlook.com (10.58.145.2) with Microsoft SMTP Server (TLS) id 15.1.331.11 via Frontend Transport; Thu, 26 Nov 2015 14:03:11 +0000 Received: from fsr-fed1764-016.ea.freescale.net (fsr-fed1764-016.ea.freescale.net [10.171.81.161]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id tAQE38oc011537; Thu, 26 Nov 2015 07:03:09 -0700 From: Claudiu Manoil <claudiu.manoil@freescale.com> To: <netdev@vger.kernel.org> CC: "David S . Miller" <davem@davemloft.net>, Mark Brown <broonie@kernel.org> Subject: [PATCH net v2] gianfar: Don't use NO_IRQ to check return value of irq_of_parse_and_map() Date: Thu, 26 Nov 2015 16:01:45 +0200 Message-ID: <1448546505-9509-1-git-send-email-claudiu.manoil@freescale.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1448539186-5756-1-git-send-email-broonie@kernel.org> References: <1448539186-5756-1-git-send-email-broonie@kernel.org> X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD047; 1:42vCdycbme7mG4AJ16dM1BZaT+R+tfSqLMiajfcjuR+Jn0OJI9ay59/TtkDUpc9KBv5TOyGomkqLAFS1Uc6/v0j79pwE7cnU78JsgBFGaXrY/udB/MhoK2bfFS7Qb27CKTUuo0PHlor8BGeLhcLj3AfYVtCrfBElBcnilns1c1vas4uKMSHyw2o3VXb8ejecgUQGL/UIR2+JU6mtrNgmR/ArXsr8tOcxEvHxt3oelKLNi5fv62Zji/vqpZso2zEg0P5bZvWR5Ik3w0XO8+5Q02NR2MaFKLjg+c6MPo4q0upsK+1wSz6TaeOW7fCgXK6d5AZUfOXiNBi92oYLRHnfv0ne0RJgRihTMHF5Z33UdGf/x/yx2j1NymCktjjZvmBVlTWzQ13gMavKNv3CmPF+vg== X-Forefront-Antispam-Report: CIP:192.88.158.2; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(448002)(189002)(199003)(106466001)(2950100001)(2351001)(50226001)(87936001)(86362001)(33646002)(1220700001)(229853001)(50466002)(85326001)(50986999)(48376002)(76176999)(104016004)(5008740100001)(69596002)(47776003)(19580395003)(6806005)(110136002)(5001960100002)(11100500001)(189998001)(77096005)(81156007)(586003)(19580405001)(36756003)(92566002)(97736004)(1096002)(5003940100001); DIR:OUT; SFP:1102; SCL:1; SRVR:BY1PR0301MB1221; H:az84smr01.freescale.net; FPR:; SPF:PermError; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Exchange-Diagnostics: 1; BY1PR0301MB1221; 2:kOa06uoqmNYzIz+PwkjP6+a5/Voa/lFE9gJLIHv6MhqHFm2c43E70tGWHe7Im2EXIQymASrxk2GCBS9EEJhKommgDy+RINqtPuWfN6yzXWtVLH707pj3eXUvRGh7Livz43tUqzcAXiVARJWW4NJJDQ==; 3:/Q+1dyppxBZCGtVzk4H6/ZmN7WtnouVVZLUU/8XQ44QQCSSqCXURJhmDveYrQG+G7wnfA47TvZmzB2JV7/yGeUKOH9IqLVSy8aDcwbzC2qfMsluhCIkurJBwFEKZIRXgifTAKvbvdlJr+JPhqJCq2LedNhYFpyvzutn6SrX3vrbq/yt1eewRRqY4RECXXuyn42iPfOUatzOnAzcuOdOK0JcMViwZ3IDMuqazvisYeNc=; 25:iF6n+tJNrnUSr2iLrq9KfT5HUQBacsUwNk60LcweI+YHCsRFH4Ip4imA2OtPMvH67c32deDXSL/wNgdbA7ElD15uTHvUssqXG5+/cSlCkoeG65LZSPEu4Ya0r15n4goMvn0TM/BlA4I28lXjfO/5YdxlT75Xhi7iN/io8xTHO7iNdy6AFDAhoU6ghCSTdoxFdsv9epPrfuF5dK58YvwM0lhZjQhyUS9FnrimNvZnghh+HhyGX2Oz6Xy2wZuOrSbIpUcUHVpZxNQh2enaFkz7zA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0301MB1221; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0301MB1221; 20:ExJ4dUcMiwlv82GAiOzvKvsJyKqdtJ+iT58lCjPHkD7Y69Nqjl3XLNyeuzfeFrDYuapTDXkvz7D2s8VlEYOETiQfh8X39Z4MFhko7ZFX9Fv3yrVixpJGFvAK34Utudmant3sl3i4NMZ5EpeH2UQZcHO0ESrwyxqQBO3JjPdX1UOBwWhgGWyVKosxARhgLYtLwTKABDI89ZgTQw4mQ14Oa6mptvMKqiAozx1rfP0o234Rr1Wkx//CCqjQOZow14f5n11Z6RCWMjVQNW9osqlIVEXZiRVK0G5kURYOxTyqtknzRUC57iJ8QL/9KrnPzRU+XhMsStjeGpALEWSdxsObkbmRz4BSBKifml2ajAZRQ8E=; 4:dNaYYBn765v8N2TIoCffsU578rl+x/pTd/+rHcPJn4VshfbeIiaeLz7nHDVGYzBK1C+ylj9Oe53nATVxT831z4ohTVJCMBxR3ukINZerzmHbzTa49IofztdroN8BjI82DG7Y1abkj+BNsjPGlYalhJ02GQn3lxgTiUj5W3tXWRjhD+ENQCE1fUe/lKXUUoqFZeN/Pju8yokaVQvZ091ulxVvY+rKQx/RXO3uzrIFa2Arj9KWxEbTcoESrMeKRsOhNMAxBS4nQpGvK2CrpgNawZdrPn7zg4UmhyLfpnEBSIGkQM+rHNqXE2IlnFORgfSnhFpyPSPTJPBIaonEsT5PCdd0Q50SeeHeNivaelEuk5yQpFXWoPxfoD5Oc4FD07o22m/2Fk2JWYLWgaL2VYSQtj55gFBHna4nrUEiPcFNZ7jVruUZR5Q/mfhYCGDMZuKR X-Microsoft-Antispam-PRVS: <BY1PR0301MB1221B587AC08E4359812747D9C040@BY1PR0301MB1221.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(101931422205132); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001)(10201501046); SRVR:BY1PR0301MB1221; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0301MB1221; X-Forefront-PRVS: 0772E5DAD5 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0301MB1221; 23:Mos0KGQgIuA0zmE6pd1jD3ZQgPiDHj5aoJh6W4h?= =?us-ascii?Q?LtxwDpCKhBDS6H2nepIx8y8+tjrdaW+a6CUTcwraiYQjUR7ccoQZXch7YgiQ?= =?us-ascii?Q?4f/YayV3z8ZzCpjm4IQeg5FsyDPsfp80CBOKFnifXxo1lD2ZWU8uP/7RGlGF?= =?us-ascii?Q?OkWW1f8PrdAhkgEbTtHYlUM1cw5rPHO9DtI3TIB941k/ClGdL/c5aE43+M8y?= =?us-ascii?Q?PDMBxDYovU1Q0giOuiKHGDcrYhpruH57VRHrr/upqNVL8ZzEpQ4h1rlINB7v?= =?us-ascii?Q?Lifefgd26y+r1wMYM7dNBB2qIUz3qRMgrILuSaEhpzxOg8mgFaoYOH0W3w5I?= =?us-ascii?Q?wXJaZK0wRustTC936pAgbBUn8B0428hkZ+o3GlTw7x6J5kc1sIWepc4Avsf7?= =?us-ascii?Q?tjQxCrQvAsYTXuY89ku+lii4FU+oWtmblpCnLpzPBKkHnA7D5niR0vNyk+ad?= =?us-ascii?Q?ZB8ACKv/vqnEfGkVu4cPmM+T4nSP9Y4B4Du4Dm5t5k3v9A5/vyiSq6agJjSa?= =?us-ascii?Q?Fk1QFSvJ8SN2aQKmjABUbvtP1qXRCgnPquyVNUVExO9jQBnBmR5bmCnOE5Up?= =?us-ascii?Q?yvfqcpcE69E8ZPbIl4Wz7Incoj24fv/8qOmQq2jAar9XKalhExmYWAM4RJnW?= =?us-ascii?Q?UeJizZs/0So39CT01WHETK5KmDkD+VEXq8hNJhvI40iHTKmkBtw4Atm8S1ad?= =?us-ascii?Q?YBHN201fClH7t+z2dRA9BrIkc0k4Pj6LGWBGfH/tuNrWHYo26gGs49tROpsF?= =?us-ascii?Q?jYVo3GffCpYbToBVF5tWgDgEj4bPVPkDJ3tcZLsZL2QEduUoFeXoTmU9EOaK?= =?us-ascii?Q?PFljZLbUvVq21fUCTHmetUdxX+qkzNB7DN510nqswSTSKbTH3fIJbNPrKgaK?= =?us-ascii?Q?qbENfqpYfcobumbTaJyztHURptpGg2NYQjlhnmYaoeh6cb9jn11VI7vUaDyf?= =?us-ascii?Q?8Y7U0RZ95EMjQGvt0pr+dLn1rqdRM/LtJs9YlbV7371yy/pK/zx2boNfkG8G?= =?us-ascii?Q?obPe/4/rsMlHhae6mcY2nvDXM?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0301MB1221; 5:zkBGdEWd++Y8XafrKlIa8TXPLpCImEeipiT1fOVwd7Q1pZO9gQZpN/6h5Aa2cbhS8IqSfIj2oI1llJwwjGdIMU2d4EDxQr9DOwwJKWi8869pjcXvJOLmqw1c6sEoAgmgSLbwft7lLh2x+dppWBjIcw==; 24:9PhMnejydSe7Mijy+CxcgFJHyP48CbZCTUfJcXWuSk5Ke51RRVEioYdx1aQkywVulsxdtSnXwKFkx7KAsqiU/PG9pONaRAGnIiqqpVxEc64= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Nov 2015 14:03:11.3038 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0301MB1221 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c index 3e6b9b4..5fdd2e7 100644 --- a/drivers/net/ethernet/freescale/gianfar.c +++ b/drivers/net/ethernet/freescale/gianfar.c @@ -642,14 +642,14 @@ static int gfar_parse_group(struct device_node *np, return -ENOMEM; gfar_irq(grp, TX)->irq = irq_of_parse_and_map(np, 0); + if (!gfar_irq(grp, TX)->irq) + return -EINVAL; /* If we aren't the FEC we have multiple interrupts */ if (model && strcasecmp(model, "FEC")) { gfar_irq(grp, RX)->irq = irq_of_parse_and_map(np, 1); gfar_irq(grp, ER)->irq = irq_of_parse_and_map(np, 2); - if (gfar_irq(grp, TX)->irq == NO_IRQ || - gfar_irq(grp, RX)->irq == NO_IRQ || - gfar_irq(grp, ER)->irq == NO_IRQ) + if (!gfar_irq(grp, RX)->irq || !gfar_irq(grp, ER)->irq) return -EINVAL; }