diff mbox

[U-Boot] dm: serial: Minor coding style cleanup of some comments

Message ID 1448541523-16526-1-git-send-email-sr@denx.de
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Stefan Roese Nov. 26, 2015, 12:38 p.m. UTC
Fix incorrect comment alignments.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Simon Glass <sjg@chromium.org>
---
 drivers/serial/serial-uclass.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

Comments

Bin Meng Nov. 26, 2015, 12:44 p.m. UTC | #1
On Thu, Nov 26, 2015 at 8:38 PM, Stefan Roese <sr@denx.de> wrote:
> Fix incorrect comment alignments.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> ---
>  drivers/serial/serial-uclass.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c
> index 842f78b..4bf9a5c 100644
> --- a/drivers/serial/serial-uclass.c
> +++ b/drivers/serial/serial-uclass.c
> @@ -64,9 +64,9 @@ static void serial_find_console_or_panic(void)
>                 }
>
>                 /*
> -               * If the console is not marked to be bound before relocation,
> -               * bind it anyway.
> -               */
> +                * If the console is not marked to be bound before relocation,
> +                * bind it anyway.
> +                */
>                 if (node > 0 &&
>                     !lists_bind_fdt(gd->dm_root, blob, node, &dev)) {
>                         if (!device_probe(dev)) {
> @@ -77,13 +77,13 @@ static void serial_find_console_or_panic(void)
>         }
>         if (!SPL_BUILD || !CONFIG_IS_ENABLED(OF_CONTROL) || !blob) {
>                 /*
> -               * Try to use CONFIG_CONS_INDEX if available (it is numbered
> -               * from 1!).
> -               *
> -               * Failing that, get the device with sequence number 0, or in
> -               * extremis just the first serial device we can find. But we
> -               * insist on having a console (even if it is silent).
> -               */
> +                * Try to use CONFIG_CONS_INDEX if available (it is numbered
> +                * from 1!).
> +                *
> +                * Failing that, get the device with sequence number 0, or in
> +                * extremis just the first serial device we can find. But we
> +                * insist on having a console (even if it is silent).
> +                */
>  #ifdef CONFIG_CONS_INDEX
>  #define INDEX (CONFIG_CONS_INDEX - 1)
>  #else
> --

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Simon Glass Nov. 26, 2015, 5:49 p.m. UTC | #2
On 26 November 2015 at 04:44, Bin Meng <bmeng.cn@gmail.com> wrote:
> On Thu, Nov 26, 2015 at 8:38 PM, Stefan Roese <sr@denx.de> wrote:
>> Fix incorrect comment alignments.
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> Cc: Simon Glass <sjg@chromium.org>
>> ---
>>  drivers/serial/serial-uclass.c | 20 ++++++++++----------
>>  1 file changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c
>> index 842f78b..4bf9a5c 100644
>> --- a/drivers/serial/serial-uclass.c
>> +++ b/drivers/serial/serial-uclass.c
>> @@ -64,9 +64,9 @@ static void serial_find_console_or_panic(void)
>>                 }
>>
>>                 /*
>> -               * If the console is not marked to be bound before relocation,
>> -               * bind it anyway.
>> -               */
>> +                * If the console is not marked to be bound before relocation,
>> +                * bind it anyway.
>> +                */
>>                 if (node > 0 &&
>>                     !lists_bind_fdt(gd->dm_root, blob, node, &dev)) {
>>                         if (!device_probe(dev)) {
>> @@ -77,13 +77,13 @@ static void serial_find_console_or_panic(void)
>>         }
>>         if (!SPL_BUILD || !CONFIG_IS_ENABLED(OF_CONTROL) || !blob) {
>>                 /*
>> -               * Try to use CONFIG_CONS_INDEX if available (it is numbered
>> -               * from 1!).
>> -               *
>> -               * Failing that, get the device with sequence number 0, or in
>> -               * extremis just the first serial device we can find. But we
>> -               * insist on having a console (even if it is silent).
>> -               */
>> +                * Try to use CONFIG_CONS_INDEX if available (it is numbered
>> +                * from 1!).
>> +                *
>> +                * Failing that, get the device with sequence number 0, or in
>> +                * extremis just the first serial device we can find. But we
>> +                * insist on having a console (even if it is silent).
>> +                */
>>  #ifdef CONFIG_CONS_INDEX
>>  #define INDEX (CONFIG_CONS_INDEX - 1)
>>  #else
>> --
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Acked-by: Simon Glass <sjg@chromium.org>
Simon Glass Dec. 11, 2015, 1:24 p.m. UTC | #3
Applied to u-boot-dm, thanks!
diff mbox

Patch

diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c
index 842f78b..4bf9a5c 100644
--- a/drivers/serial/serial-uclass.c
+++ b/drivers/serial/serial-uclass.c
@@ -64,9 +64,9 @@  static void serial_find_console_or_panic(void)
 		}
 
 		/*
-		* If the console is not marked to be bound before relocation,
-		* bind it anyway.
-		*/
+		 * If the console is not marked to be bound before relocation,
+		 * bind it anyway.
+		 */
 		if (node > 0 &&
 		    !lists_bind_fdt(gd->dm_root, blob, node, &dev)) {
 			if (!device_probe(dev)) {
@@ -77,13 +77,13 @@  static void serial_find_console_or_panic(void)
 	}
 	if (!SPL_BUILD || !CONFIG_IS_ENABLED(OF_CONTROL) || !blob) {
 		/*
-		* Try to use CONFIG_CONS_INDEX if available (it is numbered
-		* from 1!).
-		*
-		* Failing that, get the device with sequence number 0, or in
-		* extremis just the first serial device we can find. But we
-		* insist on having a console (even if it is silent).
-		*/
+		 * Try to use CONFIG_CONS_INDEX if available (it is numbered
+		 * from 1!).
+		 *
+		 * Failing that, get the device with sequence number 0, or in
+		 * extremis just the first serial device we can find. But we
+		 * insist on having a console (even if it is silent).
+		 */
 #ifdef CONFIG_CONS_INDEX
 #define INDEX (CONFIG_CONS_INDEX - 1)
 #else