Patchwork qcow2: Restore L1 entry on l2_allocate failure

login
register
mail settings
Submitter Kevin Wolf
Date June 7, 2010, 2:46 p.m.
Message ID <1275921965-11559-1-git-send-email-kwolf@redhat.com>
Download mbox | patch
Permalink /patch/54869/
State New
Headers show

Comments

Kevin Wolf - June 7, 2010, 2:46 p.m.
If writing the L1 table to disk failed, we need to restore its old content in
memory to avoid inconsistencies.

Reported-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/qcow2-cluster.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Patch

diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 03a9f25..5760ad6 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -285,6 +285,7 @@  static int l2_allocate(BlockDriverState *bs, int l1_index, uint64_t **table)
     return 0;
 
 fail:
+    s->l1_table[l1_index] = old_l2_offset;
     qcow2_l2_cache_reset(bs);
     return ret;
 }