From patchwork Mon Jun 7 06:08:06 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Chary X-Patchwork-Id: 54829 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2D12CB7D85 for ; Mon, 7 Jun 2010 16:09:51 +1000 (EST) Received: from localhost ([127.0.0.1]:37234 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLVWt-0003Lv-Ee for incoming@patchwork.ozlabs.org; Mon, 07 Jun 2010 02:09:47 -0400 Received: from [140.186.70.92] (port=34371 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLVUy-0003Lb-6B for qemu-devel@nongnu.org; Mon, 07 Jun 2010 02:07:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OLVUw-0002fA-S9 for qemu-devel@nongnu.org; Mon, 07 Jun 2010 02:07:47 -0400 Received: from iksaif.net ([88.191.73.63]:54662) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLVUw-0002el-NM for qemu-devel@nongnu.org; Mon, 07 Jun 2010 02:07:46 -0400 Received: from tartiflon (lal69-3-82-241-209-44.fbx.proxad.net [82.241.209.44]) (Authenticated sender: corentincj@iksaif.net) by iksaif.net (Postfix) with ESMTPA id 3D7CBC9005E; Mon, 7 Jun 2010 08:11:55 +0200 (CEST) From: Corentin Chary To: qemu-devel@nongnu.org Date: Mon, 7 Jun 2010 08:08:06 +0200 Message-Id: <1275890889-13349-4-git-send-email-corentincj@iksaif.net> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1275890889-13349-1-git-send-email-corentincj@iksaif.net> References: <1275890889-13349-1-git-send-email-corentincj@iksaif.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: Corentin Chary , Anthony Liguori , Alexander Graf , Adam Litke Subject: [Qemu-devel] [PATCH v2 3/6] vnc: add lossy option X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The lossy option can be used to enable lossy compression methods like gradient or jpeg. This patch disable them by default. Signed-off-by: Corentin Chary --- qemu-options.hx | 7 +++++++ vnc-encoding-tight.c | 4 ++++ vnc.c | 2 ++ vnc.h | 2 ++ 4 files changed, 15 insertions(+), 0 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index a6928b7..cf33a54 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -828,6 +828,13 @@ empty, with a @code{deny} policy. Thus no one will be allowed to use the VNC server until the ACLs have been loaded. This can be achieved using the @code{acl} monitor command. +@item lossy + +Enable lossy compression methods (gradient, JPEG, ...). If this +option is set, VNC client may receive lossy framebuffer updates +depending on its encoding settings. Enabling this option can save +a lot of bandwidth at the expense of quality. + @end table ETEXI diff --git a/vnc-encoding-tight.c b/vnc-encoding-tight.c index 495745e..4257bd0 100644 --- a/vnc-encoding-tight.c +++ b/vnc-encoding-tight.c @@ -230,6 +230,10 @@ tight_detect_smooth_image(VncState *vs, int w, int h) int compression = vs->tight_compression; int quality = vs->tight_quality; + if (!vs->vd->lossy) { + return 0; + } + if (ds_get_bytes_per_pixel(vs->ds) == 1 || vs->clientds.pf.bytes_per_pixel == 1 || w < VNC_TIGHT_DETECT_MIN_WIDTH || h < VNC_TIGHT_DETECT_MIN_HEIGHT) { diff --git a/vnc.c b/vnc.c index 9cf38d1..ccd7aad 100644 --- a/vnc.c +++ b/vnc.c @@ -2482,6 +2482,8 @@ int vnc_display_open(DisplayState *ds, const char *display) #endif } else if (strncmp(options, "acl", 3) == 0) { acl = 1; + } else if (strncmp(options, "lossy", 5) == 0) { + vs->lossy = true; } } diff --git a/vnc.h b/vnc.h index 2a9024d..ec90cd3 100644 --- a/vnc.h +++ b/vnc.h @@ -33,6 +33,7 @@ #include "monitor.h" #include "audio/audio.h" #include +#include #include "keymaps.h" @@ -111,6 +112,7 @@ struct VncDisplay char *display; char *password; int auth; + bool lossy; #ifdef CONFIG_VNC_TLS int subauth; /* Used by VeNCrypt */ VncDisplayTLS tls;