From patchwork Sun Jun 6 08:10:55 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 54807 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 3895BB7D1B for ; Sun, 6 Jun 2010 18:24:19 +1000 (EST) Received: from localhost ([127.0.0.1]:47577 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLB9T-0001HT-Np for incoming@patchwork.ozlabs.org; Sun, 06 Jun 2010 04:24:15 -0400 Received: from [140.186.70.92] (port=54817 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLAwv-0002Mc-RJ for qemu-devel@nongnu.org; Sun, 06 Jun 2010 04:11:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OLAwr-0004m8-Or for qemu-devel@nongnu.org; Sun, 06 Jun 2010 04:11:17 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:54418) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLAwr-0004lW-8r for qemu-devel@nongnu.org; Sun, 06 Jun 2010 04:11:13 -0400 Received: from smtp04.web.de ( [172.20.0.225]) by fmmailgate02.web.de (Postfix) with ESMTP id 9D4DE164DD881; Sun, 6 Jun 2010 10:11:12 +0200 (CEST) Received: from [88.66.126.39] (helo=localhost.localdomain) by smtp04.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #4) id 1OLAwq-000200-02; Sun, 06 Jun 2010 10:11:12 +0200 From: Jan Kiszka To: qemu-devel@nongnu.org Date: Sun, 6 Jun 2010 10:10:55 +0200 Message-Id: <3d360b7a41dbbec8cb38104427b6ef734cf1faef.1275811861.git.jan.kiszka@web.de> X-Mailer: git-send-email 1.6.0.2 In-Reply-To: References: In-Reply-To: References: X-Sender: jan.kiszka@web.de X-Provags-ID: V01U2FsdGVkX1/TNDSjvwYb3A5cwm2Mhc4l1aMssn2v3JpD3yLt 61lkCMZp3Z6qbPL8B+1EOUcFY1J1tAb8OY7lYanWVfg1WW96GG aflGVVCPw= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 Cc: blue Swirl , Jan Kiszka , Paul Brook , Gleb Natapov , Juan Quintela Subject: [Qemu-devel] [PATCH 06/16] hpet: Start/stop timer when HPET_TN_ENABLE is modified X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Jan Kiszka We have to update the qemu timer when the per-timer enable bit is toggled, just like for HPET_CFG_ENABLE changes. Signed-off-by: Jan Kiszka --- hw/hpet.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/hpet.c b/hw/hpet.c index 6974935..041dd84 100644 --- a/hw/hpet.c +++ b/hw/hpet.c @@ -430,6 +430,11 @@ static void hpet_ram_writel(void *opaque, target_phys_addr_t addr, printf("qemu: level-triggered hpet not supported\n"); exit (-1); } + if (activating_bit(old_val, new_val, HPET_TN_ENABLE)) { + hpet_set_timer(timer); + } else if (deactivating_bit(old_val, new_val, HPET_TN_ENABLE)) { + hpet_del_timer(timer); + } break; case HPET_TN_CFG + 4: // Interrupt capabilities DPRINTF("qemu: invalid HPET_TN_CFG+4 write\n");