| Message ID | 1448307376-20063-13-git-send-email-jeffrey.t.kirsher@intel.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello. On 11/23/2015 10:36 PM, Jeff Kirsher wrote: > From: Jesse Brandeburg <jesse.brandeburg@intel.com> > > Compiler complained of an unused variable, which the driver was just > using to store the result of a rd32 which is used to clear a register > unconditionally. Just drop the unused variable and re-use one. I don't see Jesse dropping anything... > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> > Tested-by: Andrew Bowers <andrewx.bowers@intel.com> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> > --- > drivers/net/ethernet/intel/i40evf/i40evf_main.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c > index d962164..6ad6265 100644 > --- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c > +++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c > @@ -307,10 +307,9 @@ static irqreturn_t i40evf_msix_aq(int irq, void *data) > struct i40e_hw *hw = &adapter->hw; > u32 val; > > - /* handle non-queue interrupts */ > - rd32(hw, I40E_VFINT_ICR01); > - rd32(hw, I40E_VFINT_ICR0_ENA1); > - > + /* handle non-queue interrupts, these reads clear the registers */ > + val = rd32(hw, I40E_VFINT_ICR01); > + val = rd32(hw, I40E_VFINT_ICR0_ENA1); Why if it's ignored anyway? > > val = rd32(hw, I40E_VFINT_DYN_CTL01) | > I40E_VFINT_DYN_CTL01_CLEARPBA_MASK; MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c index d962164..6ad6265 100644 --- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c +++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c @@ -307,10 +307,9 @@ static irqreturn_t i40evf_msix_aq(int irq, void *data) struct i40e_hw *hw = &adapter->hw; u32 val; - /* handle non-queue interrupts */ - rd32(hw, I40E_VFINT_ICR01); - rd32(hw, I40E_VFINT_ICR0_ENA1); - + /* handle non-queue interrupts, these reads clear the registers */ + val = rd32(hw, I40E_VFINT_ICR01); + val = rd32(hw, I40E_VFINT_ICR0_ENA1); val = rd32(hw, I40E_VFINT_DYN_CTL01) | I40E_VFINT_DYN_CTL01_CLEARPBA_MASK;