| Message ID | 1448288825-4928-1-git-send-email-saurabh.truth@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
Hi Saurabh,
[auto build test ERROR on mtd/master]
[also build test ERROR on v4.4-rc2 next-20151123]
url: https://github.com/0day-ci/linux/commits/Saurabh-Sengar/mtd-nand-use-of_property_read_u8/20151123-222906
base: git://git.infradead.org/linux-mtd.git master
config: arm-mvebu_v5_defconfig (attached as .config)
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm
All errors (new ones prefixed by >>):
drivers/mtd/nand/orion_nand.c: In function 'orion_nand_probe':
>> drivers/mtd/nand/orion_nand.c:114:2: error: expected ';' before '}' token
} else {
^
vim +114 drivers/mtd/nand/orion_nand.c
a0fabf722 Jamie Lentin 2012-04-18 108 board->ale = 1;
c4d333ec0 Saurabh Sengar 2015-11-23 109 if (of_property_read_u8(pdev->dev.of_node,
c4d333ec0 Saurabh Sengar 2015-11-23 110 "bank-width", &board->width))
a0fabf722 Jamie Lentin 2012-04-18 111 board->width = 8;
c4d333ec0 Saurabh Sengar 2015-11-23 112 of_property_read_u8(pdev->dev.of_node,
c4d333ec0 Saurabh Sengar 2015-11-23 113 "chip-delay", &board->chip_delay)
453810b79 Jingoo Han 2013-07-30 @114 } else {
453810b79 Jingoo Han 2013-07-30 115 board = dev_get_platdata(&pdev->dev);
453810b79 Jingoo Han 2013-07-30 116 }
2a1dba293 Tzachi Perelstein 2007-10-17 117
:::::: The code at line 114 was first introduced by commit
:::::: 453810b79571ff6622a481f0556fc4972f87a24f mtd: nand: use dev_get_platdata()
:::::: TO: Jingoo Han <jg1.han@samsung.com>
:::::: CC: David Woodhouse <David.Woodhouse@intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c index ee83749..1a68145 100644 --- a/drivers/mtd/nand/orion_nand.c +++ b/drivers/mtd/nand/orion_nand.c @@ -83,7 +83,6 @@ static int __init orion_nand_probe(struct platform_device *pdev) struct clk *clk; void __iomem *io_base; int ret = 0; - u32 val = 0; nc = devm_kzalloc(&pdev->dev, sizeof(struct nand_chip) + sizeof(struct mtd_info), @@ -103,22 +102,15 @@ static int __init orion_nand_probe(struct platform_device *pdev) GFP_KERNEL); if (!board) return -ENOMEM; - if (!of_property_read_u32(pdev->dev.of_node, "cle", &val)) - board->cle = (u8)val; - else - board->cle = 0; - if (!of_property_read_u32(pdev->dev.of_node, "ale", &val)) - board->ale = (u8)val; - else + of_property_read_u8(pdev->dev.of_node, "cle", &board->cle); + + if (of_property_read_u8(pdev->dev.of_node, "ale", &board->ale)) board->ale = 1; - if (!of_property_read_u32(pdev->dev.of_node, - "bank-width", &val)) - board->width = (u8)val * 8; - else + if (of_property_read_u8(pdev->dev.of_node, + "bank-width", &board->width)) board->width = 8; - if (!of_property_read_u32(pdev->dev.of_node, - "chip-delay", &val)) - board->chip_delay = (u8)val; + of_property_read_u8(pdev->dev.of_node, + "chip-delay", &board->chip_delay) } else { board = dev_get_platdata(&pdev->dev); }
use of_property_read_u8() for u8 values Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com> --- drivers/mtd/nand/orion_nand.c | 22 +++++++--------------- 1 file changed, 7 insertions(+), 15 deletions(-)