Message ID | 4C0A13BA.6050700@gmail.com |
---|---|
State | New, archived |
Headers | show |
Wan ZongShun wrote: > This patch is to use the '__devinit' for pxa2xx_flash_probe. Why? Is it hot-pluggable device? I guess not... > Signed-off-by: Wan ZongShun <mcuos.com@gmail.com> > Acked-by: Eric Miao <eric.y.miao@gmail.com> WBR, Sergei
On Sun, Jun 6, 2010 at 1:18 AM, Sergei Shtylyov <sshtylyov@mvista.com> wrote: > Wan ZongShun wrote: > >> This patch is to use the '__devinit' for pxa2xx_flash_probe. > > Why? Is it hot-pluggable device? I guess not... > Then I guess the __devexit is not applicable to pxa2xx_flash_remove as well. Apart from the _probe() being unnecessarily built in when HOTPLUG is defined, is there any drawbacks. It does make code a little bit consistent from my POV. >> Signed-off-by: Wan ZongShun <mcuos.com@gmail.com> >> Acked-by: Eric Miao <eric.y.miao@gmail.com> > > WBR, Sergei > >
diff --git a/drivers/mtd/maps/pxa2xx-flash.c b/drivers/mtd/maps/pxa2xx-flash.c index dd90880..d8ae634 100644 --- a/drivers/mtd/maps/pxa2xx-flash.c +++ b/drivers/mtd/maps/pxa2xx-flash.c @@ -51,7 +51,7 @@ struct pxa2xx_flash_info { static const char *probes[] = { "RedBoot", "cmdlinepart", NULL }; -static int __init pxa2xx_flash_probe(struct platform_device *pdev) +static int __devinit pxa2xx_flash_probe(struct platform_device *pdev) { struct flash_platform_data *flash = pdev->dev.platform_data; struct pxa2xx_flash_info *info;