| Message ID | 1448065205-15762-13-git-send-email-joshua.henderson@microchip.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
Hello. On 11/21/2015 3:17 AM, Joshua Henderson wrote: > From: Andrei Pistirica <andrei.pistirica@microchip.com> > > Document the devicetree bindings for the SDHC peripheral found on > Microchip PIC32 class devices. > > Signed-off-by: Andrei Pistirica <andrei.pistirica@microchip.com> > Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com> > --- > .../devicetree/bindings/mmc/sdhci-pic32.txt | 24 ++++++++++++++++++++ > 1 file changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-pic32.txt > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt b/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt > new file mode 100644 > index 0000000..f16388c > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt > @@ -0,0 +1,24 @@ > +* Microchip PIC32 SDHCI Controller > + > +This file documents differences between the core properties in mmc.txt > +and the properties used by the sdhci-pic32 driver. > + > +Required properties: > +- compatible: Should be "microchip,pic32-sdhci" > +- reg: Should contain registers location and length > +- interrupts: Should contain interrupt > +- pinctrl: Should contain pinctrl for data and command lines This is a required prop, yet the example doesn't contain it? > + > +Optional properties: > +- no-1-8-v: 1.8V voltage selection not supported > +- piomode: disable DMA support > + > +Example: > + > + sdhci@1f8ec000 { > + compatible = "microchip,pic32-sdhci"; > + reg = <0x1f8ec000 0x100>; > + interrupts = <SDHC_EVENT DEFAULT_INT_PRI IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&REFCLKO4>, <&PBCLK5>; > + clock-names = "base_clk", "sys_clk"; The "clocks" and "clock-names" props are not documented. [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Nov 20, 2015 at 05:17:24PM -0700, Joshua Henderson wrote: > From: Andrei Pistirica <andrei.pistirica@microchip.com> > > Document the devicetree bindings for the SDHC peripheral found on > Microchip PIC32 class devices. > > Signed-off-by: Andrei Pistirica <andrei.pistirica@microchip.com> > Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com> > --- > .../devicetree/bindings/mmc/sdhci-pic32.txt | 24 ++++++++++++++++++++ > 1 file changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-pic32.txt > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt b/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt > new file mode 100644 > index 0000000..f16388c > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt > @@ -0,0 +1,24 @@ > +* Microchip PIC32 SDHCI Controller > + > +This file documents differences between the core properties in mmc.txt > +and the properties used by the sdhci-pic32 driver. > + > +Required properties: > +- compatible: Should be "microchip,pic32-sdhci" > +- reg: Should contain registers location and length > +- interrupts: Should contain interrupt > +- pinctrl: Should contain pinctrl for data and command lines > + > +Optional properties: > +- no-1-8-v: 1.8V voltage selection not supported There's a standard property for this one. > +- piomode: disable DMA support Proably this one too IIRC. > + > +Example: > + > + sdhci@1f8ec000 { > + compatible = "microchip,pic32-sdhci"; > + reg = <0x1f8ec000 0x100>; > + interrupts = <SDHC_EVENT DEFAULT_INT_PRI IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&REFCLKO4>, <&PBCLK5>; > + clock-names = "base_clk", "sys_clk"; > + }; > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Sergei, On 11/21/2015 8:19 AM, Sergei Shtylyov wrote: > Hello. > > On 11/21/2015 3:17 AM, Joshua Henderson wrote: > >> From: Andrei Pistirica <andrei.pistirica@microchip.com> >> >> Document the devicetree bindings for the SDHC peripheral found on >> Microchip PIC32 class devices. >> >> Signed-off-by: Andrei Pistirica <andrei.pistirica@microchip.com> >> Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com> >> --- >> .../devicetree/bindings/mmc/sdhci-pic32.txt | 24 ++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-pic32.txt >> >> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt b/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt >> new file mode 100644 >> index 0000000..f16388c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt >> @@ -0,0 +1,24 @@ >> +* Microchip PIC32 SDHCI Controller >> + >> +This file documents differences between the core properties in mmc.txt >> +and the properties used by the sdhci-pic32 driver. >> + >> +Required properties: >> +- compatible: Should be "microchip,pic32-sdhci" >> +- reg: Should contain registers location and length >> +- interrupts: Should contain interrupt >> +- pinctrl: Should contain pinctrl for data and command lines > > This is a required prop, yet the example doesn't contain it? > Ack. Both the required properties and example need to contain pinctrl-names and pinctrl-0, not pinctrl. >> + >> +Optional properties: >> +- no-1-8-v: 1.8V voltage selection not supported >> +- piomode: disable DMA support >> + >> +Example: >> + >> + sdhci@1f8ec000 { >> + compatible = "microchip,pic32-sdhci"; >> + reg = <0x1f8ec000 0x100>; >> + interrupts = <SDHC_EVENT DEFAULT_INT_PRI IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&REFCLKO4>, <&PBCLK5>; >> + clock-names = "base_clk", "sys_clk"; > > The "clocks" and "clock-names" props are not documented. > > [...] > > MBR, Sergei > Ack. Thanks for the feedback, Josh -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Rob, On 11/22/2015 2:57 PM, Rob Herring wrote: > On Fri, Nov 20, 2015 at 05:17:24PM -0700, Joshua Henderson wrote: >> From: Andrei Pistirica <andrei.pistirica@microchip.com> >> >> Document the devicetree bindings for the SDHC peripheral found on >> Microchip PIC32 class devices. >> >> Signed-off-by: Andrei Pistirica <andrei.pistirica@microchip.com> >> Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com> >> --- >> .../devicetree/bindings/mmc/sdhci-pic32.txt | 24 ++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-pic32.txt >> >> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt b/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt >> new file mode 100644 >> index 0000000..f16388c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt >> @@ -0,0 +1,24 @@ >> +* Microchip PIC32 SDHCI Controller >> + >> +This file documents differences between the core properties in mmc.txt >> +and the properties used by the sdhci-pic32 driver. >> + >> +Required properties: >> +- compatible: Should be "microchip,pic32-sdhci" >> +- reg: Should contain registers location and length >> +- interrupts: Should contain interrupt >> +- pinctrl: Should contain pinctrl for data and command lines >> + >> +Optional properties: >> +- no-1-8-v: 1.8V voltage selection not supported > > There's a standard property for this one. > Correct. This is indeed a standard property that should not be here. There is currently discussion to avoid using this property anyway. >> +- piomode: disable DMA support > > Proably this one too IIRC. > We will be dropping this. There are other ways to accomplish the same thing outside of DT. Josh -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt b/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt new file mode 100644 index 0000000..f16388c --- /dev/null +++ b/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt @@ -0,0 +1,24 @@ +* Microchip PIC32 SDHCI Controller + +This file documents differences between the core properties in mmc.txt +and the properties used by the sdhci-pic32 driver. + +Required properties: +- compatible: Should be "microchip,pic32-sdhci" +- reg: Should contain registers location and length +- interrupts: Should contain interrupt +- pinctrl: Should contain pinctrl for data and command lines + +Optional properties: +- no-1-8-v: 1.8V voltage selection not supported +- piomode: disable DMA support + +Example: + + sdhci@1f8ec000 { + compatible = "microchip,pic32-sdhci"; + reg = <0x1f8ec000 0x100>; + interrupts = <SDHC_EVENT DEFAULT_INT_PRI IRQ_TYPE_LEVEL_HIGH>; + clocks = <&REFCLKO4>, <&PBCLK5>; + clock-names = "base_clk", "sys_clk"; + };