| Message ID | 1448021712-40190-1-git-send-email-pbonzini@redhat.com |
|---|---|
| State | New |
| Headers | show |
* Paolo Bonzini (pbonzini@redhat.com) wrote: > This makes it easier to find the desired thread > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > iothread.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/iothread.c b/iothread.c > index da6ce7b..8a1d6f8 100644 > --- a/iothread.c > +++ b/iothread.c > @@ -72,6 +72,7 @@ static void iothread_complete(UserCreatable *obj, Error **errp) > { > Error *local_error = NULL; > IOThread *iothread = IOTHREAD(obj); > + char *name, *thread_name; > > iothread->stopping = false; > iothread->thread_id = -1; > @@ -87,8 +88,12 @@ static void iothread_complete(UserCreatable *obj, Error **errp) > /* This assumes we are called from a thread with useful CPU affinity for us > * to inherit. > */ > - qemu_thread_create(&iothread->thread, "iothread", iothread_run, > + name = object_get_canonical_path_component(OBJECT(obj)); > + thread_name = g_strdup_printf("iothread %s", name); Yes, that's a good idea; Can you shorten that to just "IO %s" please, for three reasons: 1) There is a ~14 character limit on the size of that string 2) We use CPU ... for the CPU threads. 3) It's a threadname, it doesn't need to say thread Dave > + qemu_thread_create(&iothread->thread, thread_name, iothread_run, > iothread, QEMU_THREAD_JOINABLE); > + g_free(thread_name); > + g_free(name); > > /* Wait for initialization to complete */ > qemu_mutex_lock(&iothread->init_done_lock); > -- > 1.8.3.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
diff --git a/iothread.c b/iothread.c index da6ce7b..8a1d6f8 100644 --- a/iothread.c +++ b/iothread.c @@ -72,6 +72,7 @@ static void iothread_complete(UserCreatable *obj, Error **errp) { Error *local_error = NULL; IOThread *iothread = IOTHREAD(obj); + char *name, *thread_name; iothread->stopping = false; iothread->thread_id = -1; @@ -87,8 +88,12 @@ static void iothread_complete(UserCreatable *obj, Error **errp) /* This assumes we are called from a thread with useful CPU affinity for us * to inherit. */ - qemu_thread_create(&iothread->thread, "iothread", iothread_run, + name = object_get_canonical_path_component(OBJECT(obj)); + thread_name = g_strdup_printf("iothread %s", name); + qemu_thread_create(&iothread->thread, thread_name, iothread_run, iothread, QEMU_THREAD_JOINABLE); + g_free(thread_name); + g_free(name); /* Wait for initialization to complete */ qemu_mutex_lock(&iothread->init_done_lock);
This makes it easier to find the desired thread Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- iothread.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)