| Message ID | 1448014157-36526-4-git-send-email-raphael.poggi@avalun.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Fri, Nov 20, 2015 at 11:09:16AM +0100, Raphael Poggi wrote: > From: Raphael Poggi <poggi.raph@gmail.com> > > Add a binding for specify channel selection. > > Signed-off-by: Raphael Poggi <poggi.raph@gmail.com> > --- > Documentation/devicetree/bindings/sound/pcm1792a.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/pcm1792a.txt b/Documentation/devicetree/bindings/sound/pcm1792a.txt > index 970ba1e..6e87a3a 100644 > --- a/Documentation/devicetree/bindings/sound/pcm1792a.txt > +++ b/Documentation/devicetree/bindings/sound/pcm1792a.txt > @@ -9,10 +9,15 @@ Required properties: > For required properties on SPI, please consult > Documentation/devicetree/bindings/spi/spi-bus.txt > > +Optional properties: > +- ti,side: specifie the channel side typo > + insertion, removal. why the line wrap? I don't understand what this property is/does. Both the name and description are a bit terse. > + > Examples: > > codec_spi: 1792a@0 { > compatible = "ti,pcm1792a"; > spi-max-frequency = <600000>; > + ti,side = <left> ^ missing ; > }; > > -- > 2.1.0 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Raphael On Fri, Nov 20, 2015 at 3:42 PM, Rob Herring <robh@kernel.org> wrote: > On Fri, Nov 20, 2015 at 11:09:16AM +0100, Raphael Poggi wrote: >> From: Raphael Poggi <poggi.raph@gmail.com> >> >> Add a binding for specify channel selection. >> >> Signed-off-by: Raphael Poggi <poggi.raph@gmail.com> >> --- >> Documentation/devicetree/bindings/sound/pcm1792a.txt | 5 +++++ >> 1 file changed, 5 insertions(+) >> can you add me in the patch-set? Michael >> diff --git a/Documentation/devicetree/bindings/sound/pcm1792a.txt b/Documentation/devicetree/bindings/sound/pcm1792a.txt >> index 970ba1e..6e87a3a 100644 >> --- a/Documentation/devicetree/bindings/sound/pcm1792a.txt >> +++ b/Documentation/devicetree/bindings/sound/pcm1792a.txt >> @@ -9,10 +9,15 @@ Required properties: >> For required properties on SPI, please consult >> Documentation/devicetree/bindings/spi/spi-bus.txt >> >> +Optional properties: >> +- ti,side: specifie the channel side > > typo > >> + insertion, removal. > > why the line wrap? > > I don't understand what this property is/does. Both the name and > description are a bit terse. > >> + >> Examples: >> >> codec_spi: 1792a@0 { >> compatible = "ti,pcm1792a"; >> spi-max-frequency = <600000>; >> + ti,side = <left> > ^ > missing ; > >> }; >> >> -- >> 2.1.0 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
diff --git a/Documentation/devicetree/bindings/sound/pcm1792a.txt b/Documentation/devicetree/bindings/sound/pcm1792a.txt index 970ba1e..6e87a3a 100644 --- a/Documentation/devicetree/bindings/sound/pcm1792a.txt +++ b/Documentation/devicetree/bindings/sound/pcm1792a.txt @@ -9,10 +9,15 @@ Required properties: For required properties on SPI, please consult Documentation/devicetree/bindings/spi/spi-bus.txt +Optional properties: +- ti,side: specifie the channel side + insertion, removal. + Examples: codec_spi: 1792a@0 { compatible = "ti,pcm1792a"; spi-max-frequency = <600000>; + ti,side = <left> };