diff mbox

[4.9] Re: [PATCH][5] Backport ISL 0.15 support

Message ID 564DE7E8.4090507@ubuntu.com
State New
Headers show

Commit Message

Matthias Klose Nov. 19, 2015, 3:16 p.m. UTC 
On 19.11.2015 09:07, Richard Biener wrote:
> On Wed, 18 Nov 2015, Matthias Klose wrote:
>
>> On 12.10.2015 12:58, Richard Biener wrote:
>>>
>>> This backports the patch to allow bootstrapping with ISL 0.15 to the
>>> GCC 5 branch (the GCC 4.9 branch will require backporting of some
>>> dependencies).
>>
>> I don't think so. 4.8 and 4.9 don't use as much ISL code as 5 does.  I had a
>> look at the backport and came up with something which is just mechanical
>> changes for the cpp conditional.
>>
>> The version check in the toplevel configure needs to be extended.  I'm
>> currently not checking non matching isl and cloog versions.
>>
>> Now build for 4.9 using ISL 0.15 and 0.14. Ok to commit to the branch?
>
> Ok.  I wonder if we have a cloog version in infrastructure that builds
> against ISL 0.1[45]?  IIRC cloog 0.18.1 doesn't.

No, that would be 0.18.4, the minimum requirement for isl 0.15.

Trying to rebuild 0.15 against 0.12.2 results in test failures (below), 
rebuilding against 0.14 doesn't show test failures.

Matthias

            S1((c0+g1-1),(c1+g2-1));
          }
        }
FAIL: ./isl/jacobi-shared.c has a problemE
diff mbox

Patch

--- ./reservoir/QR.c 2014-10-02 14:33:50.000000000 +0000
+++ cloog_temp  2015-11-19 15:12:15.844164292 +0000
@@ -1,12 +1,6 @@ 
-/* Generated from ./reservoir/QR.cloog by CLooG 0.18.1-2-g43fc508 gmp bits in 
0.07s. */
+/* Generated from ./reservoir/QR.cloog by CLooG 0.18.4-b2b4f77 gmp bits in 
0.13s. */
  if (N >= 1) {
    S1(0);
-  if ((M <= 0) && (N >= 2)) {
-    S3(0);
-    S10(0);
-    S1(1);
-    S5(0);
-  }
    if ((M >= 1) && (N == 1)) {
      for (c4=0;c4<=M-1;c4++) {
        S2(0,c4);
@@ -34,6 +28,12 @@ 
      S10(0);
      S1(1);
      S5(0);
+  }
+  if ((M <= 0) && (N >= 2)) {
+    S3(0);
+    S10(0);
+    S1(1);
+    S5(0);
    }
    for (c2=2;c2<=min(M,N-1);c2++) {
      for (c4=c2-1;c4<=N-1;c4++) {
FAIL: ./reservoir/QR.c has a problem

--- ./isl/jacobi-shared.c  2014-10-02 16:33:52.000000000 +0000
+++ cloog_temp  2015-11-19 15:12:17.260192519 +0000
@@ -3,7 +3,7 @@ 
    if ((16*floord(t0-1,16) >= -N+g1+t0+1) && (16*floord(g1+t0-3,16) >= 
-N+g1+t0+1) && (32*floord(t1-1,32) >= -N+g2+t1+1) && (32*floord(g2+t1-3,32) >= 
t1-32)) {
      for 
(c0=max(-16*floord(t0-1,16)+t0,-16*floord(g1+t0-3,16)+t0);c0<=min(32,N-g1-1);c0+=16) 
{
        for (c1=-32*floord(t1-1,32)+t1;c1<=min(32,N-g2-1);c1+=32) {
-        if (c1 >= 1) {
+        if ((c1 >= 1) && (c1 <= 32)) {