diff mbox

teach delay folding in c++ about OACC_LOOPs

Message ID 564C95C7.8090803@codesourcery.com
State New
Headers show

Commit Message

Cesar Philippidis Nov. 18, 2015, 3:14 p.m. UTC 
Jason,

Your recent delay folding patch broke libgomp.oacc-c++/loop-auto-1.c. It
looks like you forgot to handle OACC_LOOP in cp_fold_r. You probably
didn't notice this because Nathan committed his auto acc loop patch just
before you applied your patch. I'm not sure why only that test is
affected though.

Is this patch ok for trunk?

Cesar

Comments

Nathan Sidwell Nov. 18, 2015, 4:27 p.m. UTC | #1 
On 11/18/15 10:14, Cesar Philippidis wrote:
> Jason,
>
> Your recent delay folding patch broke libgomp.oacc-c++/loop-auto-1.c. It
> looks like you forgot to handle OACC_LOOP in cp_fold_r. You probably
> didn't notice this because Nathan committed his auto acc loop patch just
> before you applied your patch. I'm not sure why only that test is
> affected though.
>
> Is this patch ok for trunk?

Hey, once again you've saved me an investigation :)

I'd say this counts as obvious, so go ahead and commit.

nathan
diff mbox

Patch

2015-11-17  Cesar Philippidis  <cesar@codesourcery.com>

	gcc/cp/
	* cp-gimplify.c (cp_fold_r): Add support for OACC_LOOP.

diff --git a/gcc/cp/cp-gimplify.c b/gcc/cp/cp-gimplify.c
index 8fe9e13..99d0cfb 100644
--- a/gcc/cp/cp-gimplify.c
+++ b/gcc/cp/cp-gimplify.c
@@ -933,7 +933,8 @@  cp_fold_r (tree *stmt_p, int *walk_subtrees, void *data)
 
   code = TREE_CODE (stmt);
   if (code == OMP_FOR || code == OMP_SIMD || code == OMP_DISTRIBUTE
-      || code == OMP_TASKLOOP || code == CILK_FOR || code == CILK_SIMD)
+      || code == OMP_TASKLOOP || code == CILK_FOR || code == CILK_SIMD
+      || code == OACC_LOOP)
     {
       tree x;
       int i, n;