diff mbox

[1/6] gstreamer: add legal info

Message ID 1447850352-26299-1-git-send-email-gustavo.zacarias@free-electrons.com
State Changes Requested
Headers show

Commit Message

gustavo.zacarias@free-electrons.com Nov. 18, 2015, 12:39 p.m. UTC
From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>

Even though COPYING is LGPLv2+ some code files state v2.1+

Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
---
 package/gstreamer/gstreamer/gstreamer.mk | 2 ++
 1 file changed, 2 insertions(+)

Comments

Arnout Vandecappelle Nov. 18, 2015, 9:40 p.m. UTC | #1
On 18-11-15 13:39, gustavo.zacarias@free-electrons.com wrote:
> From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
> 
> Even though COPYING is LGPLv2+ some code files state v2.1+

 Correct.

> 
> Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
> ---
>  package/gstreamer/gstreamer/gstreamer.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/gstreamer/gstreamer/gstreamer.mk b/package/gstreamer/gstreamer/gstreamer.mk
> index 1dbd66f..156afab 100644
> --- a/package/gstreamer/gstreamer/gstreamer.mk
> +++ b/package/gstreamer/gstreamer/gstreamer.mk
> @@ -8,6 +8,8 @@ GSTREAMER_VERSION = 0.10.36
>  GSTREAMER_SOURCE = gstreamer-$(GSTREAMER_VERSION).tar.xz
>  GSTREAMER_SITE = http://gstreamer.freedesktop.org/src/gstreamer
>  GSTREAMER_INSTALL_STAGING = YES
> +GSTREAMER_LICENSE = LGPLv2+ LGPLv2.1+

 We separate these things by commas. Otherwise looks good so
 Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 I was thinking, why not simply claim it is LGPLv2.1+, given that it's + anyway?
The binaries will anyway need to be LGPLv2.1+ because there's always some 2.1
code in there. So I would actually propose

# Some files are LGPLv2+, but the whole will be 2.1+
GSTREAMER_LICENSE = LGPLv2.1+
# COPYING file is actually for v2
GSTREAMER_LICENSE_FILES = COPYING

 Regards,
 Arnout

> +GSTREAMER_LICENSE_FILES = COPYING
>  
>  # Checking if unaligned memory access works correctly cannot be done when cross
>  # compiling. For the following architectures there is no information available
>
diff mbox

Patch

diff --git a/package/gstreamer/gstreamer/gstreamer.mk b/package/gstreamer/gstreamer/gstreamer.mk
index 1dbd66f..156afab 100644
--- a/package/gstreamer/gstreamer/gstreamer.mk
+++ b/package/gstreamer/gstreamer/gstreamer.mk
@@ -8,6 +8,8 @@  GSTREAMER_VERSION = 0.10.36
 GSTREAMER_SOURCE = gstreamer-$(GSTREAMER_VERSION).tar.xz
 GSTREAMER_SITE = http://gstreamer.freedesktop.org/src/gstreamer
 GSTREAMER_INSTALL_STAGING = YES
+GSTREAMER_LICENSE = LGPLv2+ LGPLv2.1+
+GSTREAMER_LICENSE_FILES = COPYING
 
 # Checking if unaligned memory access works correctly cannot be done when cross
 # compiling. For the following architectures there is no information available