| Message ID | 1447833653-28387-2-git-send-email-clabbe.montjoie@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
Hi Corentin, On Wed, 18 Nov 2015 09:00:53 +0100, LABBE Corentin wrote: > The simple_strtoul function is marked as obsolete. > This patch replace it by kstrtou8. > > Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com> > --- > drivers/i2c/busses/i2c-taos-evm.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-taos-evm.c b/drivers/i2c/busses/i2c-taos-evm.c > index 4c7fc2d..552f127 100644 > --- a/drivers/i2c/busses/i2c-taos-evm.c > +++ b/drivers/i2c/busses/i2c-taos-evm.c > @@ -70,6 +70,7 @@ static int taos_smbus_xfer(struct i2c_adapter *adapter, u16 addr, > struct serio *serio = adapter->algo_data; > struct taos_data *taos = serio_get_drvdata(serio); > char *p; > + int err; > > /* Encode our transaction. "@" is for the device address, "$" for the > SMBus command and "#" for the data. */ > @@ -130,7 +131,14 @@ static int taos_smbus_xfer(struct i2c_adapter *adapter, u16 addr, > return 0; > } else { > if (p[0] == 'x') { > - data->byte = simple_strtol(p + 1, NULL, 16); > + /* > + * voluntary dropping error code of kstrtou8 since all "Voluntarily" or "Willingly" would be more correct. > + * error code that it could return are invalid according > + * to Documentation/i2c/fault-codes > + */ > + err = kstrtou8(p + 1, 16, &data->byte); > + if (err) > + return -EPROTO; > return 0; > } > } Thanks for the patch. Note that you don't strictly need the "err" variable as you never use its value. Reviewed-by: Jean Delvare <jdelvare@suse.de> Tested-by: Jean Delvare <jdelvare@suse.de>
On Wed, Nov 18, 2015 at 10:29:54AM +0100, Jean Delvare wrote: > Hi Corentin, > > On Wed, 18 Nov 2015 09:00:53 +0100, LABBE Corentin wrote: > > The simple_strtoul function is marked as obsolete. > > This patch replace it by kstrtou8. > > > > Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com> > > --- > > drivers/i2c/busses/i2c-taos-evm.c | 10 +++++++++- > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/i2c/busses/i2c-taos-evm.c b/drivers/i2c/busses/i2c-taos-evm.c > > index 4c7fc2d..552f127 100644 > > --- a/drivers/i2c/busses/i2c-taos-evm.c > > +++ b/drivers/i2c/busses/i2c-taos-evm.c > > @@ -70,6 +70,7 @@ static int taos_smbus_xfer(struct i2c_adapter *adapter, u16 addr, > > struct serio *serio = adapter->algo_data; > > struct taos_data *taos = serio_get_drvdata(serio); > > char *p; > > + int err; > > > > /* Encode our transaction. "@" is for the device address, "$" for the > > SMBus command and "#" for the data. */ > > @@ -130,7 +131,14 @@ static int taos_smbus_xfer(struct i2c_adapter *adapter, u16 addr, > > return 0; > > } else { > > if (p[0] == 'x') { > > - data->byte = simple_strtol(p + 1, NULL, 16); > > + /* > > + * voluntary dropping error code of kstrtou8 since all > > "Voluntarily" or "Willingly" would be more correct. > > > + * error code that it could return are invalid according > > + * to Documentation/i2c/fault-codes > > + */ > > + err = kstrtou8(p + 1, 16, &data->byte); > > + if (err) > > + return -EPROTO; > > return 0; > > } > > } > > Thanks for the patch. Note that you don't strictly need the "err" > variable as you never use its value. > > Reviewed-by: Jean Delvare <jdelvare@suse.de> > Tested-by: Jean Delvare <jdelvare@suse.de> > Thanks I will send a v3 without the err and the spell fix. Regards -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/i2c/busses/i2c-taos-evm.c b/drivers/i2c/busses/i2c-taos-evm.c index 4c7fc2d..552f127 100644 --- a/drivers/i2c/busses/i2c-taos-evm.c +++ b/drivers/i2c/busses/i2c-taos-evm.c @@ -70,6 +70,7 @@ static int taos_smbus_xfer(struct i2c_adapter *adapter, u16 addr, struct serio *serio = adapter->algo_data; struct taos_data *taos = serio_get_drvdata(serio); char *p; + int err; /* Encode our transaction. "@" is for the device address, "$" for the SMBus command and "#" for the data. */ @@ -130,7 +131,14 @@ static int taos_smbus_xfer(struct i2c_adapter *adapter, u16 addr, return 0; } else { if (p[0] == 'x') { - data->byte = simple_strtol(p + 1, NULL, 16); + /* + * voluntary dropping error code of kstrtou8 since all + * error code that it could return are invalid according + * to Documentation/i2c/fault-codes + */ + err = kstrtou8(p + 1, 16, &data->byte); + if (err) + return -EPROTO; return 0; } }
The simple_strtoul function is marked as obsolete. This patch replace it by kstrtou8. Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com> --- drivers/i2c/busses/i2c-taos-evm.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)