diff mbox

[net-next] net: encx24j600: quiet logging noise on open

Message ID 1447796551-8522-1-git-send-email-jon@ringle.org
State Changes Requested, archived
Delegated to: David Miller
Headers show

Commit Message

Jon Ringle Nov. 17, 2015, 9:42 p.m. UTC 
From: Jon Ringle <jringle@gridpoint.com>

When encx24j600 is open and closed many times due to userspace polling the
interface, the log gets noise with this log message. Change logging level
to debug

Signed-off-by: Jon Ringle <jringle@gridpoint.com>
---
 drivers/net/ethernet/microchip/encx24j600.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

David Miller Nov. 18, 2015, 6:57 p.m. UTC | #1 
From: jon@ringle.org
Date: Tue, 17 Nov 2015 16:42:31 -0500

> From: Jon Ringle <jringle@gridpoint.com>
> 
> When encx24j600 is open and closed many times due to userspace polling the
> interface, the log gets noise with this log message. Change logging level
> to debug
> 
> Signed-off-by: Jon Ringle <jringle@gridpoint.com>

This should be moved into the probe method instead, as that's where
outputting something like that belongs.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/ethernet/microchip/encx24j600.c b/drivers/net/ethernet/microchip/encx24j600.c
index bf08ce2..a6763c3 100644
--- a/drivers/net/ethernet/microchip/encx24j600.c
+++ b/drivers/net/ethernet/microchip/encx24j600.c
@@ -613,8 +613,8 @@  static int encx24j600_hw_init(struct encx24j600_priv *priv)
 		goto err_out;
 	}
 
-	netif_info(priv, drv, dev, "Silicon rev ID: 0x%02x\n",
-		   (eidled & REVID_MASK) >> REVID_SHIFT);
+	netif_dbg(priv, drv, dev, "Silicon rev ID: 0x%02x\n",
+		  (eidled & REVID_MASK) >> REVID_SHIFT);
 
 	/* PHY Leds: link status,
 	 * LEDA: Link State + collision events