From patchwork Fri Jun 4 08:42:52 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wan ZongShun X-Patchwork-Id: 54549 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-px0-f184.google.com (mail-px0-f184.google.com [209.85.212.184]) by ozlabs.org (Postfix) with ESMTP id DDDF7B7D30 for ; Fri, 4 Jun 2010 18:43:14 +1000 (EST) Received: by pxi15 with SMTP id 15sf118697pxi.11 for ; Fri, 04 Jun 2010 01:43:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:x-beenthere:received:received:received :received:received-spf:received:received:received:message-id:date :from:user-agent:mime-version:to:subject :x-original-authentication-results:x-original-sender:reply-to :precedence:mailing-list:list-id:list-post:list-help:list-archive :sender:list-subscribe:list-unsubscribe:content-type; bh=FodLTqo+vtuS6/zpSjN0qLbTgGuWJKaIsc83UFEXmss=; b=UYG6rUroVD3N5j4O4jq6MPKYlPHzhdE4qsnYp3zxet0wldG84yq2jQ2v+QIFUoyKpG RLLzsZ0UwX/mC0L1+nCYz3M9S17M483Us/M5EjJfvz5qn9KH92JMUHzRmtNofHwnnbu/ 3G+CjI1iwoe7sgc9IY0J65LNmMTNWrxDq4IEM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:message-id:date:from:user-agent :mime-version:to:subject:x-original-authentication-results :x-original-sender:reply-to:precedence:mailing-list:list-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type; b=lF7pWtXKPr7foRtRyxU10YIE/ICF5b1xUJ9QUAKDDCFlyhoeXMufaXRMKjDu7Gh6Ds 5mdyuj3y4fnvFh+n/mPdbHr23ve9HbIw7XTp2ykZ5jKvg8fycbpTbwLVYKJbWr94rtPU cLJI63Ln0hPdknrdc8QFs8MfjAMK3M4XjcmYs= Received: by 10.140.83.37 with SMTP id g37mr1111793rvb.14.1275640992654; Fri, 04 Jun 2010 01:43:12 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.141.13.11 with SMTP id q11ls5406236rvi.3.p; Fri, 04 Jun 2010 01:43:11 -0700 (PDT) Received: by 10.140.83.37 with SMTP id g37mr3681062rvb.36.1275640991083; Fri, 04 Jun 2010 01:43:11 -0700 (PDT) Received: by 10.140.83.37 with SMTP id g37mr3681061rvb.36.1275640991057; Fri, 04 Jun 2010 01:43:11 -0700 (PDT) Received: from mail-pw0-f45.google.com (mail-pw0-f45.google.com [209.85.160.45]) by gmr-mx.google.com with ESMTP id 24si161357pzk.5.2010.06.04.01.43.10; Fri, 04 Jun 2010 01:43:10 -0700 (PDT) Received-SPF: pass (google.com: domain of mcuos.com@gmail.com designates 209.85.160.45 as permitted sender) client-ip=209.85.160.45; Received: by pwj3 with SMTP id 3so523400pwj.4 for ; Fri, 04 Jun 2010 01:43:10 -0700 (PDT) Received: by 10.143.153.34 with SMTP id f34mr7919784wfo.2.1275640989837; Fri, 04 Jun 2010 01:43:09 -0700 (PDT) Received: from [192.168.1.10] ([116.226.201.224]) by mx.google.com with ESMTPS id 22sm667315pzk.5.2010.06.04.01.43.04 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 04 Jun 2010 01:43:08 -0700 (PDT) Message-ID: <4C08BC8C.4010206@gmail.com> Date: Fri, 04 Jun 2010 16:42:52 +0800 From: Wan ZongShun User-Agent: Thunderbird 2.0.0.24 (X11/20100411) MIME-Version: 1.0 To: Andrew Morton , rtc-linux , Alessandro Zummo , LKML Subject: [rtc-linux] [PATCH] rtc/m48t59: redundant condition judgement X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of mcuos.com@gmail.com designates 209.85.160.45 as permitted sender) smtp.mail=mcuos.com@gmail.com; dkim=pass (test mode) header.i=@gmail.com X-Original-Sender: mcuos.com@gmail.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , It is safe to deallocate a NULL pointer. so 'if (m48t59)' is redundant condition judgement, so I remove it. Signed-off-by: Wan ZongShun --- drivers/rtc/rtc-m48t59.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/rtc/rtc-m48t59.c b/drivers/rtc/rtc-m48t59.c index be8359f..0b66455 100644 --- a/drivers/rtc/rtc-m48t59.c +++ b/drivers/rtc/rtc-m48t59.c @@ -506,7 +506,6 @@ out: free_irq(m48t59->irq, &pdev->dev); if (m48t59->ioaddr) iounmap(m48t59->ioaddr); - if (m48t59) kfree(m48t59); return ret; }