From patchwork Fri Jun 4 06:24:21 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tobias Klauser X-Patchwork-Id: 54539 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 75DE2B7D64 for ; Fri, 4 Jun 2010 16:24:49 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752387Ab0FDGYb (ORCPT ); Fri, 4 Jun 2010 02:24:31 -0400 Received: from mx1.zhaw.ch ([160.85.104.50]:56709 "EHLO mx1.zhaw.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752149Ab0FDGY1 (ORCPT ); Fri, 4 Jun 2010 02:24:27 -0400 Received: from mx1.zhaw.ch (localhost [127.0.0.1]) by localhost (Postfix) with SMTP id D4CAA4D0; Fri, 4 Jun 2010 08:23:43 +0200 (CEST) Received: from localhost.localdomain (inst-232.208.zhaw.ch [160.85.232.208]) by mx1.zhaw.ch (Postfix) with ESMTP id 16A514AC; Fri, 4 Jun 2010 08:23:43 +0200 (CEST) From: Tobias Klauser To: kristoffer@gaisler.com, davem@davemloft.net, netdev@vger.kernel.org Cc: Tobias Klauser Subject: [PATCH] greth: Remove unnecessary memset of napi member in netdev private data Date: Fri, 4 Jun 2010 08:24:21 +0200 Message-Id: <1275632661-16406-1-git-send-email-tklauser@distanz.ch> X-Mailer: git-send-email 1.6.3.3 X-PMX-Version: 5.5.9.395186, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2010.6.4.60915 X-PerlMx-Spam: Gauge=IIIIIIII, Probability=8%, Report=' BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_700_799 0, TO_NO_NAME 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __MIME_TEXT_ONLY 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NO_PATH 0, __URI_NO_WWW 0, __URI_NS ' Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The memory for the private data is allocated using kzalloc in alloc_etherdev (or alloc_netdev_mq respectively) so there is no need to set the napi member to 0 explicitely. Signed-off-by: Tobias Klauser --- drivers/net/greth.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/greth.c b/drivers/net/greth.c index 3a029d0..4d09eab 100644 --- a/drivers/net/greth.c +++ b/drivers/net/greth.c @@ -1555,7 +1555,6 @@ static int __devinit greth_of_probe(struct of_device *ofdev, const struct of_dev } /* setup NAPI */ - memset(&greth->napi, 0, sizeof(greth->napi)); netif_napi_add(dev, &greth->napi, greth_poll, 64); return 0;