[v8,3/5] nvdimm acpi: build ACPI NFIT table

NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT)

Currently, we only support PMEM mode. Each device has 3 structures:
- SPA structure, defines the PMEM region info

- MEM DEV structure, it has the @handle which is used to associate specified
  ACPI NVDIMM  device we will introduce in later patch.
  Also we can happily ignored the memory device's interleave, the real
  nvdimm hardware access is hidden behind host

- DCR structure, it defines vendor ID used to associate specified vendor
  nvdimm driver. Since we only implement PMEM mode this time, Command
  window and Data window are not needed

The NVDIMM functionality is controlled by the parameter, 'nvdimm-support',
is introduced for PIIX4_PM and ICH9-LPC, it is true on default and it is
false on 2.4 and its earlier version to keep compatibility

Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
---
 default-configs/i386-softmmu.mak   |   1 +
 default-configs/x86_64-softmmu.mak |   1 +
 hw/acpi/Makefile.objs              |   1 +
 hw/acpi/ich9.c                     |  19 ++
 hw/acpi/nvdimm.c                   | 382 +++++++++++++++++++++++++++++++++++++
 hw/acpi/piix4.c                    |   4 +
 hw/i386/acpi-build.c               |   6 +
 include/hw/acpi/ich9.h             |   3 +
 include/hw/i386/pc.h               |  12 +-
 include/hw/mem/nvdimm.h            |  12 ++
 10 files changed, 440 insertions(+), 1 deletion(-)
 create mode 100644 hw/acpi/nvdimm.c

On Mon, Nov 16, 2015 at 06:51:01PM +0800, Xiao Guangrong wrote:
> NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT)
> 
> Currently, we only support PMEM mode. Each device has 3 structures:
> - SPA structure, defines the PMEM region info
> 
> - MEM DEV structure, it has the @handle which is used to associate specified
>   ACPI NVDIMM  device we will introduce in later patch.
>   Also we can happily ignored the memory device's interleave, the real
>   nvdimm hardware access is hidden behind host
> 
> - DCR structure, it defines vendor ID used to associate specified vendor
>   nvdimm driver. Since we only implement PMEM mode this time, Command
>   window and Data window are not needed
> 
> The NVDIMM functionality is controlled by the parameter, 'nvdimm-support',
> is introduced for PIIX4_PM and ICH9-LPC, it is true on default and it is
> false on 2.4 and its earlier version to keep compatibility

Will need to make it false on 2.5 too.

Isn't there a device that needs to be created for this
to work?  It would be cleaned to just key off
the device presence, then we don't need compat gunk,
and further, people not using it don't get a
bunch of unused AML.


> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
> ---
>  default-configs/i386-softmmu.mak   |   1 +
>  default-configs/x86_64-softmmu.mak |   1 +
>  hw/acpi/Makefile.objs              |   1 +
>  hw/acpi/ich9.c                     |  19 ++
>  hw/acpi/nvdimm.c                   | 382 +++++++++++++++++++++++++++++++++++++
>  hw/acpi/piix4.c                    |   4 +
>  hw/i386/acpi-build.c               |   6 +
>  include/hw/acpi/ich9.h             |   3 +
>  include/hw/i386/pc.h               |  12 +-
>  include/hw/mem/nvdimm.h            |  12 ++
>  10 files changed, 440 insertions(+), 1 deletion(-)
>  create mode 100644 hw/acpi/nvdimm.c
> 
> diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmmu.mak
> index 4c79d3b..53fb517 100644
> --- a/default-configs/i386-softmmu.mak
> +++ b/default-configs/i386-softmmu.mak
> @@ -47,6 +47,7 @@ CONFIG_IOAPIC=y
>  CONFIG_PVPANIC=y
>  CONFIG_MEM_HOTPLUG=y
>  CONFIG_NVDIMM=y
> +CONFIG_ACPI_NVDIMM=y
>  CONFIG_XIO3130=y
>  CONFIG_IOH3420=y
>  CONFIG_I82801B11=y
> diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/x86_64-softmmu.mak
> index e42d2fc..766c27c 100644
> --- a/default-configs/x86_64-softmmu.mak
> +++ b/default-configs/x86_64-softmmu.mak
> @@ -47,6 +47,7 @@ CONFIG_IOAPIC=y
>  CONFIG_PVPANIC=y
>  CONFIG_MEM_HOTPLUG=y
>  CONFIG_NVDIMM=y
> +CONFIG_ACPI_NVDIMM=y
>  CONFIG_XIO3130=y
>  CONFIG_IOH3420=y
>  CONFIG_I82801B11=y
> diff --git a/hw/acpi/Makefile.objs b/hw/acpi/Makefile.objs
> index 7d3230c..095597f 100644
> --- a/hw/acpi/Makefile.objs
> +++ b/hw/acpi/Makefile.objs
> @@ -2,6 +2,7 @@ common-obj-$(CONFIG_ACPI_X86) += core.o piix4.o pcihp.o
>  common-obj-$(CONFIG_ACPI_X86_ICH) += ich9.o tco.o
>  common-obj-$(CONFIG_ACPI_CPU_HOTPLUG) += cpu_hotplug.o
>  common-obj-$(CONFIG_ACPI_MEMORY_HOTPLUG) += memory_hotplug.o
> +common-obj-$(CONFIG_ACPI_NVDIMM) += nvdimm.o
>  common-obj-$(CONFIG_ACPI) += acpi_interface.o
>  common-obj-$(CONFIG_ACPI) += bios-linker-loader.o
>  common-obj-$(CONFIG_ACPI) += aml-build.o
> diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
> index 1c7fcfa..275796f 100644
> --- a/hw/acpi/ich9.c
> +++ b/hw/acpi/ich9.c
> @@ -307,6 +307,20 @@ static void ich9_pm_set_memory_hotplug_support(Object *obj, bool value,
>      s->pm.acpi_memory_hotplug.is_enabled = value;
>  }
>  
> +static bool ich9_pm_get_nvdimm_support(Object *obj, Error **errp)
> +{
> +    ICH9LPCState *s = ICH9_LPC_DEVICE(obj);
> +
> +    return s->pm.nvdimm_acpi_state.is_enabled;
> +}
> +
> +static void ich9_pm_set_nvdimm_support(Object *obj, bool value, Error **errp)
> +{
> +    ICH9LPCState *s = ICH9_LPC_DEVICE(obj);
> +
> +    s->pm.nvdimm_acpi_state.is_enabled = value;
> +}
> +
>  static void ich9_pm_get_disable_s3(Object *obj, Visitor *v,
>                                     void *opaque, const char *name,
>                                     Error **errp)
> @@ -404,6 +418,7 @@ void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm, Error **errp)
>  {
>      static const uint32_t gpe0_len = ICH9_PMIO_GPE0_LEN;
>      pm->acpi_memory_hotplug.is_enabled = true;
> +    pm->nvdimm_acpi_state.is_enabled = true;
>      pm->disable_s3 = 0;
>      pm->disable_s4 = 0;
>      pm->s4_val = 2;
> @@ -419,6 +434,10 @@ void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm, Error **errp)
>                               ich9_pm_get_memory_hotplug_support,
>                               ich9_pm_set_memory_hotplug_support,
>                               NULL);
> +    object_property_add_bool(obj, "nvdimm-support",
> +                             ich9_pm_get_nvdimm_support,
> +                             ich9_pm_set_nvdimm_support,
> +                             NULL);
>      object_property_add(obj, ACPI_PM_PROP_S3_DISABLED, "uint8",
>                          ich9_pm_get_disable_s3,
>                          ich9_pm_set_disable_s3,
> diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
> new file mode 100644
> index 0000000..98c004d
> --- /dev/null
> +++ b/hw/acpi/nvdimm.c
> @@ -0,0 +1,382 @@
> +/*
> + * NVDIMM ACPI Implementation
> + *
> + * Copyright(C) 2015 Intel Corporation.
> + *
> + * Author:
> + *  Xiao Guangrong <guangrong.xiao@linux.intel.com>
> + *
> + * NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT)
> + * and the DSM specification can be found at:
> + *       http://pmem.io/documents/NVDIMM_DSM_Interface_Example.pdf
> + *
> + * Currently, it only supports PMEM Virtualization.
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with this library; if not, see <http://www.gnu.org/licenses/>
> + */
> +
> +#include "hw/acpi/acpi.h"
> +#include "hw/acpi/aml-build.h"
> +#include "hw/mem/nvdimm.h"
> +
> +static int nvdimm_plugged_device_list(Object *obj, void *opaque)
> +{
> +    GSList **list = opaque;
> +
> +    if (object_dynamic_cast(obj, TYPE_NVDIMM)) {
> +        DeviceState *dev = DEVICE(obj);
> +
> +        if (dev->realized) { /* only realized NVDIMMs matter */
> +            *list = g_slist_append(*list, DEVICE(obj));
> +        }
> +    }
> +
> +    object_child_foreach(obj, nvdimm_plugged_device_list, opaque);
> +    return 0;
> +}
> +
> +/*
> + * inquire plugged NVDIMM devices and link them into the list which is
> + * returned to the caller.
> + *
> + * Note: it is the caller's responsibility to free the list to avoid
> + * memory leak.
> + */
> +static GSList *nvdimm_get_plugged_device_list(void)
> +{
> +    GSList *list = NULL;
> +
> +    object_child_foreach(qdev_get_machine(), nvdimm_plugged_device_list,
> +                         &list);
> +    return list;
> +}
> +
> +#define NVDIMM_UUID_LE(a, b, c, d0, d1, d2, d3, d4, d5, d6, d7)             \
> +   { (a) & 0xff, ((a) >> 8) & 0xff, ((a) >> 16) & 0xff, ((a) >> 24) & 0xff, \
> +     (b) & 0xff, ((b) >> 8) & 0xff, (c) & 0xff, ((c) >> 8) & 0xff,          \
> +     (d0), (d1), (d2), (d3), (d4), (d5), (d6), (d7) }
> +
> +/*
> + * define Byte Addressable Persistent Memory (PM) Region according to
> + * ACPI 6.0: 5.2.25.1 System Physical Address Range Structure.
> + */
> +static const uint8_t nvdimm_nfit_spa_uuid[] =
> +      NVDIMM_UUID_LE(0x66f0d379, 0xb4f3, 0x4074, 0xac, 0x43, 0x0d, 0x33,
> +                     0x18, 0xb7, 0x8c, 0xdb);
> +
> +/*
> + * NVDIMM Firmware Interface Table
> + * @signature: "NFIT"
> + *
> + * It provides information that allows OSPM to enumerate NVDIMM present in
> + * the platform and associate system physical address ranges created by the
> + * NVDIMMs.
> + *
> + * It is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT)
> + */
> +struct NvdimmNfitHeader {
> +    ACPI_TABLE_HEADER_DEF
> +    uint32_t reserved;
> +} QEMU_PACKED;
> +typedef struct NvdimmNfitHeader NvdimmNfitHeader;
> +
> +/*
> + * define NFIT structures according to ACPI 6.0: 5.2.25 NVDIMM Firmware
> + * Interface Table (NFIT).
> + */
> +
> +/*
> + * System Physical Address Range Structure
> + *
> + * It describes the system physical address ranges occupied by NVDIMMs and
> + * the types of the regions.
> + */
> +struct NvdimmNfitSpa {
> +    uint16_t type;
> +    uint16_t length;
> +    uint16_t spa_index;
> +    uint16_t flags;
> +    uint32_t reserved;
> +    uint32_t proximity_domain;
> +    uint8_t type_guid[16];
> +    uint64_t spa_base;
> +    uint64_t spa_length;
> +    uint64_t mem_attr;
> +} QEMU_PACKED;
> +typedef struct NvdimmNfitSpa NvdimmNfitSpa;
> +
> +/*
> + * Memory Device to System Physical Address Range Mapping Structure
> + *
> + * It enables identifying each NVDIMM region and the corresponding SPA
> + * describing the memory interleave
> + */
> +struct NvdimmNfitMemDev {
> +    uint16_t type;
> +    uint16_t length;
> +    uint32_t nfit_handle;
> +    uint16_t phys_id;
> +    uint16_t region_id;
> +    uint16_t spa_index;
> +    uint16_t dcr_index;
> +    uint64_t region_len;
> +    uint64_t region_offset;
> +    uint64_t region_dpa;
> +    uint16_t interleave_index;
> +    uint16_t interleave_ways;
> +    uint16_t flags;
> +    uint16_t reserved;
> +} QEMU_PACKED;
> +typedef struct NvdimmNfitMemDev NvdimmNfitMemDev;
> +
> +/*
> + * NVDIMM Control Region Structure
> + *
> + * It describes the NVDIMM and if applicable, Block Control Window.
> + */
> +struct NvdimmNfitControlRegion {
> +    uint16_t type;
> +    uint16_t length;
> +    uint16_t dcr_index;
> +    uint16_t vendor_id;
> +    uint16_t device_id;
> +    uint16_t revision_id;
> +    uint16_t sub_vendor_id;
> +    uint16_t sub_device_id;
> +    uint16_t sub_revision_id;
> +    uint8_t reserved[6];
> +    uint32_t serial_number;
> +    uint16_t fic;
> +    uint16_t num_bcw;
> +    uint64_t bcw_size;
> +    uint64_t cmd_offset;
> +    uint64_t cmd_size;
> +    uint64_t status_offset;
> +    uint64_t status_size;
> +    uint16_t flags;
> +    uint8_t reserved2[6];
> +} QEMU_PACKED;
> +typedef struct NvdimmNfitControlRegion NvdimmNfitControlRegion;
> +
> +/*
> + * Module serial number is a unique number for each device. We use the
> + * slot id of NVDIMM device to generate this number so that each device
> + * associates with a different number.
> + *
> + * 0x123456 is a magic number we arbitrarily chose.
> + */
> +static uint32_t nvdimm_slot_to_sn(int slot)
> +{
> +    return 0x123456 + slot;
> +}
> +
> +/*
> + * handle is used to uniquely associate nfit_memdev structure with NVDIMM
> + * ACPI device - nfit_memdev.nfit_handle matches with the value returned
> + * by ACPI device _ADR method.
> + *
> + * We generate the handle with the slot id of NVDIMM device and reserve
> + * 0 for NVDIMM root device.
> + */
> +static uint32_t nvdimm_slot_to_handle(int slot)
> +{
> +    return slot + 1;
> +}
> +
> +/*
> + * index uniquely identifies the structure, 0 is reserved which indicates
> + * that the structure is not valid or the associated structure is not
> + * present.
> + *
> + * Each NVDIMM device needs two indexes, one for nfit_spa and another for
> + * nfit_dc which are generated by the slot id of NVDIMM device.
> + */
> +static uint16_t nvdimm_slot_to_spa_index(int slot)
> +{
> +    return (slot + 1) << 1;
> +}
> +
> +/* See the comments of nvdimm_slot_to_spa_index(). */
> +static uint32_t nvdimm_slot_to_dcr_index(int slot)
> +{
> +    return nvdimm_slot_to_spa_index(slot) + 1;
> +}
> +
> +/* ACPI 6.0: 5.2.25.1 System Physical Address Range Structure */
> +static void
> +nvdimm_build_structure_spa(GArray *structures, DeviceState *dev)
> +{
> +    NvdimmNfitSpa *nfit_spa;
> +    uint64_t addr = object_property_get_int(OBJECT(dev), PC_DIMM_ADDR_PROP,
> +                                            NULL);
> +    uint64_t size = object_property_get_int(OBJECT(dev), PC_DIMM_SIZE_PROP,
> +                                            NULL);
> +    uint32_t node = object_property_get_int(OBJECT(dev), PC_DIMM_NODE_PROP,
> +                                            NULL);
> +    int slot = object_property_get_int(OBJECT(dev), PC_DIMM_SLOT_PROP,
> +                                            NULL);
> +
> +    nfit_spa = acpi_data_push(structures, sizeof(*nfit_spa));
> +
> +    nfit_spa->type = cpu_to_le16(0 /* System Physical Address Range
> +                                      Structure */);
> +    nfit_spa->length = cpu_to_le16(sizeof(*nfit_spa));
> +    nfit_spa->spa_index = cpu_to_le16(nvdimm_slot_to_spa_index(slot));
> +
> +    /*
> +     * Control region is strict as all the device info, such as SN, index,
> +     * is associated with slot id.
> +     */
> +    nfit_spa->flags = cpu_to_le16(1 /* Control region is strictly for
> +                                       management during hot add/online
> +                                       operation */ |
> +                                  2 /* Data in Proximity Domain field is
> +                                       valid*/);
> +
> +    /* NUMA node. */
> +    nfit_spa->proximity_domain = cpu_to_le32(node);
> +    /* the region reported as PMEM. */
> +    memcpy(nfit_spa->type_guid, nvdimm_nfit_spa_uuid,
> +           sizeof(nvdimm_nfit_spa_uuid));
> +
> +    nfit_spa->spa_base = cpu_to_le64(addr);
> +    nfit_spa->spa_length = cpu_to_le64(size);
> +
> +    /* It is the PMEM and can be cached as writeback. */
> +    nfit_spa->mem_attr = cpu_to_le64(0x8ULL /* EFI_MEMORY_WB */ |
> +                                     0x8000ULL /* EFI_MEMORY_NV */);
> +}
> +
> +/*
> + * ACPI 6.0: 5.2.25.2 Memory Device to System Physical Address Range Mapping
> + * Structure
> + */
> +static void
> +nvdimm_build_structure_memdev(GArray *structures, DeviceState *dev)
> +{
> +    NvdimmNfitMemDev *nfit_memdev;
> +    uint64_t addr = object_property_get_int(OBJECT(dev), PC_DIMM_ADDR_PROP,
> +                                            NULL);
> +    uint64_t size = object_property_get_int(OBJECT(dev), PC_DIMM_SIZE_PROP,
> +                                            NULL);
> +    int slot = object_property_get_int(OBJECT(dev), PC_DIMM_SLOT_PROP,
> +                                            NULL);
> +    uint32_t handle = nvdimm_slot_to_handle(slot);
> +
> +    nfit_memdev = acpi_data_push(structures, sizeof(*nfit_memdev));
> +
> +    nfit_memdev->type = cpu_to_le16(1 /* Memory Device to System Address
> +                                         Range Map Structure*/);
> +    nfit_memdev->length = cpu_to_le16(sizeof(*nfit_memdev));
> +    nfit_memdev->nfit_handle = cpu_to_le32(handle);
> +
> +    /*
> +     * associate memory device with System Physical Address Range
> +     * Structure.
> +     */
> +    nfit_memdev->spa_index = cpu_to_le16(nvdimm_slot_to_spa_index(slot));
> +    /* associate memory device with Control Region Structure. */
> +    nfit_memdev->dcr_index = cpu_to_le16(nvdimm_slot_to_dcr_index(slot));
> +
> +    /* The memory region on the device. */
> +    nfit_memdev->region_len = cpu_to_le64(size);
> +    nfit_memdev->region_dpa = cpu_to_le64(addr);
> +
> +    /* Only one interleave for PMEM. */
> +    nfit_memdev->interleave_ways = cpu_to_le16(1);
> +}
> +
> +/*
> + * ACPI 6.0: 5.2.25.5 NVDIMM Control Region Structure.
> + */
> +static void nvdimm_build_structure_dcr(GArray *structures, DeviceState *dev)
> +{
> +    NvdimmNfitControlRegion *nfit_dcr;
> +    int slot = object_property_get_int(OBJECT(dev), PC_DIMM_SLOT_PROP,
> +                                       NULL);
> +    uint32_t sn = nvdimm_slot_to_sn(slot);
> +
> +    nfit_dcr = acpi_data_push(structures, sizeof(*nfit_dcr));
> +
> +    nfit_dcr->type = cpu_to_le16(4 /* NVDIMM Control Region Structure */);
> +    nfit_dcr->length = cpu_to_le16(sizeof(*nfit_dcr));
> +    nfit_dcr->dcr_index = cpu_to_le16(nvdimm_slot_to_dcr_index(slot));
> +
> +    /* vendor: Intel. */
> +    nfit_dcr->vendor_id = cpu_to_le16(0x8086);
> +    nfit_dcr->device_id = cpu_to_le16(1);
> +
> +    /* The _DSM method is following Intel's DSM specification. */
> +    nfit_dcr->revision_id = cpu_to_le16(1 /* Current Revision supported
> +                                             in ACPI 6.0 is 1. */);
> +    nfit_dcr->serial_number = cpu_to_le32(sn);
> +    nfit_dcr->fic = cpu_to_le16(0x201 /* Format Interface Code. See Chapter
> +                                         2: NVDIMM Device Specific Method
> +                                         (DSM) in DSM Spec Rev1.*/);
> +}
> +
> +static GArray *nvdimm_build_device_structure(GSList *device_list)
> +{
> +    GArray *structures = g_array_new(false, true /* clear */, 1);
> +
> +    for (; device_list; device_list = device_list->next) {
> +        DeviceState *dev = device_list->data;
> +
> +        /* build System Physical Address Range Structure. */
> +        nvdimm_build_structure_spa(structures, dev);
> +
> +        /*
> +         * build Memory Device to System Physical Address Range Mapping
> +         * Structure.
> +         */
> +        nvdimm_build_structure_memdev(structures, dev);
> +
> +        /* build NVDIMM Control Region Structure. */
> +        nvdimm_build_structure_dcr(structures, dev);
> +    }
> +
> +    return structures;
> +}
> +
> +static void nvdimm_build_nfit(GSList *device_list, GArray *table_offsets,
> +                              GArray *table_data, GArray *linker)
> +{
> +    GArray *structures = nvdimm_build_device_structure(device_list);
> +    void *header;
> +
> +    acpi_add_table(table_offsets, table_data);
> +
> +    /* NFIT header. */
> +    header = acpi_data_push(table_data, sizeof(NvdimmNfitHeader));
> +    /* NVDIMM device structures. */
> +    g_array_append_vals(table_data, structures->data, structures->len);
> +
> +    build_header(linker, table_data, header, "NFIT",
> +                 sizeof(NvdimmNfitHeader) + structures->len, 1, NULL);
> +    g_array_free(structures, true);
> +}
> +
> +void nvdimm_build_acpi(GArray *table_offsets, GArray *table_data,
> +                       GArray *linker)
> +{
> +    GSList *device_list;
> +
> +    /* no NVDIMM device is plugged. */
> +    device_list = nvdimm_get_plugged_device_list();
> +    if (!device_list) {
> +        return;
> +    }
> +    nvdimm_build_nfit(device_list, table_offsets, table_data, linker);
> +    g_slist_free(device_list);
> +}
> diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
> index 2cd2fee..33e24cf 100644
> --- a/hw/acpi/piix4.c
> +++ b/hw/acpi/piix4.c
> @@ -34,6 +34,7 @@
>  #include "hw/acpi/cpu_hotplug.h"
>  #include "hw/hotplug.h"
>  #include "hw/mem/pc-dimm.h"
> +#include "hw/mem/nvdimm.h"
>  #include "hw/acpi/memory_hotplug.h"
>  #include "hw/acpi/acpi_dev_interface.h"
>  #include "hw/xen/xen.h"
> @@ -86,6 +87,7 @@ typedef struct PIIX4PMState {
>      AcpiCpuHotplug gpe_cpu;
>  
>      MemHotplugState acpi_memory_hotplug;
> +    NVDIMMAcpiState nvdimm_acpi_state;
>  } PIIX4PMState;
>  
>  #define TYPE_PIIX4_PM "PIIX4_PM"
> @@ -592,6 +594,8 @@ static Property piix4_pm_properties[] = {
>                       use_acpi_pci_hotplug, true),
>      DEFINE_PROP_BOOL("memory-hotplug-support", PIIX4PMState,
>                       acpi_memory_hotplug.is_enabled, true),
> +    DEFINE_PROP_BOOL("nvdimm-support", PIIX4PMState,
> +                     nvdimm_acpi_state.is_enabled, true),
>      DEFINE_PROP_END_OF_LIST(),
>  };
>  
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 215b58c..30ba594 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -90,6 +90,7 @@ typedef struct AcpiPmInfo {
>      bool s3_disabled;
>      bool s4_disabled;
>      bool pcihp_bridge_en;
> +    bool nvdimm_support;
>      uint8_t s4_val;
>      uint16_t sci_int;
>      uint8_t acpi_enable_cmd;
> @@ -231,6 +232,7 @@ static void acpi_get_pm_info(AcpiPmInfo *pm)
>      pm->pcihp_bridge_en =
>          object_property_get_bool(obj, "acpi-pci-hotplug-with-bridge-support",
>                                   NULL);
> +    pm->nvdimm_support = object_property_get_bool(obj, "nvdimm-support", NULL);
>  }
>  
>  static void acpi_get_misc_info(AcpiMiscInfo *info)
> @@ -1742,6 +1744,10 @@ void acpi_build(PcGuestInfo *guest_info, AcpiBuildTables *tables)
>          build_dmar_q35(tables_blob, tables->linker);
>      }
>  
> +    if (pm.nvdimm_support) {
> +        nvdimm_build_acpi(table_offsets, tables_blob, tables->linker);
> +    }
> +
>      /* Add tables supplied by user (if any) */
>      for (u = acpi_table_first(); u; u = acpi_table_next(u)) {
>          unsigned len = acpi_table_len(u);
> diff --git a/include/hw/acpi/ich9.h b/include/hw/acpi/ich9.h
> index 345fd8d..2c6f350 100644
> --- a/include/hw/acpi/ich9.h
> +++ b/include/hw/acpi/ich9.h
> @@ -26,6 +26,7 @@
>  #include "hw/acpi/memory_hotplug.h"
>  #include "hw/acpi/acpi_dev_interface.h"
>  #include "hw/acpi/tco.h"
> +#include "hw/mem/nvdimm.h"
>  
>  typedef struct ICH9LPCPMRegs {
>      /*
> @@ -52,6 +53,8 @@ typedef struct ICH9LPCPMRegs {
>  
>      MemHotplugState acpi_memory_hotplug;
>  
> +    NVDIMMAcpiState nvdimm_acpi_state;
> +
>      uint8_t disable_s3;
>      uint8_t disable_s4;
>      uint8_t s4_val;
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 4bbc0ff..9c9576b 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -347,7 +347,17 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
>              .driver   = "qemu32" "-" TYPE_X86_CPU,\
>              .property = "popcnt",\
>              .value    = "on",\
> -        },
> +        },\
> +        {\
> +            .driver   = "PIIX4_PM",\
> +            .property = "nvdimm-support",\
> +            .value    = "off",\
> +        },\
> +        {\
> +            .driver   = "ICH9-LPC",\
> +            .property = "nvdimm-support",\
> +            .value    = "off",\
> +       },
>  
>  #define PC_COMPAT_2_3 \
>          PC_COMPAT_2_4 \
> diff --git a/include/hw/mem/nvdimm.h b/include/hw/mem/nvdimm.h
> index dbfa8d6..6c29fff 100644
> --- a/include/hw/mem/nvdimm.h
> +++ b/include/hw/mem/nvdimm.h
> @@ -26,4 +26,16 @@
>  #include "hw/mem/pc-dimm.h"
>  
>  #define TYPE_NVDIMM      "nvdimm"
> +
> +/*
> + * AcpiNVDIMMState:
> + * @is_enabled: detect if NVDIMM support is enabled.
> + */
> +struct NVDIMMAcpiState {
> +    bool is_enabled;
> +};
> +typedef struct NVDIMMAcpiState NVDIMMAcpiState;
> +
> +void nvdimm_build_acpi(GArray *table_offsets, GArray *table_data,
> +                       GArray *linker);
>  #endif
> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

On 11/30/2015 06:30 PM, Michael S. Tsirkin wrote:
> On Mon, Nov 16, 2015 at 06:51:01PM +0800, Xiao Guangrong wrote:
>> NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT)
>>
>> Currently, we only support PMEM mode. Each device has 3 structures:
>> - SPA structure, defines the PMEM region info
>>
>> - MEM DEV structure, it has the @handle which is used to associate specified
>>    ACPI NVDIMM  device we will introduce in later patch.
>>    Also we can happily ignored the memory device's interleave, the real
>>    nvdimm hardware access is hidden behind host
>>
>> - DCR structure, it defines vendor ID used to associate specified vendor
>>    nvdimm driver. Since we only implement PMEM mode this time, Command
>>    window and Data window are not needed
>>
>> The NVDIMM functionality is controlled by the parameter, 'nvdimm-support',
>> is introduced for PIIX4_PM and ICH9-LPC, it is true on default and it is
>> false on 2.4 and its earlier version to keep compatibility
>
> Will need to make it false on 2.5 too.
>

Yes, 2.5 have been released now, it need to be updated. :)

> Isn't there a device that needs to be created for this
> to work?  It would be cleaned to just key off

Yes. But no nvdimm device/NFIT exists if no nvdimm device is
specified by QEMU command line.

> the device presence, then we don't need compat gunk,
> and further, people not using it don't get a
> bunch of unused AML.

I am okay to make it off on default.