diff mbox

[Vivid,SRU] be2net: log link status

Message ID 1447705405-16476-1-git-send-email-tim.gardner@canonical.com
State New
Headers show

Commit Message

Tim Gardner Nov. 16, 2015, 8:23 p.m. UTC 
From: Ivan Vecera <ivecera@redhat.com>

BugLink: http://bugs.launchpad.net/bugs/1513980

The driver unlike other drivers does not log link state changes. It's
better for an user when asynchronous link states are logged to the system
log.

v3: Changes from v2 discarded as "not necessary"

Cc: Sathya Perla <sathya.perla@emulex.com>
Cc: Subbu Seetharaman <subbu.seetharaman@emulex.com>
Cc: Ajit Khaparde <ajit.khaparde@emulex.com>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 18824894dbec3eb2202fc92d52a0c8bd27c8a63f)
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
 drivers/net/ethernet/emulex/benet/be_main.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Seth Forshee Nov. 17, 2015, 10:26 p.m. UTC | #1 
On Mon, Nov 16, 2015 at 01:23:25PM -0700, tim.gardner@canonical.com wrote:
> From: Ivan Vecera <ivecera@redhat.com>
> 
> BugLink: http://bugs.launchpad.net/bugs/1513980
> 
> The driver unlike other drivers does not log link state changes. It's
> better for an user when asynchronous link states are logged to the system
> log.
> 
> v3: Changes from v2 discarded as "not necessary"
> 
> Cc: Sathya Perla <sathya.perla@emulex.com>
> Cc: Subbu Seetharaman <subbu.seetharaman@emulex.com>
> Cc: Ajit Khaparde <ajit.khaparde@emulex.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> (cherry picked from commit 18824894dbec3eb2202fc92d52a0c8bd27c8a63f)
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>

Clean cherry pick, straightforward, and low regression potential. Ack.
Stefan Bader Nov. 19, 2015, 12:21 p.m. UTC | #2 
Looks mostly harmless...
Kamal Mostafa Nov. 19, 2015, 10:16 p.m. UTC | #3
diff mbox

Patch

diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index 5389b3b..f088dc5 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -660,6 +660,8 @@  void be_link_status_update(struct be_adapter *adapter, u8 link_status)
 		netif_carrier_on(netdev);
 	else
 		netif_carrier_off(netdev);
+
+	netdev_info(netdev, "Link is %s\n", link_status ? "Up" : "Down");
 }
 
 static void be_tx_stats_update(struct be_tx_obj *txo,