| Message ID | 1447672551-2930-2-git-send-email-ariel@vanguardiasur.com.ar |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
On 16 November 2015 at 04:15, Ariel D'Alessandro <ariel@vanguardiasur.com.ar> wrote: > No UART driver was specified in defconfig, thus > DEBUG_UART_ALTERA_JTAGUART was incorrectly selected by default since > commit 220e8021af96741bd7149ca9895e1f0c8a38d0bb added a new Altera UART > driver. > > Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar> > --- > configs/chromebook_jerry_defconfig | 1 + > configs/firefly-rk3288_defconfig | 3 ++- > 2 files changed, 3 insertions(+), 1 deletion(-) Acked-by: Simon Glass <sjg@chromium.org>
On 16 November 2015 at 14:08, Simon Glass <sjg@chromium.org> wrote: > On 16 November 2015 at 04:15, Ariel D'Alessandro > <ariel@vanguardiasur.com.ar> wrote: >> No UART driver was specified in defconfig, thus >> DEBUG_UART_ALTERA_JTAGUART was incorrectly selected by default since >> commit 220e8021af96741bd7149ca9895e1f0c8a38d0bb added a new Altera UART >> driver. >> >> Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar> >> --- >> configs/chromebook_jerry_defconfig | 1 + >> configs/firefly-rk3288_defconfig | 3 ++- >> 2 files changed, 3 insertions(+), 1 deletion(-) > > Acked-by: Simon Glass <sjg@chromium.org> Applied to u-boot-rockchip, thanks!
On Mon, Nov 16, 2015 at 08:15:50AM -0300, Ariel D'Alessandro wrote: > No UART driver was specified in defconfig, thus > DEBUG_UART_ALTERA_JTAGUART was incorrectly selected by default since > commit 220e8021af96741bd7149ca9895e1f0c8a38d0bb added a new Altera UART > driver. > > Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar> > Acked-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/configs/chromebook_jerry_defconfig b/configs/chromebook_jerry_defconfig index 3ded392..5d39a9a 100644 --- a/configs/chromebook_jerry_defconfig +++ b/configs/chromebook_jerry_defconfig @@ -33,6 +33,7 @@ CONFIG_REGULATOR_ACT8846=y CONFIG_RAM=y CONFIG_SPL_RAM=y CONFIG_DEBUG_UART=y +CONFIG_DEBUG_UART_NS16550=y CONFIG_DEBUG_UART_BASE=0xff690000 CONFIG_DEBUG_UART_CLOCK=24000000 CONFIG_DEBUG_UART_SHIFT=2 diff --git a/configs/firefly-rk3288_defconfig b/configs/firefly-rk3288_defconfig index edb2db2..6f42377 100644 --- a/configs/firefly-rk3288_defconfig +++ b/configs/firefly-rk3288_defconfig @@ -3,9 +3,9 @@ CONFIG_ARCH_ROCKCHIP=y CONFIG_SYS_MALLOC_F_LEN=0x2000 CONFIG_ROCKCHIP_RK3288=y CONFIG_TARGET_FIREFLY_RK3288=y +CONFIG_SPL_STACK_R_ADDR=0x80000 CONFIG_DEFAULT_DEVICE_TREE="rk3288-firefly" CONFIG_SPL_STACK_R=y -CONFIG_SPL_STACK_R_ADDR=0x80000 # CONFIG_CMD_IMLS is not set # CONFIG_CMD_SETEXPR is not set CONFIG_CMD_PMIC=y @@ -34,6 +34,7 @@ CONFIG_REGULATOR_ACT8846=y CONFIG_RAM=y CONFIG_SPL_RAM=y CONFIG_DEBUG_UART=y +CONFIG_DEBUG_UART_NS16550=y CONFIG_DEBUG_UART_BASE=0xff690000 CONFIG_DEBUG_UART_CLOCK=24000000 CONFIG_DEBUG_UART_SHIFT=2
No UART driver was specified in defconfig, thus DEBUG_UART_ALTERA_JTAGUART was incorrectly selected by default since commit 220e8021af96741bd7149ca9895e1f0c8a38d0bb added a new Altera UART driver. Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar> --- configs/chromebook_jerry_defconfig | 1 + configs/firefly-rk3288_defconfig | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-)