diff mbox

[6/6] core/pkg-infrastructures: remove LD_LIBRARY_PATH from the environment

Message ID 0a14a9ff7f39c78d2a39f8ccde40a9f7a6d020b2.1447449754.git.yann.morin.1998@free.fr
State Accepted
Commit 34d081674ab8f0ffad84e5a18d3c67855826262f
Headers show

Commit Message

Yann E. MORIN Nov. 13, 2015, 9:48 p.m. UTC 
From: Ben Boeckel <mathstuf@gmail.com>

If system tools are selected, the host's lib/ directory may shadow
libraries from the system which are configured differently and do not
have all of the symbols required by the system tool.

Since buildroot now uses rpath everywhere, LD_LIBRARY_PATH should not
be necessary anyways.

Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/Makefile.in | 2 --
 1 file changed, 2 deletions(-)

Comments

Peter Korsgaard Nov. 18, 2015, 9:46 p.m. UTC | #1 
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > From: Ben Boeckel <mathstuf@gmail.com>
 > If system tools are selected, the host's lib/ directory may shadow
 > libraries from the system which are configured differently and do not
 > have all of the symbols required by the system tool.

 > Since buildroot now uses rpath everywhere, LD_LIBRARY_PATH should not
 > be necessary anyways.

 > Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
 > Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 > Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Committed, thanks.
diff mbox

Patch

diff --git a/package/Makefile.in b/package/Makefile.in
index ca34660..85008bb 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -296,12 +296,10 @@  HOST_CONFIGURE_OPTS = \
 	PKG_CONFIG="$(PKG_CONFIG_HOST_BINARY)" \
 	PKG_CONFIG_SYSROOT_DIR="/" \
 	PKG_CONFIG_LIBDIR="$(HOST_DIR)/usr/lib/pkgconfig:$(HOST_DIR)/usr/share/pkgconfig" \
-	LD_LIBRARY_PATH="$(HOST_DIR)/usr/lib$(if $(LD_LIBRARY_PATH),:$(LD_LIBRARY_PATH))" \
 	INTLTOOL_PERL=$(PERL)
 
 HOST_MAKE_ENV = \
 	PATH=$(BR_PATH) \
-	LD_LIBRARY_PATH="$(HOST_DIR)/usr/lib$(if $(LD_LIBRARY_PATH),:$(LD_LIBRARY_PATH))" \
 	PKG_CONFIG="$(PKG_CONFIG_HOST_BINARY)" \
 	PKG_CONFIG_SYSROOT_DIR="/" \
 	PKG_CONFIG_LIBDIR="$(HOST_DIR)/usr/lib/pkgconfig"