gpio: pxa: change initcall level second attempt
diff mbox

Message ID 1447446158-20213-1-git-send-email-robert.jarzmik@free.fr
State New
Headers show

Commit Message

Robert Jarzmik Nov. 13, 2015, 8:22 p.m. UTC
This patch is a second attempt at what was previously in commit
6c7e660a27da ("gpio: pxa: set initcall level to module init").

The goal is the same : enable gpio & pinctrl driver to work
together. As pinctrl driver will be initialized at device level, the
gpio should be as well, so that the deferring mechanism is honored.

Yet this patch should also respect the legacy platforms, so the set of
constraints is :
 - in legacy platforms (ie. non dt), gpio_[gs]et_*() should be available
   for machine code => core initcall
 - in new platforms (ie. dt based), pinctrl will be available and no
   machine code => device initcall

In order to fullfill all these constraints, the initcall level is either
postcore for non devicetree platforms, and device for devicetree platforms.

Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
---
 drivers/gpio/gpio-pxa.c | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

Comments

Linus Walleij Nov. 17, 2015, 1:56 p.m. UTC | #1
On Fri, Nov 13, 2015 at 9:22 PM, Robert Jarzmik <robert.jarzmik@free.fr> wrote:

> This patch is a second attempt at what was previously in commit
> 6c7e660a27da ("gpio: pxa: set initcall level to module init").
>
> The goal is the same : enable gpio & pinctrl driver to work
> together. As pinctrl driver will be initialized at device level, the
> gpio should be as well, so that the deferring mechanism is honored.
>
> Yet this patch should also respect the legacy platforms, so the set of
> constraints is :
>  - in legacy platforms (ie. non dt), gpio_[gs]et_*() should be available
>    for machine code => core initcall
>  - in new platforms (ie. dt based), pinctrl will be available and no
>    machine code => device initcall
>
> In order to fullfill all these constraints, the initcall level is either
> postcore for non devicetree platforms, and device for devicetree platforms.
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>

Kludgy, but what can we do.
Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Robert Jarzmik Nov. 17, 2015, 8:37 p.m. UTC | #2
Linus Walleij <linus.walleij@linaro.org> writes:

> Kludgy, but what can we do.
Indeed.

> Patch applied.
Thanks. I'll follow up with the current pinmux + partly pinconf implementation
to gather comments to amend/change/rework my current pxa2xx implementation.

I just need to split the patch into smaller chunks for easier review.

Cheers.

Patch
diff mbox

diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index df2ce550f309..bce99182578b 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -690,11 +690,23 @@  static struct platform_driver pxa_gpio_driver = {
 	.id_table	= gpio_id_table,
 };
 
-static int __init pxa_gpio_init(void)
+static int __init pxa_gpio_legacy_init(void)
 {
+	if (of_have_populated_dt())
+		return 0;
+
 	return platform_driver_register(&pxa_gpio_driver);
 }
-postcore_initcall(pxa_gpio_init);
+postcore_initcall(pxa_gpio_legacy_init);
+
+static int __init pxa_gpio_dt_init(void)
+{
+	if (of_have_populated_dt())
+		return platform_driver_register(&pxa_gpio_driver);
+
+	return 0;
+}
+device_initcall(pxa_gpio_dt_init);
 
 #ifdef CONFIG_PM
 static int pxa_gpio_suspend(void)